From: Paolo Bonzini <pbonzini@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH] block: drop "sending ioctl to a partition" message
Date: Thu, 21 Sep 2017 16:59:42 +0200 [thread overview]
Message-ID: <7717bb8d-4223-9401-f9fa-0deb6d33f784@redhat.com> (raw)
In-Reply-To: <20170921145300.GA1617@infradead.org>
On 21/09/2017 16:53, Christoph Hellwig wrote:
> This looks ok to me, but do we even need to keep the special
> cases above? Is there anything relying on the safe but not very
> useful ioctls?
No idea, I stuck to the usual "don't break userspace" rule.
Honestly I doubt anything is using most of those ioctls _in general_,
not just on a partition.
Paolo
> Condensing the thing down to:
>
> int scsi_verify_blk_ioctl(struct block_device *bd, unsigned int cmd)
> {
> if (bd && bd == bd->bd_contains)
> return 0;
> if (capable(CAP_SYS_RAWIO))
> return 0;
> return -ENOIOCTLCMD;
> }
>
> would certainly be nice.
next prev parent reply other threads:[~2017-09-21 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 14:49 Paolo Bonzini
2017-09-21 14:53 ` Christoph Hellwig
2017-09-21 14:59 ` Paolo Bonzini [this message]
2017-10-03 16:22 ` Paolo Bonzini
2017-10-04 6:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7717bb8d-4223-9401-f9fa-0deb6d33f784@redhat.com \
--to=pbonzini@redhat.com \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®