From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89913C43217 for ; Thu, 1 Dec 2022 06:15:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229732AbiLAGPZ (ORCPT ); Thu, 1 Dec 2022 01:15:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbiLAGPR (ORCPT ); Thu, 1 Dec 2022 01:15:17 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4049EA85DD for ; Wed, 30 Nov 2022 22:15:16 -0800 (PST) Received: from dggpeml500025.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NN5Q03XVmzmWK0; Thu, 1 Dec 2022 14:14:32 +0800 (CST) Received: from dggpeml500003.china.huawei.com (7.185.36.200) by dggpeml500025.china.huawei.com (7.185.36.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 1 Dec 2022 14:15:14 +0800 Received: from [10.174.177.173] (10.174.177.173) by dggpeml500003.china.huawei.com (7.185.36.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 1 Dec 2022 14:15:13 +0800 Message-ID: <771e309e-d7c6-d4db-ab11-0df05db6b9a0@huawei.com> Date: Thu, 1 Dec 2022 14:15:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [syzbot] INFO: task hung in gfs2_gl_hash_clear (3) Content-Language: en-US To: syzbot , , , , , , , , , References: <000000000000d482ba05ee97d4e3@google.com> CC: , From: Yu Liao In-Reply-To: <000000000000d482ba05ee97d4e3@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.173] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500003.china.huawei.com (7.185.36.200) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/11/29 16:32, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 6d464646530f Merge branch 'for-next/core' into for-kernelci > git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci > console output: https://syzkaller.appspot.com/x/log.txt?x=167aebbb880000 > kernel config: https://syzkaller.appspot.com/x/.config?x=54b747d981acc7b7 > dashboard link: https://syzkaller.appspot.com/bug?extid=ed7d0f71a89e28557a77 > compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2 > userspace arch: arm64 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16467353880000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=168c3d03880000 > Fix missing call gfs2_make_fs_ro() int gfs2_put_super() #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b7b275e60bcd --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c @@ -584,9 +584,7 @@ static void gfs2_put_super(struct super_block *sb) } spin_unlock(&sdp->sd_jindex_spin); - if (!sb_rdonly(sb)) { - gfs2_make_fs_ro(sdp); - } + gfs2_make_fs_ro(sdp); WARN_ON(gfs2_withdrawing(sdp)); /* At this point, we're through modifying the disk */ --