From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26404C433DB for ; Thu, 7 Jan 2021 10:59:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C465A2246B for ; Thu, 7 Jan 2021 10:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727149AbhAGK7i (ORCPT ); Thu, 7 Jan 2021 05:59:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59985 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbhAGK7i (ORCPT ); Thu, 7 Jan 2021 05:59:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610017092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eJuYKsFgeD/TaN1guAoXSRGGao5WVLChcuMpd8zsQq4=; b=eATXoRTV0j76W6i92snMhCvsEroZV7rPW6UbTm6iEeFtFcbbpIA5R1/RtXrU5/FiaP4Dc7 SNMWrtxd8NMUyjgGZF9mh6eWgidW+Jj0izMY3UhcIbN3nys1JLuEhozVgRn5XnhKGZefeG Xcgr2jti49eVoWYRiE/NDZbDEV7qJTw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-PLDymmrbNOGnq5zJt0MzTg-1; Thu, 07 Jan 2021 05:58:09 -0500 X-MC-Unique: PLDymmrbNOGnq5zJt0MzTg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 47B8F4239C; Thu, 7 Jan 2021 10:58:06 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-8.rdu2.redhat.com [10.10.112.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 67BC271CB9; Thu, 7 Jan 2021 10:58:03 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210107092855.76093-1-tianjia.zhang@linux.alibaba.com> References: <20210107092855.76093-1-tianjia.zhang@linux.alibaba.com> To: Tianjia Zhang Cc: dhowells@redhat.com, Herbert Xu , "David S. Miller" , Gilad Ben-Yossef , Tobias Markus , Tee Hao Wei , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] X.509: Fix crash caused by NULL pointer MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <772252.1610017082.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Thu, 07 Jan 2021 10:58:02 +0000 Message-ID: <772253.1610017082@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tianjia Zhang wrote: > On the following call path, `sig->pkey_algo` is not assigned > in asymmetric_key_verify_signature(), which causes runtime > crash in public_key_verify_signature(). > = > keyctl_pkey_verify > asymmetric_key_verify_signature > verify_signature > public_key_verify_signature > = > This patch simply check this situation and fixes the crash > caused by NULL pointer. > = > Fixes: 215525639631 ("X.509: support OSCCA SM2-with-SM3 certificate veri= fication") > Cc: stable@vger.kernel.org # v5.10+ > Reported-by: Tobias Markus > Signed-off-by: Tianjia Zhang Looks reasonable: Acked-by: David Howells I wonder, though, if cert_sig_digest_update() should be obtained by some s= ort of function pointer. It doesn't really seem to belong in this file. But = this is a separate issue. David