From: Jonathan Cameron <jic23@kernel.org>
To: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
Cc: tony@atomide.com, benoit.cousson@linaro.org, rnayak@ti.com,
peter.ujfalusi@ti.com, kishon@ti.com, jic23@cam.ac.uk,
grant.likely@linaro.org, rob.herring@calxeda.com,
lars@metafoo.de, sameo@linux.intel.com, ch.naveen@samsung.com,
poeschel@lemonage.de, milo.kim@ti.com, balajitk@ti.com,
gg@slimlogic.co.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver
Date: Wed, 17 Jul 2013 20:04:02 +0100 [thread overview]
Message-ID: <7725cc73-4cab-49f5-9c33-ef3b24a7ee57@email.android.com> (raw)
In-Reply-To: <51E668B4.1010000@ti.com>
Oleksandr Kozaruk <oleksandr.kozaruk@ti.com> wrote:
>Hello Jonathan,
>
> >Two very quick comments based on quick glance as it may be a while
>before I can do a full review.
>
> >We still have channels that are only usable for temperature being
>output to user space as voltage channels? Is the conversion so very
>hard?
>
>Can you please clarify what should return temperature channel for
>in_tempX_input (processed)? Is it voltage or Celsius degree?
Milli degrees centigrade.
>in_tempX_raw should return ADC code? Right?
Yes
See Documentation/ABI/testing/sysfs-bus-iio
>
>Regards,
>OK.
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
prev parent reply other threads:[~2013-07-17 19:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 11:27 [PATCH v4 0/2] " Oleksandr Kozaruk
2013-07-16 11:27 ` [PATCH 1/2] ARM: dts: twl: Add GPADC data to device tree Oleksandr Kozaruk
2013-07-16 11:27 ` [PATCH 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver Oleksandr Kozaruk
[not found] ` <c8f86766-822b-4fe3-ae2a-e0b12412ef39@email.android.com>
2013-07-17 9:49 ` Oleksandr Kozaruk
2013-07-17 19:04 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7725cc73-4cab-49f5-9c33-ef3b24a7ee57@email.android.com \
--to=jic23@kernel.org \
--cc=balajitk@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=ch.naveen@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=jic23@cam.ac.uk \
--cc=kishon@ti.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=oleksandr.kozaruk@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=poeschel@lemonage.de \
--cc=rnayak@ti.com \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®