From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752290AbcGGJwV (ORCPT ); Thu, 7 Jul 2016 05:52:21 -0400 Received: from smtp.citrix.com ([66.165.176.89]:53541 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbcGGJwU (ORCPT ); Thu, 7 Jul 2016 05:52:20 -0400 X-IronPort-AV: E=Sophos;i="5.28,324,1464652800"; d="scan'208";a="364800316" Subject: Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group" To: Roger Pau Monne , Jan Beulich References: <577E233202000078000FBE11@prv-mh.provo.novell.com> <20160707094535.wsgrxlnib5ajcsdc@mac> CC: , From: Andrew Cooper Message-ID: <7732540a-aa37-9e33-e805-838dc4c43676@citrix.com> Date: Thu, 7 Jul 2016 10:52:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160707094535.wsgrxlnib5ajcsdc@mac> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/07/16 10:45, Roger Pau Monne wrote: > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: >> The functions such get passed to have been taking pointers to const >> since at least 2.6.16. >> >> Signed-off-by: Jan Beulich > Acked-by: Roger Pau Monné > > Although the wording in the commit message looks weird to me, but I'm not a > native speaker anyway. As a native speaker, I can't parse it either. I think s/such/these/ is needed. ~Andrew