From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D4C83F23BE for ; Mon, 27 Jul 2026 09:50:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785145861; cv=none; b=oUu83WTO1P/OHGa2ognbKV9z+Rpr96MdP8QNw8LT+28c40L3A8gqJ/V7D55boHEPwaePe5q4TA9cyyiEE7teUIs3hX97aTawJnIaX6vfguHGGzxCrNvr4CQkIThIbDqysc6zMSXCJccrCEV8t8/oRuOo8shn09uLil0njsjHybQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785145861; c=relaxed/simple; bh=c4RqjY6KZF9m67IHoI3DmJuEKYlcA0wH3I4H2KYFB1I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f8b9HtVvzoouvfoJVzbmDSOyM9xVurhXMhvsqKJ4SYDlSC0OoG33iFcAm1cNxGZwy0bfO0EiBrmfEgUMi17YWcnplx0EHf3c4mzEKgdr6/lltF4jT59X5k+1KvR+TnsJDydywHfhfCJFhKKMk6kuwg2CU2s2v/vgaLCf+2rCkPo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lXXZW8Tc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c7a3ySGJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lXXZW8Tc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c7a3ySGJ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66R9Wvwj278844 for ; Mon, 27 Jul 2026 09:50:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TFwS8dPPBX/iwtv/BEnalT5oLdkzhW1l834RoovjLDI=; b=lXXZW8TcxUOvERm1 VSlD0VtELDYugWRaxAenx04bHWWSlRir1qZSZDBSQcXS5HxwUgWKZde/6aj4ZPnk vsY29I1qwFWlyXqcQ6fjJCRnOAK2N5QwGsuCFny2l8ZmNeISLmZWFSu7m+V3QRqs MAPhMVFekH43ckwB//O+Od+vlRRJ9ectChw01nbDLRMa6S4izmbKm45LVHZS3ONT wlgzKJ8QFKtI1wgbl1Gkw80aB0wqLyh688N0uV06WLq0/e61fzYMvqg+wJPAemh+ Km8nY/3srSsPLxhzYNzesVmNDSn7V7ExlucXaiwbBwRz8siv8znWIpVcNvQw1/QU TFJ86g== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fny9whc7d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Jul 2026 09:50:48 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84877b362f6so4201684b3a.2 for ; Mon, 27 Jul 2026 02:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785145848; x=1785750648; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TFwS8dPPBX/iwtv/BEnalT5oLdkzhW1l834RoovjLDI=; b=c7a3ySGJZn5Vy3vS+fIqZxEYBTLHOfkv/cVZ/LakLc/2ea4C8JQK430Q6vs/krmG+s dGy2eFE8pLAl5TMX6Ck2HmIRN132zPIBzQveMyuxeYm9m15Xk9W1PtElejqkDSJeAW1/ WwWw8x4ASCAe02+BvurpumtnoqCwRdwfaOnwifhAN+gP4v4wxrwBbbhmo3b/79pgvVjB gtLgBGcvXkrqRCNh1yox5r1jyYdiI/cAfwSniYaDLg72kQFUbwPecfcwkKi9tBnek3/k DIxhLU88hQjweEaSKMu3/f15plAC2oKHhTh8za/sf11tzniXSCBL9TSfTV10HOOWcAAE P9VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785145848; x=1785750648; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TFwS8dPPBX/iwtv/BEnalT5oLdkzhW1l834RoovjLDI=; b=qB+MGu+PQMd0htUbZtIOqiD7n9V249QOABj/zP6+bVmiZS13Um+/IeGe4tVMd1vPP+ vOLB+du+BSZTrymI0hDpmtdPalboMldS9p/T0A8E2a1AaOGiDa/vHPxdHRjmMKH/kz/L HxPJi3OZRX54r7xRkqkX7qH6AIc0CGcAeoIYhhmLJTd24/kUdX/0BCmBki7X/IGHGeRu V8+WvTXiILvvSVASc6VTqhxtYIExPJUNCk7BqLL7iTdhyLMzW6tLEvuubhfieYkq2i09 iJEx0AzNN78v3i2qJUv0avsfpKQwmEa0QmCicZ+snBvtk2YbZ2oLg7kvKVL1+m1Ijglh SSQA== X-Forwarded-Encrypted: i=1; AHgh+RrvTGr65qvk4VAq21wyJnC5uWyz2nDfzw4S9m/qSlNTrCdJfXjDaVDTJxY5mHg61LMY629JVGdg98uV83s=@vger.kernel.org X-Gm-Message-State: AOJu0Ywjtj4Xh+8iOJNE7rpqyWa9lS5u4lpx9iIShpK3AlViWYetSOXA 3bZp5LksT0hAR1UV+DHz5tD+ca3iMy3C8CAf7M/cuWKblAvGkjyAUiQ5mzVYmrkPiQKf1rVu+8W gY5OiEw9J0GN9vw1eL5ABlJuXLAdvSg8soejyviZzN2XZHfra35YGvyEH2Vmb161Q0vc= X-Gm-Gg: AR+sD10RJvrzK8KgxnT0csMyPsKuZ4d9lWl2sZ5zCqqw+Utn+kwcZ+hIuf32vy2MKfw nUqCD97c340XliEZ3pe/V8kFDVNuMzkR39qwGBFQZGlGUGM0/pzxRAnBP8GXfJ2G9tlCxLxzdjm zfcWy6HFpp9rymqaj2lSKdfYgj6svFFBd5wrMATI1Xgyk9dUJ2sv2xIwTyaQSLoS5y261IvMNpE YWO77SvoEgnY+0B34zAy0OWgAjpddlH1Z5m3YEPgmZC/RpmA2PKoCAuEFTCIKYWS6ZDg4lJD4Zv q9Abn233swU77he9KWkc7SactPh+fp8jY5iyHTkO920BHknOXfEKIXMZ2TTZ68gJbbFxquAvqSB AAZ8SZFNqZs/dlvURsF5/o9FuDQOEdVLMBw== X-Received: by 2002:a05:6a00:2288:b0:848:2f84:733 with SMTP id d2e1a72fcca58-84e5959cb20mr6015791b3a.70.1785145847629; Mon, 27 Jul 2026 02:50:47 -0700 (PDT) X-Received: by 2002:a05:6a00:2288:b0:848:2f84:733 with SMTP id d2e1a72fcca58-84e5959cb20mr6015766b3a.70.1785145847141; Mon, 27 Jul 2026 02:50:47 -0700 (PDT) Received: from [10.217.219.72] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e5327f23csm2821805b3a.17.2026.07.27.02.50.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jul 2026 02:50:46 -0700 (PDT) Message-ID: <77339c83-3fbf-4903-8ca8-824dc7f45839@oss.qualcomm.com> Date: Mon, 27 Jul 2026 15:20:41 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] i2c: qcom-cci: Fix CCI clock rate enforcement To: Loic Poulain Cc: Robert Foss , Andi Shyti , Wolfram Sang , Dmitry Baryshkov , Luca Weiss , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vladimir.zapolskiy@linaro.org, Wenmeng Liu , Konrad Dybcio References: <20260727-cci-clk-fix-v2-0-c3958f28b045@oss.qualcomm.com> <20260727-cci-clk-fix-v2-3-c3958f28b045@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI3MDA5NiBTYWx0ZWRfX0xUChF9MCKG/ Gyln0oYudvi7msby6tIT8+fEbkInsyrt+WidriftnlWknsAv9eoxP4bvvJaCAyLJw91CGD+7Xpx /39s6+JBxzCkSi10/WaZzrmbz84UfALjHhKwk0mCTZLY7mpnbbnpaISYH3yBvTN5vygvL5SrQgo AXkmnUmRJI+75mMuztxMPBbq760jJzpwV3pRDhawbrbGIEnNfLWNnzhBCX1XreLvVmUzE1Ij7Zn nHaEHLXxeA5nDO74uW77SHhmYAfLFVW6tkDKoUt0St6UJRZpyyXnUcAQSEd2MVPDgTWfP8+lK1O 13AeJCLeIx9OzHBVNgK7QO1LOR+fEIHOlW4kGV314AdwAvKCcDsGQThy26EnJnzF8EvJZHboVIV YRZzxx3AWIQ/2fsFhnjvN5RU+qfccHBuhystH3DB6W0AiAN0G9sA5eHnWths3DKLXg9CpeWMsu8 5dAyg1HTBz+tRz4nLzg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI3MDA5NiBTYWx0ZWRfX4FQzM6nUHdPf LoBMCMZ+6THORxHDWkJaWxM22anutcXoWJjXYjUjDD17nr3pDRsy+c9XpMi54tn6/Q8Z0ywWFws 5mgJwVK7MDnVTGyJZg6QEun4KBJ1LWI= X-Proofpoint-ORIG-GUID: KfxXCL6eGBjsj2bfrdlhtO2ZI1CrBs25 X-Authority-Analysis: v=2.4 cv=E4b9Y6dl c=1 sm=1 tr=0 ts=6a6729f8 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=f22_Un8MVmwWBd_wUBEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: KfxXCL6eGBjsj2bfrdlhtO2ZI1CrBs25 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-27_02,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607270096 Thanks Loic ! On 7/27/2026 3:15 PM, Loic Poulain wrote: > Hi Mukesh, > > On Mon, Jul 27, 2026 at 11:33 AM Mukesh Savaliya > wrote: >> >> >> >> On 7/27/2026 2:51 PM, Loic Poulain wrote: >> [...] >> >>> @@ -587,6 +618,24 @@ static int cci_probe(struct platform_device *pdev) >>> return dev_err_probe(dev, -EINVAL, "not enough clocks in DT\n"); >>> cci->nclocks = ret; >>> >>> + cci->cci_clk = devm_clk_get(dev, "cci"); >>> + if (IS_ERR(cci->cci_clk)) >>> + return dev_err_probe(dev, PTR_ERR(cci->cci_clk), >>> + "failed to get CCI clock\n"); >>> + >>> + ret = devm_pm_opp_set_clkname(dev, "cci"); >>> + if (ret) >>> + return dev_err_probe(dev, ret, "failed to set CCI OPP clk\n"); >>> + >>> + /* OPP table is optional */ >>> + ret = devm_pm_opp_of_add_table(dev); >>> + if (ret && ret != -ENODEV) >>> + return dev_err_probe(dev, ret, "failed to add OPP table\n"); >>> + >> >> if this is an optional why to return with an error ? IMO, further >> operations should continue which are not opp dependent ? > > The OPP table is optional only in the sense that it may be absent, > that's the -ENODEV case, which we deliberately don't treat as an > error. If a table is present but malformed, or can't be added yet > because a required resource isn't ready (-EPROBE_DEFER), we do want to > report/propagate the error rather than silently continue. This is the > established idiom (spi-qcom-qspi, qcom_geni_serial...). > Sorry, understood now. hence protected with both the conditions. Makes sense. > Regards, > Loic > > >> >>> + ret = cci_set_core_rate(cci, cci->data->cci_clk_rate); >>> + if (ret) >>> + return dev_err_probe(dev, ret, "failed to set CCI clock rate\n"); >>> + >>> ret = cci_enable_clocks(cci); >>> if (ret < 0) >>> return ret; >>> >>