From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1728533EAF2 for ; Tue, 3 Feb 2026 12:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770122898; cv=none; b=pp2UcM/8NpuHijzm2DdQZA/g7nbMGq2CACRaBo/NMi9asa/p8RitOq4pfcJ1Ti/Zh/I5tCwKTQcdaMli53Xrz1WJdjWIKv3n9lxy9vl575k5s5IiUqYpMd92rRAIJ6+7tWCRtPVsHxGzrBMUeAnhpkJNsNXdeGiC0koJjQQbtQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770122898; c=relaxed/simple; bh=TsBycMBF9tmAwhfR9s/Ou+SnZGtzHqmnz4gVFu+lt1U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lfv9ASZ7S/9EKsA0X3uLaK1V5auYRB0dLB9a6hTvk+p5PDbYujx8QITec/4Q4grRnbKYH9wLTZDBlAVerydeefpdA0fZ4qU2+wEJb4mSoGbc0IteHBdetd69ioXGISDb2RYdAXPVU5OOh7NLMy4y1FwUH6817RyKNK594e44czk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=icni1UEx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VXKZ3X7O; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="icni1UEx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VXKZ3X7O" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 613CO3vC1777070 for ; Tue, 3 Feb 2026 12:48:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b5reiRMxf7eQPz/r0JsXzDKnp3PHnj9+4R8qPa+QT20=; b=icni1UEx5BbtmfoD WQ2eRYue9Z40/HVaG8XNwZFFrgeKyByNqpl6gaShT4fRWQSEvtQRaU6zyXu7rEg0 c1fLkj21pYApOtw3WJzy8Ibyoj0IJxMUyNQZ5/fcmz3yU1SSV6e1z1TlJmJWlGCW O5d5NOYogkfaGf7xlzNuvtgv3xYts5tLi4LBWpN7w7BCHcp0ngPhBvL9gpljW4Pa n9aHyacvOaDVuR5wwOC1StU0cAPfo7e+MH8Cntu/5TJvytWmVSiFDGZ7gxiUl+OG Xim4uFcbna5NVVBC184pJLQ+pOyQWZ7y9bN0p6TqPvYHDbVTP6fbb/3EutJ4FIFY R+RC0A== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c3h07g255-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Feb 2026 12:48:16 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-505e8451617so5551711cf.0 for ; Tue, 03 Feb 2026 04:48:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770122895; x=1770727695; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b5reiRMxf7eQPz/r0JsXzDKnp3PHnj9+4R8qPa+QT20=; b=VXKZ3X7Ot30U0mo3xdWmbbu6RX08sIHtkB7972xzcukQEdPeb0rxNXVDX48mn7q8cM YFC5nVDEfsSGx3irk8Z1Bn6sNkofza24icS16mQH3i9cFvSODtiyZ3mB5m9sc36IMwVG zXec4HJezfDmqJGDFkUOpXsLhyPmDjXyjJdH8C53b8miA8KxYBUpmbWfMMbiQYK1ARs2 lJNah3sDOb4lRUl/6MX3ovGPko8Btfr61zH0X3cY77r+7H7pwaoKBjMw7S9gHL8qWa4D qPKCbeHkZI9n2C4q0/dA2+b3sXNCW8uKjDJAxBISafyrNnYyuvDZ8MCxGcj5oy90vKXQ ghhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770122895; x=1770727695; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b5reiRMxf7eQPz/r0JsXzDKnp3PHnj9+4R8qPa+QT20=; b=eO3QFbyXCNR/IX+6ppj57IoUdE1m83fODaIPFLVr+SJHlFNT3awUie/KWrKII8NrvV MJgW55frMLsKgemjnDDQqYd+vZomregGdDqf5ipLRnL2chFWXmzy3RPJtoDg8IMmoE/s mtVyvymMf717uMjY/JYn6ek17YuP4nEWcqTE2DIuGGRipZalcXebBsPUmGxv3SCdhoQQ gmoVZJFVFAyqQ5p4eWs+loesul19DIb6QTLZJN6JXyVQqDMrby3xh7jE7btO6W0G3Uc2 stNM6aliFBeXYeBV74qugD90KOfPktMsH5qSnbR7/T6iaXCN7gIhfdIHXlLTq9gIS9LK BTEg== X-Forwarded-Encrypted: i=1; AJvYcCWpvc+lhfiUIUQEbBqfYhh3rSJaS70rH9Pg47mhRqOR94NnKjdmOLiXxiMKXklZ+wEEckMAHV00mTNF8Ak=@vger.kernel.org X-Gm-Message-State: AOJu0YysemokCFKL6XoKrGInrnN6r/UV37/wSqX1vJrkBYMLCEkvx/yU xsSVBpilJ/jnHo4mJw9JiA0GH87sTXL82ofZBpNzIYBKmFd1AQX47+Dm3M8Lw9dtay+GosqhP4b Bhgtenk7gCXIwOO1/9MkTUxd6maAm75IRXTOhvIi8PZoIaLED8RfUWmayHeAcpP1wRfE= X-Gm-Gg: AZuq6aLm4DrKIzHwig+2Tl5TUBxM1n/Mr0iy92TnbrDqXRIAZ1yyBHLL8I4Qbdz1tLH RUVmjmwmV+zsR/j1i3PKM39LDeiNYjiLL5Kzw2/0Sma6rIK2DeAzWUBALtrVtxUiZyo7BFoKOEu 0lhrxlnqWJvQ1JSa0dRZ3ucWqYqezt5bugh00pNikGq+O1cN+YtbRdKA7ghqhbsrJgO0PAcRL+P FqO9NWNmkpWS46xmbSu4i9nDTuURsuPfe2BaYhuSNyIl4ihGD2ZuB8QeA6Tnrl3bVmDtDRNpcNs p0Z+xC670t0NfvNafhF9iVMDAGnkr+MTprFUcBcyU/Z5RSoE1f/AeuJBQa8AaDjcZC2tVrXUHsh F9rAz60mIPjFinXsHSIZUPDxe0Uh8Ubm8BgqFQRGDN1J/0dJ3h9dao7B53hKAqE//XSE= X-Received: by 2002:ac8:5f4c:0:b0:4ee:4482:e838 with SMTP id d75a77b69052e-505d213bc9emr154675731cf.1.1770122895411; Tue, 03 Feb 2026 04:48:15 -0800 (PST) X-Received: by 2002:ac8:5f4c:0:b0:4ee:4482:e838 with SMTP id d75a77b69052e-505d213bc9emr154675431cf.1.1770122894914; Tue, 03 Feb 2026 04:48:14 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e0a5a3b1asm685936366b.57.2026.02.03.04.48.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 04:48:13 -0800 (PST) Message-ID: <7733eac7-8158-40f8-8887-44e458d33e9b@oss.qualcomm.com> Date: Tue, 3 Feb 2026 13:48:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 11/13] i2c: qcom-geni: Use resources helper APIs in runtime PM functions To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> <20260202180922.1692428-12-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260202180922.1692428-12-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDEwMiBTYWx0ZWRfX1tEjqkzTPTOJ q481y2vvBw2iiVSAJTVtZWIkS6Wlq1mwSRJzTaRG4pXWlZOJ87uQK0DNwK2n6rRBAnUUMKimDay l3mR7FpmMgO/P5qDtm+xMra0Bq3Nk2XAY8s6xyEgKZDczNcKM3RA8owJf1/QfIw4Tc3R68Mea9c 8lk7o2Wc+AcrfRKn49XPZUsSC/WdA62cx/3meZFrbIUfj2e6UEZ7klebG3kf8Crd6za7O1pbXDS QQT0nPWr1FcG4k7iWqAdMAYw08BSf8Qcgi6r5Ps9BBOuHx3O3enh/P25LmnEkTzxwrShWTgSCa9 qCnnJlylrTFm3JrJikN5X+/TFusDNmXmoWmBlqbvUqGAPhBXns0/Fon3PMNaBt7xF3F6KoKti3J /5ysKT8PDV4T3AJwFDO3RbcY78nOZudspVAMCSjefc3aAtOeu64mZwBA3mMS5Ti+Q4YM3LtwHz5 ZriYMFAFkxa+sy1YI9Q== X-Authority-Analysis: v=2.4 cv=CMknnBrD c=1 sm=1 tr=0 ts=6981ee90 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=gzD-2WDeCj_JQFVUwcoA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: S6Pqc_xq_wtDR79wXEKCIMG26ZeaSSa4 X-Proofpoint-GUID: S6Pqc_xq_wtDR79wXEKCIMG26ZeaSSa4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_04,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602030102 On 2/2/26 7:09 PM, Praveen Talari wrote: > To manage GENI serial engine resources during runtime power management, > drivers currently need to call functions for ICC, clock, and > SE resource operations in both suspend and resume paths, resulting in > code duplication across drivers. > > The new geni_se_resources_activate() and geni_se_resources_deactivate() > helper APIs addresses this issue by providing a streamlined method to > enable or disable all resources based, thereby eliminating redundancy > across drivers. > > Acked-by: Viken Dadhaniya > Signed-off-by: Praveen Talari > --- [...] > disable_irq(gi2c->irq); > - ret = geni_se_resources_off(&gi2c->se); > + > + ret = geni_se_resources_deactivate(&gi2c->se); > if (ret) { > enable_irq(gi2c->irq); > return ret; > - > - } else { > - gi2c->suspended = 1; > } > > - clk_disable_unprepare(gi2c->core_clk); I believe you can give gi2c->core_clk and desc->has_core_clk the boot with this patch since they're no longer referenced anywhere Konrad