From: Leo Li <sunpeng.li@amd.com>
To: christian.koenig@amd.com, alexander.deucher@amd.com,
arnd@arndb.de, michel.daenzer@amd.com
Cc: airlied@linux.ie, Jordan.Lazare@amd.com, harry.wentland@amd.com,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] Revert "drm/amdgpu/display: Replace CONFIG_DRM_AMD_DC_DCN1_0 with CONFIG_X86"
Date: Fri, 17 Aug 2018 09:56:57 -0400 [thread overview]
Message-ID: <773509cb-9760-325c-42ee-abe76684ea32@amd.com> (raw)
In-Reply-To: <8d7c294c-6585-01f1-cd78-5c30cd30142d@gmail.com>
On 2018-08-17 03:16 AM, Christian König wrote:
> Am 16.08.2018 um 21:44 schrieb sunpeng.li@amd.com:
>> [SNIP]
>> +config DRM_AMD_DC_DCN1_0
>> + bool "DCN 1.0 Raven family"
>> + depends on DRM_AMD_DC && X86
>> + default y
>> + help
>> + Choose this option if you want to have
>> + RV family for display engine
>> +
>
> Probably better to follow Michel's suggestion and not make that an use
> configurable option.
>
> Instead just select it based on the dependencies.
The 2nd patch should have taken care of that :)
Leo
>
> Christian.
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2018-08-17 13:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 19:44 sunpeng.li
2018-08-16 19:44 ` [PATCH 2/2] drm/amd/display: Don't build DCN1 when kcov is enabled sunpeng.li
2018-08-16 21:05 ` Arnd Bergmann
2018-08-17 7:25 ` Michel Dänzer
2018-08-16 21:29 ` [PATCH 1/2] Revert "drm/amdgpu/display: Replace CONFIG_DRM_AMD_DC_DCN1_0 with CONFIG_X86" Alex Deucher
2018-08-17 7:16 ` Christian König
2018-08-17 13:56 ` Leo Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=773509cb-9760-325c-42ee-abe76684ea32@amd.com \
--to=sunpeng.li@amd.com \
--cc=Jordan.Lazare@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arnd@arndb.de \
--cc=christian.koenig@amd.com \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel.daenzer@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®