From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36B963DD870 for ; Tue, 21 Jul 2026 18:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784658030; cv=none; b=AiHNu3SLLW9kjiN/qybvUDplHGTncOrQDxgs2yvucIwgNiqW7ulGNmX6WjidssfuLYWMYj1AYnSysh99hhc27G39E+qz2q/xzW9ZMynrw+RElflqzkTbP+r+hVeilbAqwiZbYN+uSUTAM7sQMC95rttoiXBMR1zOxR9Mu23Yjq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784658030; c=relaxed/simple; bh=9I8SuSEzPUmQkXgAoO8qB39k16yQ61FTlzIkj3Jiy8U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=It6L2158sxQzhDTIjriemkHJiyDg5mu3qIxhfBLNlGzrmwzZffhDhWR1VDkeq06UzA67jrgKlnaifxXJfhihyPhwVRVEpk74T7En12ufv19HC+ImH6picNf7wzPudy41eaolD3xQL5VtRhf/NP5B2v7LCpbGxI6M+9fuJjMavcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FJj05R2s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IeRmYYGt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FJj05R2s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IeRmYYGt" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LHPIck2114906 for ; Tue, 21 Jul 2026 18:20:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fc5hVouaXSdYpjHELQxCbl6GfmZ4wxwxC4HC57BPPkk=; b=FJj05R2svGpfrQnX c4tc7mBvFM9B4aQNDUteAR7It2s6TbFcwp6eeV+GQ+dxnRwu7id/oQFmugx1iFfs M96r+iZL1B8zDG38y5RvigS6wes1uF5nrMDq9xvpt9tClke6yOW2xFyw2WQEGowt 2VBHXx74dRPKyUeIHBYPKWuhnxXVmob39F36XTu+qx8nS925V1A97i0O2jkILy9u Gikiv0FdE4LRx3Oj/+qL3AdcN4Zz+q7VdyxB+vXn/A0auBxFvkqYS3CIg15tk47q z4c23L3sCtCMvuDTX/KJOah7FDg4OHwR7jPQDJbTdhxPtoNYVPJYr0SgYzF5UXqQ OExG+w== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fjd5e08n1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 18:20:28 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cceabd70f5so226000655ad.1 for ; Tue, 21 Jul 2026 11:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784658028; x=1785262828; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fc5hVouaXSdYpjHELQxCbl6GfmZ4wxwxC4HC57BPPkk=; b=IeRmYYGtxW6HjkSbKsjC/0OHYZnVjN7zFd3Ntp3NWP3MN84/Vt1JAHf20foS+eXpPZ QuEg0mznMb6YbOzdXI5YyU7amROZA62U2VsHsk1cjo2dWxB2YjkeV89HVIKmmT4CUQ+f Ov9/hG1ndQ0PUXN9V9YPIS8SuAPf7lDq3JcRZFOMrRVVfFagqCQgbEltkDLJQ+Zwq0AA ztc2TvTrYQOGY6QHJBaZcKk/3XNKujoQGRpxfHpxxmKc6Zd+5da0t+cGUNApRPK9b+Qq SQqE19+G8WjB/eAtl3qU+IUQoY7WPBmuJCjZ6K7lCCrDlugfTIQKkNXXduOZtEdf06Ks ORwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784658028; x=1785262828; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fc5hVouaXSdYpjHELQxCbl6GfmZ4wxwxC4HC57BPPkk=; b=pbc920EekwDmf6PmsekfEFUnrXbm2Wih+8AExSVinqNL8roxUBoG7i49iDoiT53EvH ir7FntLRrbABKpVQiDvS4InpegNdXaE8HsvsKTCNUMeOC+9Miy1tVE9j4WtnlfByA9rO w+SENAId8kKpLK705NQZO2JBiNCW9Bmktn3Au+R8FRoN4/b9Ddiy/U3JXk+zrqlDOe0v M9Ah4bdlL/HdWeFO0hP/VEJU3SSmFJH8Uv8/3KVL0OyP38ZAMS17sM0dzquDGm0olgDC B5jiN2lW8afA/mfDkHfzzoxKlBGvcNzWolXoaEpYJCPME2irrkvAvvKxfgEAHWuYuZ+6 YKyg== X-Forwarded-Encrypted: i=1; AHgh+Rq6cdemBmcXbFM7s+wV3EzAqDTQH0VaZYmnoNH2DNlIPX/r7PUERHqqjHvp9kSa8zp0L2HWJMrnE/Ajo7g=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0b2L7xzCNsTqRlMoRG8FIVQMblFl5ibST4hCCetafdNnTP/RY 2z/+mq2ARacmUBBOmJbTxcNsGoZm4V+HS95dj31vtndKmKrT0U3HIObJDZGc9gxSVszcN1+ixrU fe9CZ43hC24dwWtxmOqt1KMAeH09y8KaeHWx2ah2kF66wqWFjQezYcPQXvzEMlESP+7w= X-Gm-Gg: AR+sD10xRsDdMtufCzjn2eiD5LD+TudMmZwQw/0JzuUTSFtkI/xUDln0umhcht8DXSX Z2Y5xM0jjXaVpVcn4Uepcgp24pbEeN8cGZOWIOvGTrBdPk9la+YPGdcBnXCqhxJX+zTi8Q9b1Gn 1/XaOwH9HQLa/AsHjqimNNejQdkcaLiOxn+L7VFOa4z3pqYUkwV8vHSW7yAGPaafGmXaon1Upt0 Ec3TDdWSjVU28YLrdOU54W3I+2gNgScu2L06WQMQkgD+TUmIjCqDv1SViMAUwaepyrk+ol9mz+1 JqzgDlndPXjiVu7aCzYh/LlYSE5qZRRNPd7DOYsIsITK17S3WjAlNqbjnZnbsUa6qnoFPf11FOg v4nmoUyGl425QXp6kD5nkyWJ4Fpgr/b7hUSY= X-Received: by 2002:a05:6a21:7008:b0:3c0:9c1b:d0b5 with SMTP id adf61e73a8af0-3c3ad9a4de9mr22508046637.64.1784658027482; Tue, 21 Jul 2026 11:20:27 -0700 (PDT) X-Received: by 2002:a05:6a21:7008:b0:3c0:9c1b:d0b5 with SMTP id adf61e73a8af0-3c3ad9a4de9mr22508005637.64.1784658026958; Tue, 21 Jul 2026 11:20:26 -0700 (PDT) Received: from [192.168.1.8] ([106.222.235.145]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147e07000fsm2341770eec.21.2026.07.21.11.20.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 11:20:26 -0700 (PDT) Message-ID: <773715fd-823f-4564-ba42-c60bc8284b45@oss.qualcomm.com> Date: Tue, 21 Jul 2026 23:50:05 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v23 12/14] crypto: qce - Map crypto memory for DMA To: Bartosz Golaszewski , Vinod Koul , Jonathan Corbet , Thara Gopinath , Herbert Xu , "David S. Miller" , Udit Tiwari , Md Sadre Alam , Dmitry Baryshkov , Manivannan Sadhasivam , Stephan Gerhold , Bjorn Andersson , Peter Ujfalusi , Michal Simek , Frank Li , Andy Gross , Neil Armstrong , Vignesh Raghavendra Cc: dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, brgl@kernel.org, Bartosz Golaszewski References: <20260721-qcom-qce-cmd-descr-v23-0-1be02deffda9@oss.qualcomm.com> <20260721-qcom-qce-cmd-descr-v23-12-1be02deffda9@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260721-qcom-qce-cmd-descr-v23-12-1be02deffda9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: b5l3TldhmDr99dq1DEnjtC_ph_Fj6opk X-Authority-Analysis: v=2.4 cv=CbE4Irrl c=1 sm=1 tr=0 ts=6a5fb86c cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nYgDJefOb7ZtON2RxEtQrg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=KKAkSRfTAAAA:8 a=DV7x2YVLp9Y0dp68W6cA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: b5l3TldhmDr99dq1DEnjtC_ph_Fj6opk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDE5MiBTYWx0ZWRfX+aYYqfrsETja 1oThaHtBeTfa6iR/pd+wIMZb+dI4Obnt0tBlGZAH3ffsMSnHxWpTBy7/Jei17A2bKaeNlMulw6n 8BRT2uTf/txxkBRBYMApWbHZhV7mNLFn+YGxJmHtJx9zxXZt6/AR7T4weL8/o1S/vXMPk0p3Mq8 EXMrIqVpWNJ/KhYBl1nfvucqhqjd5ctILpj3ed6rlKO/YibVQ64DRGDcnBawZjOUeeatP7703+Z oEiiVEMnpiKXC1z7mUWxQ0Jv3Reqed9A1bsMEzUmq6Yfn8ods1THEjPx5kelI1W736guJOqq7xn zwkn5qI9R5HE1Wm5msncWW7TZy2PBJQ0lLvhXmthaPKDA8r385VCk9BdMqRBpsSYVP3rkY4yHDk GmarU6VSvgWpgxLQrEIPublSAo5B/x34rEDc76TGHdnwNGC0e6epezvSPfipoKgtYpydYx7vH6R 1uPVq/PA1N0eUb5L5Pg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDE5MiBTYWx0ZWRfX7vqGK8PQ6E6p 9y35BojMV6Ogk6iBv0rX7Wx0T4V9Id7p5J3FHBFGi21sckazbABIn/5nyFij+nF1GZeIkxb94LP ly7RtF/e1SndPc3B4UuVsx0BQTFSMK0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_03,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 suspectscore=0 clxscore=1015 spamscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210192 On 7/21/2026 7:03 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski [...] > static int qce_crypto_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct qce_device *qce; > + struct resource *res; > int ret; > > qce = devm_kzalloc(dev, sizeof(*qce), GFP_KERNEL); > @@ -204,7 +213,7 @@ static int qce_crypto_probe(struct platform_device *pdev) > qce->dev = dev; > platform_set_drvdata(pdev, qce); > > - qce->base = devm_platform_ioremap_resource(pdev, 0); > + qce->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); > if (IS_ERR(qce->base)) Would you like to add any debug/error log ? > return PTR_ERR(qce->base); > > @@ -254,6 +263,18 @@ static int qce_crypto_probe(struct platform_device *pdev) > qce->async_req_enqueue = qce_async_request_enqueue; > qce->async_req_done = qce_async_request_done; > > + qce->dma_size = resource_size(res); > + qce->base_dma = dma_map_resource(dev, res->start, qce->dma_size, > + DMA_BIDIRECTIONAL, 0); > + qce->base_phys = res->start; > + ret = dma_mapping_error(dev, qce->base_dma); > + if (ret) Would you like to add any debug/error log ? > + return ret; > + > + ret = devm_add_action_or_reset(qce->dev, qce_crypto_unmap_dma, qce); > + if (ret) same here > + return ret; > + > return devm_qce_register_algs(qce); > } > [...]