From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <olteanv@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
Arun Ramadoss <arun.ramadoss@microchip.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
"Russell King (Oracle)" <linux@armlinux.org.uk>,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v1 3/5] net: dsa: microchip: Refactor MDIO handling for side MDIO access
Date: Mon, 28 Oct 2024 13:08:47 +0100 [thread overview]
Message-ID: <7738e272-b0ee-4a8c-8501-7030798c4e9c@lunn.ch> (raw)
In-Reply-To: <20241026063538.2506143-4-o.rempel@pengutronix.de>
> static int ksz_mdio_register(struct ksz_device *dev)
> {
> + struct device_node *parent_bus_node;
> + struct mii_bus *parent_bus = NULL;
> struct dsa_switch *ds = dev->ds;
> struct device_node *mdio_np;
> struct mii_bus *bus;
> - int ret;
> + struct dsa_port *dp;
> + int ret, i;
>
> mdio_np = of_get_child_by_name(dev->dev->of_node, "mdio");
> if (!mdio_np)
> return 0;
>
> + parent_bus_node = of_parse_phandle(mdio_np, "mdio-parent-bus", 0);
> + if (parent_bus_node && !dev->info->phy_side_mdio_supported) {
> + dev_warn(dev->dev, "Side MDIO bus is not supported for this HW, ignoring 'mdio-parent-bus' property.\n");
I think dev_err() and return -EINVAL. It is an error in the DT.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-10-28 12:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 6:35 [PATCH net-next v1 0/5] Side MDIO Support for LAN937x Switches Oleksij Rempel
2024-10-26 6:35 ` [PATCH net-next v1 1/5] dt-bindings: net: dsa: ksz: add internal MDIO bus description Oleksij Rempel
2024-10-27 23:04 ` Rob Herring (Arm)
2024-10-28 12:09 ` Andrew Lunn
2024-10-26 6:35 ` [PATCH net-next v1 2/5] dt-bindings: net: dsa: ksz: add mdio-parent-bus property for internal MDIO Oleksij Rempel
2024-10-27 23:06 ` Rob Herring (Arm)
2024-10-28 12:09 ` Andrew Lunn
2024-10-26 6:35 ` [PATCH net-next v1 3/5] net: dsa: microchip: Refactor MDIO handling for side MDIO access Oleksij Rempel
2024-10-28 12:08 ` Andrew Lunn [this message]
2024-10-26 6:35 ` [PATCH net-next v1 4/5] net: dsa: microchip: cleanup error handling in ksz_mdio_register Oleksij Rempel
2024-10-28 12:09 ` Andrew Lunn
2024-10-26 6:35 ` [PATCH net-next v1 5/5] net: dsa: microchip: add support for side MDIO interface in LAN937x Oleksij Rempel
2024-10-28 12:15 ` Andrew Lunn
2024-10-28 13:43 ` Oleksij Rempel
2024-10-29 3:39 ` Arun.Ramadoss
2024-10-29 5:15 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7738e272-b0ee-4a8c-8501-7030798c4e9c@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=arun.ramadoss@microchip.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®