From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756145AbbJ1Uft (ORCPT ); Wed, 28 Oct 2015 16:35:49 -0400 Received: from mail-qg0-f53.google.com ([209.85.192.53]:34882 "EHLO mail-qg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbbJ1Ufq (ORCPT ); Wed, 28 Oct 2015 16:35:46 -0400 From: Paul Moore To: Saurabh Sengar Cc: eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] audit: removing unused variable Date: Wed, 28 Oct 2015 16:35:44 -0400 Message-ID: <7739343.KgmgksQykM@sifl> User-Agent: KMail/4.14.10 (Linux/4.2.3-gentoo; KDE/4.14.13; x86_64; ; ) In-Reply-To: <1446005434-4306-1-git-send-email-saurabh.truth@gmail.com> References: <1446005434-4306-1-git-send-email-saurabh.truth@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, October 28, 2015 09:40:34 AM Saurabh Sengar wrote: > variavle rc in not required as it is just used for unchanged for return, > and return is always 0 in the function. > > Signed-off-by: Saurabh Sengar > --- > kernel/audit.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Thanks, applied with some spelling corrections to the description. > diff --git a/kernel/audit.c b/kernel/audit.c > index 662c007..409482f 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -686,23 +686,22 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 > msg_type) > > static int audit_log_common_recv_msg(struct audit_buffer **ab, u16 > msg_type) { > - int rc = 0; > uid_t uid = from_kuid(&init_user_ns, current_uid()); > pid_t pid = task_tgid_nr(current); > > if (!audit_enabled && msg_type != AUDIT_USER_AVC) { > *ab = NULL; > - return rc; > + return 0; > } > > *ab = audit_log_start(NULL, GFP_KERNEL, msg_type); > if (unlikely(!*ab)) > - return rc; > + return 0; > audit_log_format(*ab, "pid=%d uid=%u", pid, uid); > audit_log_session_info(*ab); > audit_log_task_context(*ab); > > - return rc; > + return 0; > } > > int is_audit_feature_set(int i) -- paul moore www.paul-moore.com