mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Alexey Dobriyan <adobriyan@gmail.com>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Stefan Roesch <shr@devkernel.io>
Subject: Re: [PATCH] proc: fix smaps_rollup test after KSM changes
Date: Thu, 7 Sep 2023 13:15:51 +0200	[thread overview]
Message-ID: <77404164-a56d-8627-bdd0-42c82661fb3d@redhat.com> (raw)
In-Reply-To: <725e041f-e9df-4f3d-b267-d4cd2774a78d@p183>

On 07.09.23 13:10, Alexey Dobriyan wrote:

Can you clarify in the patch description that we are fixing up a selftest?

"selftests/proc: fixup proc-empty-vm test"

or similar?

> /proc/${pid}/smaps_rollup is not empty file even if process's address
> space is empty, update the test.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>   tools/testing/selftests/proc/proc-empty-vm.c |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- a/tools/testing/selftests/proc/proc-empty-vm.c
> +++ b/tools/testing/selftests/proc/proc-empty-vm.c
> @@ -267,6 +267,7 @@ static const char g_smaps_rollup[] =
>   "Private_Dirty:         0 kB\n"
>   "Referenced:            0 kB\n"
>   "Anonymous:             0 kB\n"
> +"KSM:                   0 kB\n"
>   "LazyFree:              0 kB\n"
>   "AnonHugePages:         0 kB\n"
>   "ShmemPmdMapped:        0 kB\n"
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb


      reply	other threads:[~2023-09-07 15:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 11:10 Alexey Dobriyan
2023-09-07 11:15 ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77404164-a56d-8627-bdd0-42c82661fb3d@redhat.com \
    --to=david@redhat.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shr@devkernel.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®