From: Paul Walmsley <pjw@kernel.org>
To: Han Gao <rabenda.cn@gmail.com>
Cc: Paul Walmsley <pjw@kernel.org>, Han Gao <gaohan@iscas.ac.cn>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Vivian Wang <wangruikang@iscas.ac.cn>
Subject: Re: [PATCH] riscv: unconditionally select ARCH_KEEP_MEMBLOCK
Date: Wed, 27 May 2026 19:01:19 -0600 (MDT) [thread overview]
Message-ID: <774098ca-165a-f739-6331-affb0c8af1e1@kernel.org> (raw)
In-Reply-To: <CAAT7Ki-WDPpfdvB6MHdJW9Uas_jKVGeNjaOPvvpsPkO2wG-9oQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]
On Mon, 25 May 2026, Han Gao wrote:
> On Fri, May 22, 2026 at 6:04 AM Paul Walmsley <pjw@kernel.org> wrote:
> >
> > On Wed, 20 May 2026, Han Gao wrote:
> >
> > > Select ARCH_KEEP_MEMBLOCK unconditionally. kexec requires memblock
> > > to be kept after boot to initialize the secondary kernel. Device
> > > Tree platforms also need this for kexec support.
> > >
> > > Signed-off-by: Han Gao <gaohan@iscas.ac.cn>
> >
> > Thanks for the patch. If this patch is just about kexec, shouldn't
> > ARCH_SELECTS_KEXEC just be changed to select ARCH_KEEP_MEMBLOCK?
> It's currently aligned with the arm64 architecture. If so, should we
> modify it accordingly?
If the motivation for adding it this way is to match arm64, then the patch
description would need to be updated accordingly; it doesn't say anything
about that. I'm not sure that's a sufficient rationale, on its own.
On the other hand, if the rationale for this change is that it fixes an
issue when kexec is used, then I guess I don't understand why we wouldn't
make it dependent on ARCH_SELECTS_KEXEC? It can always be patched again
if more use cases are discovered, right?
- Paul
prev parent reply other threads:[~2026-05-28 1:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 16:55 Han Gao
2026-05-21 22:04 ` Paul Walmsley
2026-05-25 13:20 ` Han Gao
2026-05-28 1:01 ` Paul Walmsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=774098ca-165a-f739-6331-affb0c8af1e1@kernel.org \
--to=pjw@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=gaohan@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=rabenda.cn@gmail.com \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®