From: Hans Verkuil <hverkuil+cisco@kernel.org>
To: Runyu Xiao <runyu.xiao@seu.edu.cn>, ehristev@kernel.org
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
jianhao.xu@seu.edu.cn
Subject: Re: [PATCH] media: microchip: isc: Initialize DMA lock before requesting IRQ
Date: Thu, 10 Sep 2026 13:54:22 +0200 [thread overview]
Message-ID: <77440bae-7381-451f-861d-1399bac4d925@kernel.org> (raw)
In-Reply-To: <20260830023228.2054498-1-runyu.xiao@seu.edu.cn>
On 30/08/2026 04:32, Runyu Xiao wrote:
> The ISC interrupt can run before asynchronous subdevice completion, but the DMA queue lock was initialized from isc_async_complete(). Initialize it in each SoC probe before requesting the auto-enabled IRQ and remove the late initialization from the asynchronous completion path.
Line is much too long.
>
> Fixes: 91b4e487b0c6 ("media: microchip: add ISC driver as Microchip ISC")
>
Spurious empty lines.
> Cc: stable@vger.kernel.org
>
> Assisted-by: Codex:GPT-5
> Signed-off-by: Runyu Xiao <runyu.xiao@seu.edu.cn>
> ---
> drivers/media/platform/microchip/microchip-isc-base.c | 1 -
> drivers/media/platform/microchip/microchip-sama5d2-isc.c | 2 ++
> drivers/media/platform/microchip/microchip-sama7g5-isc.c | 2 ++
> 3 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/microchip/microchip-isc-base.c b/drivers/media/platform/microchip/microchip-isc-base.c
> index a7cdc743f..a2534d8eb 100644
> --- a/drivers/media/platform/microchip/microchip-isc-base.c
> +++ b/drivers/media/platform/microchip/microchip-isc-base.c
> @@ -1792,7 +1792,6 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier)
>
> /* Init video dma queues */
> INIT_LIST_HEAD(&isc->dma_queue);
> - spin_lock_init(&isc->dma_queue_lock);
> spin_lock_init(&isc->awb_lock);
>
> ret = isc_set_default_fmt(isc);
> diff --git a/drivers/media/platform/microchip/microchip-sama5d2-isc.c b/drivers/media/platform/microchip/microchip-sama5d2-isc.c
> index 66d3d7891..f0f7ca47f 100644
> --- a/drivers/media/platform/microchip/microchip-sama5d2-isc.c
> +++ b/drivers/media/platform/microchip/microchip-sama5d2-isc.c
> @@ -432,6 +432,8 @@ static int microchip_isc_probe(struct platform_device *pdev)
> if (irq < 0)
> return irq;
>
> + spin_lock_init(&isc->dma_queue_lock);
It's dubious to just init dma_queue_lock here but not INIT_LIST_HEAD(&isc->dma_queue);
I think Eugen needs to look at this as well to see if this is actually a valid
issue at all.
In any case, this patch doesn't look right to me.
Regards,
Hans
> +
> ret = devm_request_irq(dev, irq, microchip_isc_interrupt, 0,
> "microchip-sama5d2-isc", isc);
> if (ret < 0) {
> diff --git a/drivers/media/platform/microchip/microchip-sama7g5-isc.c b/drivers/media/platform/microchip/microchip-sama7g5-isc.c
> index 7383341ec..b1aa3fe55 100644
> --- a/drivers/media/platform/microchip/microchip-sama7g5-isc.c
> +++ b/drivers/media/platform/microchip/microchip-sama7g5-isc.c
> @@ -421,6 +421,8 @@ static int microchip_xisc_probe(struct platform_device *pdev)
> if (irq < 0)
> return irq;
>
> + spin_lock_init(&isc->dma_queue_lock);
> +
> ret = devm_request_irq(dev, irq, microchip_isc_interrupt, 0,
> "microchip-sama7g5-xisc", isc);
> if (ret < 0) {
prev parent reply other threads:[~2026-09-10 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 2:32 Runyu Xiao
2026-09-10 11:54 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77440bae-7381-451f-861d-1399bac4d925@kernel.org \
--to=hverkuil+cisco@kernel.org \
--cc=ehristev@kernel.org \
--cc=jianhao.xu@seu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=runyu.xiao@seu.edu.cn \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®