From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BB69C433DF for ; Wed, 27 May 2020 01:15:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1AE03206F1 for ; Wed, 27 May 2020 01:15:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a6HfxCcA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728253AbgE0BPk (ORCPT ); Tue, 26 May 2020 21:15:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727937AbgE0BPj (ORCPT ); Tue, 26 May 2020 21:15:39 -0400 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD60DC061A0F; Tue, 26 May 2020 18:15:39 -0700 (PDT) Received: by mail-qv1-xf42.google.com with SMTP id fb16so10475080qvb.5; Tue, 26 May 2020 18:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FTgIoFmJ7jfvCnsMHaD2LwHD2SvL+8p8rVd1cLx0pZk=; b=a6HfxCcAy2VRykaLYxvM4uw3+o0TAWsiCmJGmNev0x20n4iEYgRdW24Tcy/4Hftcjf RcQp1mENUMF4C0fzYbmbqtknxC1cF5tXbG3S5/WBasPozxrC6FYWjQ23yylLTaVLehb9 NV167rh7foAVhdaT6eE2qiIi/SaQnDoAr5WSxdL7niqBlaEe3ATynnW8ctd+M5ByDPox aj4i/ng8QhHv6MQ5faR0F57vqYi4rS1YZrZuPft5KbwdKHEAmA9EImIhX+MVyrg5ZtYs +F0nyNeHhYkGiY99qD4XQ7B7bdXCGxFAzcvFG5H/vjyNUBT15ujgVTmRgTRjzKVGA1TS tKGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FTgIoFmJ7jfvCnsMHaD2LwHD2SvL+8p8rVd1cLx0pZk=; b=Q+7BOawyBDeI6sfb9a5Vd/jIY8KxvH/wd0lxSe2zq/X78p3PDUwpQhcxKhWOx//AXj oVESGDRKBmkrvg6fFSr+Aw2zO3YNsvs8VYtvhJ6QBZioLPBoXdJ9AKY+FF1w9Z/sIhWz Ft1VgB2ur7tgaKqiZ0NQDYlcCn9ReOdppWi82MaaXZJPazSchINtncrncvSa0ckLjjNR S9LsSUVRcTuqA4bD44rpPBJ2wB7Rz+eVJMLD0pUvnqvzc0wKDP1sYVPhW803Rl7hWh5x Xrb6Ai5UJGdMuuzj1DqUMXyijOYkKpj4VokjuKdKm8iTevPTXW9a15QPZAmk7baXxZzT /oMg== X-Gm-Message-State: AOAM530DF86cJ+fZTtNYDpw4qrWFywLcmZqhB/ZfUAw+6NvqpGuXY4Pp WoY6YOzAu0HFurThPO5ww+Y8WaPE X-Google-Smtp-Source: ABdhPJzhHYEnsFjAcxTahAY8N/o0kUYmHWW2UkM8khFdgcPuVK8kItL3mDaXBSrBe69uoVRE4aPqbA== X-Received: by 2002:a05:6214:311:: with SMTP id i17mr22067329qvu.59.1590542138847; Tue, 26 May 2020 18:15:38 -0700 (PDT) Received: from ?IPv6:2601:282:803:7700:85b5:c99:767e:c12? ([2601:282:803:7700:85b5:c99:767e:c12]) by smtp.googlemail.com with ESMTPSA id m7sm1149167qti.6.2020.05.26.18.15.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2020 18:15:38 -0700 (PDT) Subject: Re: [PATCH] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev To: Colin King , Jiri Pirko , Ido Schimmel , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200526225649.64257-1-colin.king@canonical.com> From: David Ahern Message-ID: <77496adf-bddf-7911-dacb-f383b5ca6d17@gmail.com> Date: Tue, 26 May 2020 19:15:36 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200526225649.64257-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/26/20 4:56 PM, Colin King wrote: > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > index 71aee4914619..8f485f9a07a7 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > @@ -7572,11 +7572,12 @@ static struct mlxsw_sp_fid * > mlxsw_sp_rif_vlan_fid_get(struct mlxsw_sp_rif *rif, > struct netlink_ext_ack *extack) > { > - struct net_device *br_dev = rif->dev; > + struct net_device *br_dev; > u16 vid; > int err; > > if (is_vlan_dev(rif->dev)) { > + stray newline added > vid = vlan_dev_vlan_id(rif->dev); > br_dev = vlan_dev_real_dev(rif->dev); > if (WARN_ON(!netif_is_bridge_master(br_dev))) >