From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754344AbdLNXYZ (ORCPT ); Thu, 14 Dec 2017 18:24:25 -0500 Received: from mail-ot0-f196.google.com ([74.125.82.196]:34399 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754147AbdLNXYV (ORCPT ); Thu, 14 Dec 2017 18:24:21 -0500 X-Google-Smtp-Source: ACJfBovYXBm091LmHmrVVEGmR9gOmYCKu8mHL0Kmvnc3fmpIMioQXthxt9f9AQfjs2nU6M25vOLVVA== Subject: Re: [PATCH net-next v6 1/2] dt-bindings: net: add DT bindings for Socionext UniPhier AVE To: Kunihiko Hayashi , David Miller , netdev@vger.kernel.org Cc: Andrew Lunn , Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Masahiro Yamada , Masami Hiramatsu , Jassi Brar References: <1513245910-15961-1-git-send-email-hayashi.kunihiko@socionext.com> <1513245910-15961-2-git-send-email-hayashi.kunihiko@socionext.com> From: Florian Fainelli Message-ID: <7749e13a-56ef-0d43-1a41-dbd457227575@gmail.com> Date: Thu, 14 Dec 2017 15:24:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1513245910-15961-2-git-send-email-hayashi.kunihiko@socionext.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/14/2017 02:05 AM, Kunihiko Hayashi wrote: > DT bindings for the AVE ethernet controller found on Socionext's > UniPhier platforms. > > Signed-off-by: Kunihiko Hayashi > Signed-off-by: Jassi Brar > Acked-by: Rob Herring > --- > .../bindings/net/socionext,uniphier-ave4.txt | 48 ++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt > > diff --git a/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt > new file mode 100644 > index 0000000..4700377 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt > @@ -0,0 +1,48 @@ > +* Socionext AVE ethernet controller > + > +This describes the devicetree bindings for AVE ethernet controller > +implemented on Socionext UniPhier SoCs. > + > +Required properties: > + - compatible: Should be > + - "socionext,uniphier-pro4-ave4" : for Pro4 SoC > + - "socionext,uniphier-pxs2-ave4" : for PXs2 SoC > + - "socionext,uniphier-ld11-ave4" : for LD11 SoC > + - "socionext,uniphier-ld20-ave4" : for LD20 SoC > + - reg: Address where registers are mapped and size of region. > + - interrupts: Should contain the MAC interrupt. > + - phy-mode: See ethernet.txt in the same directory. Allow to choose > + "rgmii", "rmii", or "mii" according to the PHY. > + - phy-handle: Should point to the external phy device. > + See ethernet.txt file in the same directory. > + - clocks: A phandle to the clock for the MAC. > + > +Optional properties: > + - resets: A phandle to the reset control for the MAC > + - local-mac-address: See ethernet.txt in the same directory. > + > +Required subnode: > + - mdio: Device tree subnode with the following required properties: > + - #address-cells: Must be <1>. > + - #size-cells: Must be <0>. > + - reg: phy ID number, usually a small integer. Almost, the "reg" property applies to the MDIO child nodes: the Ethernet PHYs/MDIO devices. For the MDIO controller itself, the "reg" property, if specified, would be relative to the Ethernet controller's base register address. Please drop this property's description here. > + > +Example: > + > + ether: ethernet@65000000 { > + compatible = "socionext,uniphier-ld20-ave4"; > + reg = <0x65000000 0x8500>; > + interrupts = <0 66 4>; > + phy-mode = "rgmii"; > + phy-handle = <ðphy>; > + clocks = <&sys_clk 6>; > + resets = <&sys_rst 6>; > + local-mac-address = [00 00 00 00 00 00]; > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + ethphy: ethphy@1 { > + reg = <1>; > + }; > + }; > + }; > -- Florian