From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C189346E64 for ; Wed, 2 Sep 2026 05:31:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788327063; cv=none; b=rimHPLSA5Zc0nQJjOLWz6u88oS4W+Plv6TqXZhBXliQTJST7AMB3XNuwHnw7yqA0rTwnBD8B1YBhEv7he0RL63p4fZQcbOsIPqYkFm4OxDbtJ7WNIa8VtL6RDV0DEgxn9QIbDlkj2juckG4tncLdbW7aKrP3cG2bLG432uja8tw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788327063; c=relaxed/simple; bh=EErxRj9UamHxjL4qovNFexC2eoDhDkme3XwtJu95u6Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hON7f7vU5yX04Ob+XyJgGgZQPBYm0fhXQE2qvZXlNUKg+r0vJ/2wgrjhdGRPbajXqZ6pHEU3ZbRsj/LyNFoFhmSOqGjV4XykodRrwjJGzqOZG1yphUDfEYMjIU5Iec1XuoMe4xpzl/iH+IVd/jD/luTeZeBrfGA5CiiPvq3qrrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=c2jPeDiT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cVUiNyW/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="c2jPeDiT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cVUiNyW/" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68202JW11013407 for ; Wed, 2 Sep 2026 05:31:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EErxRj9UamHxjL4qovNFexC2eoDhDkme3XwtJu95u6Y=; b=c2jPeDiTCeOUZ+Ms LDfvknHx3w8HS4tzLQFo8FeefuE26hYIfDzmCR63ke5HsTrJhVNRJ4izfpXB0ssw webIHA/6bABWsLA1p/ztDuFgHvg1mkJXMCDTkhmkQP3IGyj7VCPugPCCD+1Oq7Oe GKwl73PE7usS1R0M0BFMgfEmqQwzWrKy2dI0rZbPKedLcZDptd4JdDT+Ap5zr7or Xcj9TYijr4hxx1KlLlOSR1iT/240UHSABpzX0lHN4vfOpdyXfvXJSNYZVlnVAgcA OQaL+qvn/miYq+lTGRaGVsYnHHepG14/UNsfuRW4Uht9HuVYjLcLQQFZ8OMwvjOS GVLutA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ge8whgx2r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 02 Sep 2026 05:31:00 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38dbf293831so1628021a91.3 for ; Tue, 01 Sep 2026 22:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788327059; x=1788931859; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EErxRj9UamHxjL4qovNFexC2eoDhDkme3XwtJu95u6Y=; b=cVUiNyW/ohBB+s7jOsi+qnKDuhoqnsuIqqXC6JiO1+cXdWMuegmxe0TrzVCLnvvhc0 3tHsxF4IX2c+KjMxnRRUHzHYaUJN252/ubYX0D+7eC8di2GkQc7yjvZu2xPfRFfvGYGy cAFCwd/3XKPHmaWs3X9R98gBKLQBjOu6HkNYGRVwlBULfteYKCGl9p0H3hpq0mvzXzhp i4C2OOjgMk1UYrSeWqa9eCsItFpd3MyP2Zi8WXc+0E2AqcbhKrZogBZiQo4130PR1HRL Dg6gIBTlZ5H8NiVDdww1aWJlRE5D23RVK5VZkkF10at0T93liQCBoDhjDuDdlYLtjG7N qCBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788327059; x=1788931859; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EErxRj9UamHxjL4qovNFexC2eoDhDkme3XwtJu95u6Y=; b=RrenXGJEwdWIBUDQdhL5MAGqMVxqhPRzfKnUmUxTARTo0TFPeUIMAx7mbXdFqW3eMw 5iuBXqC+xqhBKwzbSemw4JOoutLrGX5g2tYP2FkRPjYFchHMeuQterXpnewZaGPUrEF2 bZ1pdVrqbcT631+rP54BsvnI/LCzmdolEX631uutmSuYrcMTFzUtKi54ZEdISvWk8+Rk YrfpQU/vH6HYJAns5WC/rPjTnXTVpFM2LiaoLWZWoYz1WbVfIjYXToriQ3oKi/Dmh8o2 VNvqUS3SN/ykBrplqDKICycmwvpuau2nXaFGh6KuY+8gBsVOs9A19omJIREOQ6YgZSml HlZw== X-Forwarded-Encrypted: i=1; AKwUvBxmyUuCcIcCYKTjZ2csGtb33xEKzHG482HXXfX9wbRSa3fYcFUhRLeAHnL8SNC7hwisGrO7iK1HlCDkFpE=@vger.kernel.org X-Gm-Message-State: AFuF++mk/yZMGn/xvUbDEo1ZMmaHttJNjRdErTyc6XZBT7xU/F4CM4vg Lj3r1KG7fvLfy+Re4aWhRSfja6Nq3b6i8PfHq6tGZqBM+tY7fNCFpmQu1Q5aKMUQktvbMBfDcGg XGrljUuIJN0NjdYyO0M1opKGDNxtry/+1Jwg3ws4DpTktbD2e1wq7xK0CJRji1JMUf9s= X-Gm-Gg: AYBFou1DICm3Ob+T+dr7B5I9I32vxxfIWIGQu6IjUmvuH+FsqkP04M2qEWaHeOAw7Eq W/4yClmzXJtko5Md/TPSaXJxnBbGLITp19mzTOspt6UCtWOuxB9F0tycbxcZSSNxePSpzDXU8+P Om2Dy4US/P9oGFvtb/oIrjE2adtICFTCoYgX2NqoORPM8byS0z3nsWwj7DcRNakMY84GrD2TG+8 2tZJ4ETJNY51X803nJtNxrL+8qbCCjtFtMmWVxC3zDRSxMZmzc7FsVJwYKbyHMGM2ARz+PODRi3 zx2ysNpe9dMEloWz3cmXHF+FM6yiKXgpmeR7ckyMjxEogjnV8Z3pQ/xV38b5WClrX/0AAgHFikp 0rf0/vUnbtgjeOBWRbUgIeQqSijLrb0RJ X-Received: by 2002:a17:90b:1c07:b0:398:d8eb:cb2a with SMTP id 98e67ed59e1d1-39aee260bc0mr2726736a91.23.1788327059347; Tue, 01 Sep 2026 22:30:59 -0700 (PDT) X-Received: by 2002:a17:90b:1c07:b0:398:d8eb:cb2a with SMTP id 98e67ed59e1d1-39aee260bc0mr2726667a91.23.1788327058905; Tue, 01 Sep 2026 22:30:58 -0700 (PDT) Received: from [10.218.35.45] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1430e8c6fcbsm5163942c88.0.2026.09.01.22.30.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 22:30:58 -0700 (PDT) Message-ID: <774adaa9-55de-4456-9ee2-eb3c5d7ea0a5@oss.qualcomm.com> Date: Wed, 2 Sep 2026 11:00:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/6] wifi: ath11k: Add support for MHI bandwidth scaling To: Neil Armstrong , Bjorn Helgaas , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Jingoo Han , Lorenzo Pieralisi , Rob Herring , Jeff Johnson , Bartosz Golaszewski , Manivannan Sadhasivam , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mhi@lists.linux.dev, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, qiang.yu@oss.qualcomm.com, Miaoqing Pan References: <20260819-bwscale-v5-0-6dea79786b37@oss.qualcomm.com> <20260819-bwscale-v5-5-6dea79786b37@oss.qualcomm.com> <5b10cb13-77e6-4754-a885-92c873866ef4@linaro.org> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: <5b10cb13-77e6-4754-a885-92c873866ef4@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=fLkJG5ae c=1 sm=1 tr=0 ts=6a97b494 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=WikkZxfSKXF9q-dYMVUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: CkRowNNxnRLvhrhyb_SaMYf8Um-KfMap X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAyMDA0NiBTYWx0ZWRfX6FjEgGWxkM+o KhtVwoyS8oSF7UazOjsMUyVd8sp6tp6TYGD4x5h7ul/gAehe7UdQTsP2iziVZhXul8Antav2fgx sVdPAuMhfWlaxM1+n+l/AuuyqW4PYQyOUQkuMLN1jVxyDI7XDt4BEo7p2nL/N1WWQiwMjJZESbz p54OFr87KQn3UjtPsK0YzZ1lZ9n+zVsJtQ3vrdt5AbQNetx7A8Qcu0HDCr6WqvBnCheTnei65lt 6urRIaVewlwfjT8MWjwmNotMpT7zUqDqJeM03/n8FTXOOkVoqgRLKppTqbNLTM+ffm7OCD7Zu1f jZ8aQ47K6BaqoxFORMij48xQ3J45Xer5XnVYCZkvPb9h1A5/LHlnUuJnsjxUvBSA5COQDRnG7EX HxR2+ZJ8GLUgfKakfwdIuHVdL4x3Tq9lPQ7jtNryDtCp6FP/VnxIzph9eb1n0EeD62WM+LLOjEQ 2OsPfG48Csuhay7rfrQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAyMDA0NiBTYWx0ZWRfX0OLhO/lGHrs7 l44uR3Dey+Qybv+xBh1XzvjNEJ7UascITWqx4O55CtnF0eE09eNL2c1Y++aBRA+hw+AjNZHEE+V Qz2ZYQkARgjOPwCTNBBvlMqucvkpmes= X-Proofpoint-GUID: CkRowNNxnRLvhrhyb_SaMYf8Um-KfMap X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-01_06,2026-09-01_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 impostorscore=0 clxscore=1015 priorityscore=1501 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609020046 On 9/1/2026 8:15 PM, Neil Armstrong wrote: > Hi, > > On 8/19/26 15:25, Krishna Chaitanya Chundru wrote: >> From: Miaoqing Pan >> >> Add support for MHI bandwidth scaling, which will reduce power consumption >> if WLAN operates with lower bandwidth. This feature is only enabled for >> QCA6390. >> >> Bandwidth scaling is initiated by the endpoint firmware based upon the >> bandwidth requirements, if there is high bandwidth data endpoint requests >> for higher data rates or if there is less bandwidth they request for lower >> data rates to reduce power. Endpoint initiates this through MHI protocol. >> >> Tested-on: WCN6855 hw2.1 PCI >> WLAN.HSP.1.1-04546-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1 > > Somehow unrelated, but I added this to the ath12k to test on an WCN785x and > I just > got a single event to set the speed to 5GT/s and no further event whatever > the state > of the Wireless link is. > > Is there anything required on the ath12k side to allow lowering the speed to > 2.5GT/s ?  some wifi device has some limitation due to that they will stay in gen2 only. - Krishna Chaitanya. > > Thanks, > Neil > >> >> Signed-off-by: Miaoqing Pan >> Signed-off-by: Krishna Chaitanya Chundru >> --- >>   drivers/net/wireless/ath/ath11k/mhi.c | 38 >> +++++++++++++++++++++++++++++++++++ >>   1 file changed, 38 insertions(+) >> >> diff --git a/drivers/net/wireless/ath/ath11k/mhi.c >> b/drivers/net/wireless/ath/ath11k/mhi.c >> index a6c9ff112c68..9bff4c4bca3b 100644 >> --- a/drivers/net/wireless/ath/ath11k/mhi.c >> +++ b/drivers/net/wireless/ath/ath11k/mhi.c >> @@ -20,6 +20,7 @@ >>   #define MHI_TIMEOUT_DEFAULT_MS    20000 >>   #define RDDM_DUMP_SIZE    0x420000 >>   #define MHI_CB_INVALID    0xff >> +#define MHI_BW_SCALE_CHAN_DB 126 >>     static const struct mhi_channel_config ath11k_mhi_channels_qca6390[] = { >>       { >> @@ -71,6 +72,17 @@ static struct mhi_event_config >> ath11k_mhi_events_qca6390[] = { >>           .client_managed = false, >>           .offload_channel = false, >>       }, >> +    { >> +        .num_elements = 8, >> +        .irq_moderation_ms = 0, >> +        .irq = 1, >> +        .mode = MHI_DB_BRST_DISABLE, >> +        .data_type = MHI_ER_BW_SCALE, >> +        .priority = 2, >> +        .hardware_event = false, >> +        .client_managed = false, >> +        .offload_channel = false, >> +    }, >>   }; >>     static const struct mhi_controller_config ath11k_mhi_config_qca6390 = { >> @@ -311,6 +323,30 @@ static void ath11k_mhi_op_write_reg(struct >> mhi_controller *mhi_cntrl, >>       writel(val, addr); >>   } >>   +static int ath11k_mhi_op_get_misc_doorbell(struct mhi_controller >> *mhi_cntrl, >> +                       enum mhi_er_data_type type) >> +{ >> +    if (type == MHI_ER_BW_SCALE) >> +        return MHI_BW_SCALE_CHAN_DB; >> + >> +    return -EOPNOTSUPP; >> +} >> + >> +static int ath11k_mhi_op_bw_scale(struct mhi_controller *mhi_cntrl, >> +                  struct mhi_link_info *link_info) >> +{ >> +    enum pci_bus_speed speed = >> pci_lnkctl2_bus_speed(link_info->target_link_speed); >> +    struct ath11k_base *ab = dev_get_drvdata(mhi_cntrl->cntrl_dev); >> +    struct pci_dev *pci_dev = to_pci_dev(ab->dev); >> +    struct pci_dev *pdev; >> + >> +    pdev = pci_upstream_bridge(pci_dev); >> +    if (!pdev) >> +        return -ENODEV; >> + >> +    return pcie_set_target_speed(pdev, speed, true); >> +} >> + >>   static int ath11k_mhi_read_addr_from_dt(struct mhi_controller *mhi_ctrl) >>   { >>       struct device_node *np; >> @@ -387,6 +423,8 @@ int ath11k_mhi_register(struct ath11k_pci *ab_pci) >>       mhi_ctrl->status_cb = ath11k_mhi_op_status_cb; >>       mhi_ctrl->read_reg = ath11k_mhi_op_read_reg; >>       mhi_ctrl->write_reg = ath11k_mhi_op_write_reg; >> +    mhi_ctrl->bw_scale = ath11k_mhi_op_bw_scale; >> +    mhi_ctrl->get_misc_doorbell = ath11k_mhi_op_get_misc_doorbell; >>         switch (ab->hw_rev) { >>       case ATH11K_HW_QCN9074_HW10: >> >