From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F381C433FF for ; Sat, 3 Aug 2019 17:52:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 421A22087C for ; Sat, 3 Aug 2019 17:52:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728409AbfHCRwJ (ORCPT ); Sat, 3 Aug 2019 13:52:09 -0400 Received: from smtprelay0191.hostedemail.com ([216.40.44.191]:42232 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728389AbfHCRwI (ORCPT ); Sat, 3 Aug 2019 13:52:08 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id F006E837F24D; Sat, 3 Aug 2019 17:52:06 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: snake40_699c1332f931f X-Filterd-Recvd-Size: 2725 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Sat, 3 Aug 2019 17:52:05 +0000 (UTC) Message-ID: <774ade692f5e64ab1f4fc7b35b9eeae69e11cf71.camel@perches.com> Subject: Re: [PATCH] staging: rtl8192e: Make use kmemdup From: Joe Perches To: Hariprasad Kelam , Greg Kroah-Hartman , Himadri Pandya , Larry Finger , Michiel Schuurmans , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sat, 03 Aug 2019 10:52:04 -0700 In-Reply-To: <20190803174038.GA10454@hari-Inspiron-1545> References: <20190803174038.GA10454@hari-Inspiron-1545> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2019-08-03 at 23:10 +0530, Hariprasad Kelam wrote: > As kmemdup API does kmalloc + memcpy . We can make use of it instead of > calling kmalloc and memcpy independetly. [] > diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c [] > @@ -1382,10 +1382,8 @@ rtllib_association_req(struct rtllib_network *beacon, > ieee->assocreq_ies = NULL; > ies = &(hdr->info_element[0].id); > ieee->assocreq_ies_len = (skb->data + skb->len) - ies; > - ieee->assocreq_ies = kmalloc(ieee->assocreq_ies_len, GFP_ATOMIC); > - if (ieee->assocreq_ies) > - memcpy(ieee->assocreq_ies, ies, ieee->assocreq_ies_len); > - else { > + ieee->assocreq_ies = kmemdup(ies, ieee->assocreq_ies_len, GFP_ATOMIC); > + if (!ieee->assocreq_ies) { > netdev_info(ieee->dev, > "%s()Warning: can't alloc memory for assocreq_ies\n", > __func__); > @@ -2259,12 +2257,10 @@ rtllib_rx_assoc_resp(struct rtllib_device *ieee, struct sk_buff *skb, > ieee->assocresp_ies = NULL; > ies = &(assoc_resp->info_element[0].id); > ieee->assocresp_ies_len = (skb->data + skb->len) - ies; > - ieee->assocresp_ies = kmalloc(ieee->assocresp_ies_len, > + ieee->assocresp_ies = kmemdup(ies, > + ieee->assocresp_ies_len, > GFP_ATOMIC); > - if (ieee->assocresp_ies) > - memcpy(ieee->assocresp_ies, ies, > - ieee->assocresp_ies_len); > - else { > + if (!ieee->assocresp_ies) { > netdev_info(ieee->dev, > "%s()Warning: can't alloc memory for assocresp_ies\n", > __func__); Could also remove the netdev_info() uses for allocation failures. These are redundant as a dump_stack() is already done when OOM.