From: liangjs <liangjs@pku.edu.cn>
To: Dave Hansen <dave.hansen@intel.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: arch_set_user_pkey_access only works on the current task_struct
Date: Tue, 08 Jun 2021 11:16:53 +0800 [thread overview]
Message-ID: <774b6e6c8cb1be4923048bb1bb18753a6854758f.camel@pku.edu.cn> (raw)
In-Reply-To: <a9d538c4-b4aa-9a5b-5f8e-1a7baf8424b8@intel.com>
On Mon, 2021-06-07 at 10:52 -0700, Dave Hansen wrote:
> On 6/5/21 6:10 AM, Jiashuo Liang wrote:
> > I am learning the kernel implementation of the x86 PKU feature. I find the
> > arch_set_user_pkey_access function in arch/x86/kernel/fpu/xstate.c does not
> > use its first parameter. So it is perhaps a bug?
>
> I wouldn't really call it a bug. But, yes, it is something we should
> clean up.
Should we remove the tsk parameter, or allow it to change the PKRU of tsk?
By the way, we are calling write_pkru, which changes both the CPU's PKRU
and the xsave one. Why is this necessary?
If I want to change PKRU of a task_struct other than current, do I still
need to call __write_pkru?
Thank you!
liangjs
next prev parent reply other threads:[~2021-06-08 3:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 13:10 Jiashuo Liang
2021-06-07 17:52 ` Dave Hansen
2021-06-08 3:16 ` liangjs [this message]
2021-06-08 14:55 ` Dave Hansen
2021-06-08 19:05 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=774b6e6c8cb1be4923048bb1bb18753a6854758f.camel@pku.edu.cn \
--to=liangjs@pku.edu.cn \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®