From: Casey Schaufler <casey@schaufler-ca.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: linux-security-module@vger.kernel.org,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH] security/smack/smackfs: small kernel-doc fixes
Date: Fri, 2 May 2025 08:50:35 -0700 [thread overview]
Message-ID: <774bce75-551e-486d-9e35-16da3cb962bb@schaufler-ca.com> (raw)
In-Reply-To: <20250502014421.682697-1-rdunlap@infradead.org>
On 5/1/2025 6:44 PM, Randy Dunlap wrote:
> Add function short descriptions to the kernel-doc where missing.
> Correct a verb and add ending periods to sentences.
>
> smackfs.c:1080: warning: missing initial short description on line:
> * smk_net4addr_insert
> smackfs.c:1343: warning: missing initial short description on line:
> * smk_net6addr_insert
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
I'll take this. Thank you.
> Cc: Casey Schaufler <casey@schaufler-ca.com>
> Cc: linux-security-module@vger.kernel.org
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: James Morris <jmorris@namei.org>
> Cc: "Serge E. Hallyn" <serge@hallyn.com>
> ---
> security/smack/smackfs.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> --- linux-next-20250501.orig/security/smack/smackfs.c
> +++ linux-next-20250501/security/smack/smackfs.c
> @@ -1077,13 +1077,12 @@ static int smk_open_net4addr(struct inod
> }
>
> /**
> - * smk_net4addr_insert
> + * smk_net4addr_insert - insert a new entry into the net4addrs list
> * @new : netlabel to insert
> *
> - * This helper insert netlabel in the smack_net4addrs list
> + * This helper inserts netlabel in the smack_net4addrs list
> * sorted by netmask length (longest to smallest)
> - * locked by &smk_net4addr_lock in smk_write_net4addr
> - *
> + * locked by &smk_net4addr_lock in smk_write_net4addr.
> */
> static void smk_net4addr_insert(struct smk_net4addr *new)
> {
> @@ -1340,13 +1339,12 @@ static int smk_open_net6addr(struct inod
> }
>
> /**
> - * smk_net6addr_insert
> + * smk_net6addr_insert - insert a new entry into the net6addrs list
> * @new : entry to insert
> *
> * This inserts an entry in the smack_net6addrs list
> * sorted by netmask length (longest to smallest)
> - * locked by &smk_net6addr_lock in smk_write_net6addr
> - *
> + * locked by &smk_net6addr_lock in smk_write_net6addr.
> */
> static void smk_net6addr_insert(struct smk_net6addr *new)
> {
>
prev parent reply other threads:[~2025-05-02 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 1:44 Randy Dunlap
2025-05-02 15:50 ` Casey Schaufler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=774bce75-551e-486d-9e35-16da3cb962bb@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=rdunlap@infradead.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®