From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AAFDC433EF for ; Thu, 2 Jun 2022 10:20:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233617AbiFBKTv (ORCPT ); Thu, 2 Jun 2022 06:19:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233560AbiFBKTq (ORCPT ); Thu, 2 Jun 2022 06:19:46 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B281297507; Thu, 2 Jun 2022 03:19:42 -0700 (PDT) X-UUID: 5db9316213ec43079f2a6173fc3a6f87-20220602 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:7b8b3fdd-bee6-4eb9-a4da-e650fd67b133,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:985daf6e-b02c-4af4-b838-5c14aaa063c7,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:0,BEC:nil X-UUID: 5db9316213ec43079f2a6173fc3a6f87-20220602 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1998949085; Thu, 02 Jun 2022 18:19:37 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Thu, 2 Jun 2022 18:19:36 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Thu, 2 Jun 2022 18:19:36 +0800 Message-ID: <774c075ca4ad815c88be755cfb51889a171e835d.camel@mediatek.com> Subject: Re: [PATCH v1] dt-bindings: dsp: mediatek: add mt8186 dsp document From: Tinghan Shen To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , "Matthias Brugger" CC: , , , , Date: Thu, 2 Jun 2022 18:19:36 +0800 In-Reply-To: <591767ee-e349-7a17-a9e9-b95d0500c7c1@linaro.org> References: <20220422071534.15653-1-tinghan.shen@mediatek.com> <591767ee-e349-7a17-a9e9-b95d0500c7c1@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Thu, 2022-06-02 at 09:40 +0200, Krzysztof Kozlowski wrote: > On 02/06/2022 08:44, Tinghan Shen wrote: > > > > + mbox-names: > > > > + items: > > > > + - const: mbox0 > > > > + - const: mbox1 > > > > > > These should be rather some meaningful names, e.g. "rx" and "tx". > > > > The mbox name has to align with the adsp ipc driver. > > The adsp ipc driver is using 'mbox%d' for mailbox channels. > > > > > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=9db69df4bdd37eb1f65b6931ee067fb15b9a4d5c__;!!CTRNKA9wMg0ARbw!1TmempNkQhC5QuLBhyfWo_AC97MoLuWipsGV-LPaW9RKNPheU7Bgc-eboNi1JA1nC5I$ > > > > > > chan_name = kasprintf(GFP_KERNEL, "mbox%d", i); > > > > /* ...snip... */ > > > > adsp_chan->ch = mbox_request_channel_byname(cl, chan_name); > > > > Is it ok to continue using these names? > > It is a bit confusing... how did that driver got merged recently without > bindings? Why bindings are separate? > > The bindings always come together in one patchset with the driver > implementing them. Bindings are though a separate patch, yet still > followed by the driver which uses them. > > I do not see any compatibles in that driver, which suggests there is no > other binding using it. If that's correct, then you need to change the > driver. > The mtk-adsp-ipc driver's sole function is to encapsulate the operations of mailbox framework from adsp ipc users. The mtk-adsp-ipc is not defined in the dts file and we don't need it to be defined. The creation of mtk-adsp-ipc device is requested by adsp ipc users via the use of 'platform_device_register_data'[1]. the driver implemented the mailbox framework is 'mtk-adsp-mailbox'[2]. it has corresponding hardwares and a yaml file[3] to describe it. I'll send a patch to change the mbox name at next version. It's better to have some meaningful names as you said. [1] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=e0100bfd383c7d994d2e957e85ca56a5fe5a3f43 [2] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=af2dfa96c52d042df5deb29fb6e32d3ff4d76a61 [3] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=afa092e1e8824363d3174fef329c034445c111d5 Thanks, TingHan