Re: [PATCH 5/6] arm64: dts: qcom: qcs615: add ADSP and CDSP nodes

[Lijuan Gao <quic_lijuang@quicinc.com>]

在 4/23/2025 5:34 PM, Konrad Dybcio 写道:
> On 4/23/25 11:17 AM, Lijuan Gao wrote:
>> Add nodes for remoteprocs: ADSP and CDSP for QCS615 SoC to enable proper
>> remoteproc functionality.
>>
>> Signed-off-by: Lijuan Gao <quic_lijuang@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs615.dtsi | 86 ++++++++++++++++++++++++++++++++++++
>>   1 file changed, 86 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>> index fe9fda6b71c4..c0e2d8699d05 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
>> @@ -503,6 +503,16 @@ smem_region: smem@86000000 {
>>   			no-map;
>>   			hwlocks = <&tcsr_mutex 3>;
>>   		};
>> +
>> +		rproc_cdsp_mem: rproc-cdsp@93b00000 {
>> +			reg = <0x0 0x93b00000 0x0 0x1e00000>;
>> +			no-map;
>> +		};
>> +
>> +		rproc_adsp_mem: rproc-adsp@95900000 {
>> +			reg = <0x0 0x95900000 0x0 0x1e00000>;
>> +			no-map;
>> +		};
> 
> Please double check these addresses, I'm not saying they're necessarily
> wrong, but I can't find a confirmation for them either
> 
After double-checking, the addresses match those on the latest memory map.
> 
>>   	};
>>   
>>   	soc: soc@0 {
>> @@ -3124,6 +3134,44 @@ cti@7900000 {
>>   			clock-names = "apb_pclk";
>>   		};
>>   
>> +		remoteproc_cdsp: remoteproc-cdsp@8300000 {
> 
> remoteproc@
> 
> [...]
> 
Understood, it will be updated in the next patch.
>> +		remoteproc_adsp: remoteproc-adsp@62400000 {
>> +			compatible = "qcom,qcs615-adsp-pas", "qcom,sm8150-adsp-pas";
>> +			reg = <0x0 0x62400000 0x0 0x100>;
> 
> The size is 0x100000 (1 MiB)

Sorry, my mistake. I checked the latest datasheet, and the size should 
be 0x4040. I will update the register size for both ADSP and CDSP
> 
> Konrad

-- 
Thx and BRs
Lijuan Gao