From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A135C433FE for ; Fri, 6 May 2022 01:49:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1388130AbiEFBwv (ORCPT ); Thu, 5 May 2022 21:52:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349717AbiEFBwt (ORCPT ); Thu, 5 May 2022 21:52:49 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECDB662A1A; Thu, 5 May 2022 18:49:07 -0700 (PDT) X-UUID: e22ab0cec2694569aba31fdfa791b297-20220506 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.4,REQID:f32d2ef3-d71b-41f4-a4e3-01aebce32f80,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACT ION:release,TS:45 X-CID-INFO: VERSION:1.1.4,REQID:f32d2ef3-d71b-41f4-a4e3-01aebce32f80,OB:0,LOB: 0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACTIO N:release,TS:45 X-CID-META: VersionHash:faefae9,CLOUDID:c3f46016-2e53-443e-b81a-655c13977218,C OID:IGNORED,Recheck:0,SF:28|17|19|48,TC:nil,Content:0,EDM:-3,File:nil,QS:0 ,BEC:nil X-UUID: e22ab0cec2694569aba31fdfa791b297-20220506 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1728532245; Fri, 06 May 2022 09:49:02 +0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Fri, 6 May 2022 09:49:01 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 6 May 2022 09:49:01 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Fri, 6 May 2022 09:49:01 +0800 Message-ID: <774c87ffdcac2ca97efef9fc6140f85ddc30e513.camel@mediatek.com> Subject: Re: [PATCH v6 02/10] cpufreq: mediatek: Add platform_device_unregister when driver exit From: Rex-BC Chen To: AngeloGioacchino Del Regno , , , , , CC: , , , , , , , , , Date: Fri, 6 May 2022 09:49:01 +0800 In-Reply-To: References: <20220505115226.20130-1-rex-bc.chen@mediatek.com> <20220505115226.20130-3-rex-bc.chen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-05-05 at 17:04 +0200, AngeloGioacchino Del Regno wrote: > Il 05/05/22 13:52, Rex-BC Chen ha scritto: > > We register the platform device when driver inits. However, we do > > not > > unregister it when driver exits. > > To resolve this, we declare the platform data to be a global static > > variable and rename it to be "cpufreq_pdev". > > With this global variable, we can do platform_device_unregister() > > when > > driver exits. > > > > Signed-off-by: Rex-BC Chen > > Hello Rex, > this commit needs a Fixes: tag. > > Cheers, > Angelo > Hello Angelo, Thanks for the reminder. I will add "Fixes: 501c574f4e3a ("cpufreq: mediatek: Add support of cpufreq to MT2701/MT7623 SoC")" BRs, Rex