From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760879AbcIADyq (ORCPT ); Wed, 31 Aug 2016 23:54:46 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:55171 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754833AbcIADym (ORCPT ); Wed, 31 Aug 2016 23:54:42 -0400 Subject: Re: [PATCH 2/8] writeback: add wbc_to_write_flags() To: Omar Sandoval References: <1472663151-18560-1-git-send-email-axboe@fb.com> <1472663151-18560-3-git-send-email-axboe@fb.com> <20160831233258.GA24440@vader> CC: , , , From: Jens Axboe Message-ID: <774d1195-4a43-5395-14df-981336296720@fb.com> Date: Wed, 31 Aug 2016 21:54:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160831233258.GA24440@vader> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: CY1PR20CA0103.namprd20.prod.outlook.com (10.164.213.157) To MWHPR15MB1198.namprd15.prod.outlook.com (10.175.2.140) X-MS-Office365-Filtering-Correlation-Id: fc8f315e-ff92-4828-fa64-08d3d21ba7cd X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1198;2:+GMF+kFQysq1u8vrluNqUkWhmt/gjWeqP3p3h5HW5W/b+T3gKOBp0SclBU0fwdq3tRVIA6M1YuVAcoQLeNGRhR95/PhPQRD1kfiakDefz47JjEqXYmIbkKZRWM9Rv4wwVvInUxLmlzJVUODXnW23cxXH91juaxH6Wzuan5BFCWW4IdwlbvNpa+UTiAecAd3i;3:gT6gtDw73eYKWIUNZHMni1Zky908udqUodag05NEhKFQd8uz2i+qJw/NvNJknRv57oqbsja0HEbAp4AaeInm9TArk0Uw5GCE0UKfF7IkIh+6gyBdcapCwsYdsxLYj9Kh X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1198; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1198;25:FXDt4e2gQqOsEE3GgoWgEgafy1qwIFcljGBOClZzdwW9/lfc/umck0YcA+x2+wrvybUC0C9Dbqz5FC/TuUiwSaNZeraKLCe7PY/DoI9dvuxhZrm+qXl5iUE7OIWLa3L0+XeuP+RU13EH0d/Kac11OJdPgkJ66s/MjNCDBaAlJhjl7W24/kokeEeLNroUy3vJeec0WEsPSKOFcMMf7NKUhJ8oYwoNVA2MUzpb9Igldv3KuRuUjp+r3p9SrdngXuG+ARK0z2HRMeqDFu1fkpD5mscfk5Tk1r6sk6g9EXi7VrvvetFeeMJ8xrSW4IaeFtjQo+MNiSsy+Ym2xt/CrtoDvH0/RLwNAnszw7FeKd2cZGaDst7UN8bk7wBz6uRc5yseld2WbGVTgRdQrS4AyEXQqz57nJgMecxH9fpTHAse740u+f42DDrfLYiZqR0QRe/Yb6q5SL2uapTCgsqbGDCM0a9mUvbbXW7qIQKHbUWZW5F5RSa21JmLyVV9GZajMe6qOJsKpZC2Ngbr6WJZFyhwQOQeqhU4JJ8VVovlqQmyMTZ4rqjFsFJGi2TmKHLdHKuEkGD+1u5/mUmWIQ38pdfTZW0OumGTT5uW8ekMHwQBgLKsb9oep7AO8np4N4ImBX2qO7KW+o2q8i3Jp31qaygC6YD0cXxI1bt5cZMLAx6lu3yrS19WEfzF5R8dxJtndG0c;31:QaafuBiBtq413mbDCVeChJoe0Not+tSHVAwST9STXR82S//BJVV54U3aafDZ+UanPdmE0eMA6TteF0/S9Z24itZoriJVx4984FSL270LgTrlWKsR1XxbbX/vric66IMDBX7fIS9jv3P6vt7Hr2tlq7lK/BWm+Zd8K7CnzadkBUGLKFgSu4Ng/mrr2qXt+Cjdp6S0CR4+1QPVZTCWVPimp8DHlVog1jJJmKdsmOaZ04A= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1198;20:4WCyvxsM7NC7VNOikmI+Y+MukqOLeFNft8hZNAf0FmsUuE9DlKV0JWX1Fo9Uy62qpaKWX5CdKKZUD/0Z/aZNjja/vcIkM6WDDGQiNRiJygAdkclrhP2f4hTF7RlqXURZ8UpKBQ0IYnHsAEuFFjTBLrU+JYCKP/Z28fMTtyNnGug=;4:bEghBKb/Jbe31WMhYYcmap8/OetI1AXbLlZpikdwGrgGuam2xqIELnzN00KAVcZrRenlxHJsLM45ibUBh+zQjvj9zFaqqK6OIcjAHYun3vozxeXer+50PMyiimC1yv4UsloShupU4y8aKHfryWvWrTFz9eyp7s+MO7+Z570zhDhEF+4UlAzeds6UIjlp65CDchAhvzsiiEvXpUXiNDn+Y0bOopQPcAoBNAgu1i8Sy9CFjef+BB1/cv5l92bjh5gFooTubG75Z2JlIa4OU7zQBRBLqyOeR/Vk8DrhdWB5Sve0vk6Zvo7GaO+tdrpe5FVtwIHJtq5lKuCIo7zn11bAlq6jR8YsSH7L/Jjo0uHWTlSiiVgfmnYdYDj9/lJezghOQBpZ0533ulNQo1hlH5tzRKMYyw18Vo4G1lduxHazcD7pfhTxO4AiePS2lZiO87Cv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:MWHPR15MB1198;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1198; X-Forefront-PRVS: 0052308DC6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(377454003)(189002)(199003)(24454002)(19580395003)(5660300001)(3846002)(65826007)(33646002)(47776003)(7736002)(50466002)(92566002)(7846002)(305945005)(23746002)(77096005)(2950100001)(65806001)(83506001)(42186005)(6116002)(86362001)(64126003)(65956001)(586003)(110136002)(189998001)(36756003)(8676002)(101416001)(81166006)(66066001)(31686004)(81156014)(68736007)(117156001)(31696002)(105586002)(2906002)(106356001)(50986999)(4326007)(54356999)(4001350100001)(97736004)(76176999)(230700001)(19580405001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1198;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR15MB1198;23:aFuoh75zitUmLe3zim5JBDYMr4mq8ONw87YmY?= =?Windows-1252?Q?RL2ZIOHtCZEly3Uvnjtkvj0emGbHkoYby2lFvygB3HA61cns+LpaYE3P?= =?Windows-1252?Q?2IGzDJEvLIFJ5SxSRv+m/wdIAzJcG9nAeKW+7z2tDCMQ683LeUt1PvgM?= =?Windows-1252?Q?Yw3bliKB5xxfXDNRCKLXDE4dgdfhJIYmkR3ffOsqrwrGGVfScUORyqP6?= =?Windows-1252?Q?FwuR2BeC++Shpggo5EuZNorXUORLbDhQRP1q8YfBVG2+vKF9TKabgqTc?= =?Windows-1252?Q?tVsZKGni7iq+2hDYfCvV8RN+GoZAcXz7wg7mHev8T7W9DmEIH32PN5Rf?= =?Windows-1252?Q?3nQCCrB8vNiKhYa83Tz9N8xtYGKodLt8zCO27lxymMs31TzbaPIKiTe0?= =?Windows-1252?Q?fu5jH4502owHBzqsUrSUPlQ+Na5APLy6lNWGkusmg5WjhnOsiYlrZnyL?= =?Windows-1252?Q?SQzZMxZwuA7AF9DTjkU9bWJhOGecLHZ1+YmIExAwmpjyRRHanXNOPp1M?= =?Windows-1252?Q?Xbfb/pvmSrkfyZijjgAqB+xpPnY0mA3ybXnjq87EFO7Hnczk8qDEddO3?= =?Windows-1252?Q?ldzF6beC39mESZ6YJ+JS5SPVpcEiulCmMpld4mvbAxrsuymtR1jcYl38?= =?Windows-1252?Q?yzhL3ycZbk+HvvqK6WOr3aeYBzzi3nYcZChJ+BiQzi6Cu2NpgY+nxteS?= =?Windows-1252?Q?x8Gl9slHmEzM1UwmZPw+COb2pf/9uf2g41bD5Wwg+qwKxLyyUtQ3ppEw?= =?Windows-1252?Q?yT6/h15nqtmsezgLtrN6UXBG6N9rLuLgxDSv8MwyhbGPx82tMfiADz5d?= =?Windows-1252?Q?MXAIWBFnF4cJGXLGXFLR2MZbkHEPNBu69MK3ElAIJHyLxYWIuLHuREKo?= =?Windows-1252?Q?sPOfs7+D7g4hWknG8w8QkY04rSSqgaMmyYAGFbZKTHrYw7/BNd/tpH6b?= =?Windows-1252?Q?Ek4iP7nj8MMMnc5JLr9nwRwyhF2Ntju5B5FSjPlDTfaLxYUECFau7NNy?= =?Windows-1252?Q?lYygkPolN7y21TzOXqXw589HObsB36n5oR2Fpl9NEjo/ZkpHyr7p7K2R?= =?Windows-1252?Q?Q8Jv8JuCUJBrNehRfkFqqNoEAyWYQ772qezU8tvjPOohTmAUu/dlBHU2?= =?Windows-1252?Q?hC7Y1SDjPx2Z2k0aHkXwDWYxHIqlTs+2c9h4BNJpA0Kgx7yYww3SIiPA?= =?Windows-1252?Q?ZnKmM0+DAzub4JC2TX5ZSbpzprAZe4FA7huBCJGtvNFY8nQHTNCAIhTN?= =?Windows-1252?Q?fW0YjddBf6esA+ym+a5YhYmEiOCrGx1fYNKEB2U585Ym36FB7FW5eJIh?= =?Windows-1252?Q?ZLOJ1RKAdkfIJl95WlC18nDKgZs5E1C5Hmc25nwaY+bZSmIhZoZg+EXv?= =?Windows-1252?Q?nYs8hoC0bwSsI/8hVbEjweamCT+myh5VZiP7QHQl8T02IjK5W+atlU?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1198;6:6TxtlGriaXxWaTfyBjPqI/M7kOy/TSb8cnvdS+l86/jns4hgYnLfhJga+lHNqzfQoTtM6V4i8Ee4PJxqyMmNiCayIESDnmJacC60AdsmCvDrS1o6kn+zT733LnXiJbH8dELBeV8MsTUljiK9QpaR3+Mv/9UW7G5A3TYGp/rJwXrfvFOyI6achMxfZeP1tkWQwBdqNBYH3t1rq2acJ6ZaX7vhZucSDY6q+JsqkVh+QFQF818mQ0w+YufKd5tRKpGVHoyaujvQWn9RTClP482VoqqaSZS3jsyY0F0O6U3XySA=;5:NSoMdAcJG6OgQ/F6kdpqGIiMeYPRf9ZECYOubX5YCcPAeYjJM+sh96+PnbYQUK9P7eemf3Mkp5o/ldv1B7gWMTtjrveAzRKbGynFbGDU+bbEr+i6ZcGybKFqXPRou+eb2YbJ6oCLOTn+AE0M7OdsVw==;24:Ze+WHw17Q4JUM7N6A6a8sdwxOAoOvv0UEWt9/uu748SrwIy9+QUxztDsmAyA4OuvY96CK0wVoIrgeDWpCR9gaoNiPhqG8NskLMryNj8dtko=;7:s116bj7c1ly0X7cwDiuKr1J+aYsnjbuS007mFOEIKwoR8TMC048kQZlm+npnE4tqC5RS/nhqvOvZK1nxtFkDHVKUN6T137BbrA09JO31Lj7GI7DHHvbZEkXslv4GzGMmclGTjxFNoJQM3FpXKwod2inrIiDgAO+Q5/wT6bswqPF5LeI3Ah3WOvC6YbvHJxnh+DCdiw6yW43zUaHcyTKjOSPdVwjD76K65B+wgjKS65FT/iUMgScxcnaQUVRsO+/U SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1198;20:+Z3Och7AlHmfrWVSUEwP5eG0mzrgI8VzCtY/ci4r7yD2DmfMC5uAiuxqE9dhpos5TJcstw013/NS8ZaDy38I695LAXX5882hUOynFklI33XsjQS6/riGcpxJ5wEXaCMG/419jBYmqwbphV25ocDRyTV3X/Obw8t0bjvfcjOTj0E= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2016 03:54:20.5811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1198 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-01_01:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/31/2016 05:32 PM, Omar Sandoval wrote: > On Wed, Aug 31, 2016 at 11:05:45AM -0600, Jens Axboe wrote: >> Add wbc_to_write_flags(), which returns the write modifier flags to use, >> based on a struct writeback_control. No functional changes in this >> patch, but it prepares us for factoring other wbc fields for write type. >> >> Signed-off-by: Jens Axboe >> Reviewed-by: Jan Kara > > [snip] > >> diff --git a/include/linux/writeback.h b/include/linux/writeback.h >> index fc1e16c25a29..e1fc25172397 100644 >> --- a/include/linux/writeback.h >> +++ b/include/linux/writeback.h >> @@ -100,6 +100,14 @@ struct writeback_control { >> #endif >> }; >> >> +static inline int wbc_to_write_flags(struct writeback_control *wbc) >> +{ >> + if (wbc->sync_mode == WB_SYNC_ALL) >> + return WRITE_SYNC; >> + >> + return WRITE; > > I think this should be `return 0;` after the op/flags split. WRITE == 1, > so this would get interpreted as REQ_FAILFAST_DEV in bi_opf. Good catch, thanks! Fixed up. -- Jens Axboe