From: Randy Dunlap <rdunlap@infradead.org>
To: "Mateusz Jończyk" <mat.jonczyk@o2.pl>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-hwmon@vger.kernel.org
Cc: "Pali Rohár" <pali@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Hans de Goede" <hdegoede@redhat.com>,
"Mark Gross" <markgross@kernel.org>
Subject: Re: [PATCH 2/2] dell-smm-hwmon: rewrite CONFIG_I8K description
Date: Mon, 7 Feb 2022 10:47:21 -0800 [thread overview]
Message-ID: <7753c65a-ce16-eb4f-395b-bc5e54c647c6@infradead.org> (raw)
In-Reply-To: <20220207182940.242838-2-mat.jonczyk@o2.pl>
Hi--
On 2/7/22 10:29, Mateusz Jończyk wrote:
> It is not the laptops, but the /proc/i8k interface that is legacy. The
> old description was confusing, fix this.
>
> I'm not a native English speaker, so I'd like that someone proofread
> this description.
>
> Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
> Cc: Pali Rohár <pali@kernel.org>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mark Gross <markgross@kernel.org>
> ---
> drivers/hwmon/Kconfig | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index dd244aa747ad..8f9f41a9ef70 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -506,18 +506,17 @@ config SENSORS_DELL_SMM
> userspace interface for i8kutils package.
>
> config I8K
> - bool "Dell i8k legacy laptop support"
> + bool "Legacy /proc/i8k interface of Dell laptop SMM BIOS hwmon driver"
> depends on SENSORS_DELL_SMM
> help
> - This option enables legacy /proc/i8k userspace interface in hwmon
> - dell-smm-hwmon driver. Character file /proc/i8k reports bios version,
> - temperature and allows controlling fan speeds of Dell laptops via
> - System Management Mode. For old Dell laptops (like Dell Inspiron 8000)
> - it reports also power and hotkey status. For fan speed control is
> - needed userspace package i8kutils.
> + This option enables the legacy /proc/i8k userspace interface of the
> + dell-smm-hwmon driver. The character file /proc/i8k exposes the BIOS
> + version, temperatures and allows control of fan speeds of some Dell
> + laptops. Sometimes, it reports also power and hotkey status.
Comma not needed ^^^; "it also reports ..." would be more common.
>
> - Say Y if you intend to run this kernel on old Dell laptops or want to
> - use userspace package i8kutils.
> + This interface is required to run programs from the i8kutils package.
> +
> + Say Y if you intend to run userspace programs that use this interface.
> Say N otherwise.
>
> config SENSORS_DA9052_ADC
thanks.
--
~Randy
next prev parent reply other threads:[~2022-02-07 18:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 18:29 [PATCH 1/2] x86/Kconfig: move and modify CONFIG_I8K Mateusz Jończyk
2022-02-07 18:29 ` [PATCH 2/2] dell-smm-hwmon: rewrite CONFIG_I8K description Mateusz Jończyk
2022-02-07 18:47 ` Randy Dunlap [this message]
2022-02-07 18:51 ` [PATCH 1/2] x86/Kconfig: move and modify CONFIG_I8K Hans de Goede
2022-02-07 18:57 ` Borislav Petkov
2022-02-07 19:31 ` Mateusz Jończyk
2022-02-07 21:18 ` Hans de Goede
2022-02-07 18:51 ` Randy Dunlap
2022-02-07 18:53 ` Mateusz Jończyk
2022-02-12 12:56 Mateusz Jończyk
2022-02-12 12:56 ` [PATCH 2/2] dell-smm-hwmon: rewrite CONFIG_I8K description Mateusz Jończyk
2022-02-13 15:28 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7753c65a-ce16-eb4f-395b-bc5e54c647c6@infradead.org \
--to=rdunlap@infradead.org \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=markgross@kernel.org \
--cc=mat.jonczyk@o2.pl \
--cc=pali@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®