From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65AE2C6FD1F for ; Wed, 22 Mar 2023 11:41:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229896AbjCVLlk (ORCPT ); Wed, 22 Mar 2023 07:41:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbjCVLlh (ORCPT ); Wed, 22 Mar 2023 07:41:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6554D50721 for ; Wed, 22 Mar 2023 04:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679485249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BdHMTiAE+PN3GzSq9FiLR9q3XjL4KWEq8dCyo2zV+tg=; b=KqHANJlE/RV3XSHl4HUsVu9LxEUINSb1qOq0OL1jroQBQr9Og7hpYs7oPPASELEJibo/Qe clNr/qycpFpzLUKHzwkCs70hTS5MY3vq5KGyw/qRicwlVsrbmeK+q5gUbY3AIQoRlK0K/a 7TnooQ1IDZy2+Rsv20H0pNhOc/Q7zPE= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-k_EhamwEP8O11seIjS7zCQ-1; Wed, 22 Mar 2023 07:40:48 -0400 X-MC-Unique: k_EhamwEP8O11seIjS7zCQ-1 Received: by mail-qk1-f198.google.com with SMTP id 206-20020a370cd7000000b007467b5765d2so4667423qkm.0 for ; Wed, 22 Mar 2023 04:40:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679485247; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BdHMTiAE+PN3GzSq9FiLR9q3XjL4KWEq8dCyo2zV+tg=; b=p8C+HujQirRU6m9DaHQQzjE7mnND7t0DHorS+E9sULStpAcJFcLLO6wnV/Nq6tveGr NpFd0FPh4kSeItdEayrwWfnFCwfc8InfknXwJWgHakKJ8QadY0FPaUk4LC4Sa9u9HK87 fntEWFu/V/gHn4WR7v2vyGQRoDqKizSgTr5GBCHRPBhmc3UCGGtKg/H60x+uI4akDA4G f4ssc9QU6TLnHrMU/o4T2UsL/N97enGy00FpogTHT0cboO9J5IWxDw/Gxo0L8kGkzClz nrvv5tk5c88NEKXE6/gYFpfTDY+HWUGAxxVcrcRraFxPnemFzu/MHH7T7fNaKhiPvNgD nPvQ== X-Gm-Message-State: AO0yUKWJAtnz7lu49SJTjzfAPvyxnme8m+Vs8lv8pHVTig92/2+KwLph NbCddlzcrnc1cvtsfbXfRdyP7NRacGETwz4w/7vFKEugacDZQueRH5m1mV2Siz9ifAktKfl5EXh NhM43fbxJ7Rnzb77oqkaSKzeqYLkHMpZM X-Received: by 2002:a05:622a:4cd:b0:3e2:4280:bc58 with SMTP id q13-20020a05622a04cd00b003e24280bc58mr9443517qtx.3.1679485247665; Wed, 22 Mar 2023 04:40:47 -0700 (PDT) X-Google-Smtp-Source: AK7set9DrP99ENKzleU94Q4isp4reabSKYEQTsQFVNEIkJ4etjYWZyRlL6TV1t67R5vjgnjlysGGXA== X-Received: by 2002:a05:622a:4cd:b0:3e2:4280:bc58 with SMTP id q13-20020a05622a04cd00b003e24280bc58mr9443495qtx.3.1679485247366; Wed, 22 Mar 2023 04:40:47 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-244-168.dyn.eolo.it. [146.241.244.168]) by smtp.gmail.com with ESMTPSA id r9-20020a37a809000000b007463509f94asm7294844qke.55.2023.03.22.04.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 04:40:46 -0700 (PDT) Message-ID: <7755c026ea1f2c5f6d00aa4ba17233eb511ce3dd.camel@redhat.com> Subject: Re: [PATCH] net/net_failover: fix queue exceeding warning From: Paolo Abeni To: Faicker Mo Cc: Sridhar Samudrala , "David S. Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 22 Mar 2023 12:40:44 +0100 In-Reply-To: <20230321022952.1118770-1-faicker.mo@ucloud.cn> References: <20230321022952.1118770-1-faicker.mo@ucloud.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2023-03-21 at 10:29 +0800, Faicker Mo wrote: > If the primary device queue number is bigger than the default 16, > there is a warning about the queue exceeding when tx from the > net_failover device. >=20 > Signed-off-by: Faicker Mo This looks like a fixes, so it should include at least a fixes tag. More importantly a longer/clearer description of the issue is needed, including the warning backtrace. I think this warning: https://elixir.bootlin.com/linux/latest/source/include/linux/netdevice.h#L3= 542 should not be ignored/silenced: it's telling that the running configuration is not using a number of the available tx queues, which is possibly not the thing you want. Instead the failover device could use an higher number of tx queues and eventually set real_num_tx_queues equal to the primary_dev when the latter is enslaved. Thanks, Paolo