From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAE3B33ADA5 for ; Fri, 14 Nov 2025 17:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763141392; cv=none; b=DEb6Rl3ORGh2utlrhMFqm7sj6+mHNjv4iUtoG/ZcwY7DUw7Mid9aA6mOa2iG+xHpcAQbtqq/2XGZ8sAs9ZgnI3ha9IP6K6exAn1Diadct6HrWTeoj+bmwzuXkPZ9Ke2mZBh5FWQiTnff7ItE+tKwc1vCjtP1O3I6q0VYD/atD70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763141392; c=relaxed/simple; bh=Bxj0CYVXHy/ry1+iDrsNRfoPOFrAUdLRt1mSPe788Vg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bhM+xBlStDzdBmjXxqGv+PUwcJJcy1aYpJtyfzCO26u6Nvt8HzwB74+2eJ0eaEzwHSJpzUtG/kkTtuk/Bune3CE6wPVjoZPyGVUDb21t6V0kYXnBNWfyReuTj8Nt8FFetAj2eLfV6iq8tDSp+WQ9jCnl4dFiSBWgsltKZ6+RqNg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EaLiE5v0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZnGrmIg3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EaLiE5v0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZnGrmIg3" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AEHSuTu397156 for ; Fri, 14 Nov 2025 17:29:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5IZF97taFsnmh5b8jmQL9+OMw+OoZEfr16LawJYCtrc=; b=EaLiE5v06eBoNWRH 8f56DbeDfkYWz3OMQBUgnuNoeXpa4G65cGHMTg9RxojgAFMuFkYgwuidOeagGRXc RVSnIxxvJJN+VugWx4yAZnSlaqeW2iwL606y7mSR+t3Mdx8+XXBJmUwNK4CHqbqA d2uU7vQYBnkKWfNYTNX/9E1kiOf8BkJuxj8jznKreL37Kk1N+5llyRfaGL+DQINS ip4JRKdc5lwg5cC6q2sZslmo/CNfsYEivSETJR+Hz4Q/ks+VsDrPTLDGQvkhXAlN PCWDo1WqvwywPl/lNl7LJX/P/qVy8fZZh9elm/WwXLKYZbPQI8VJ3tflDRCUNsCW JyJ6yA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ae5r7rp0c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 14 Nov 2025 17:29:49 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-297df52c960so55940585ad.1 for ; Fri, 14 Nov 2025 09:29:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763141389; x=1763746189; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5IZF97taFsnmh5b8jmQL9+OMw+OoZEfr16LawJYCtrc=; b=ZnGrmIg3ahx5c1N1+FXNtD/Cer3Cobpi9K4gsG3JC7X7MrKy+IbFu7QllVP4nYfFIv 6C0PNuY+36WfBpyC+SP2XGvzGTsq+LmVDgqP8EJ3oAFToYfGjoZUcJg8cK5NHPvsTsqU 7oFilJJr1Dv6upDsSh09zckpRLa6FYUU6cIcG/xL8UZbbzucZ+7AbNprvD5+ZavCy44U su9onxvJ4nKeWdMIgxM699MANK2gglJl3kuvC1i39nRL7LEB6PDkh4Lpi8XEAYo7spsM bxOCN/6m4yZvssADMnPgKq83XXTrLeQQiOW5/js6tsUReWh81+UECz+wlPE40ziS51rR HU6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763141389; x=1763746189; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5IZF97taFsnmh5b8jmQL9+OMw+OoZEfr16LawJYCtrc=; b=fzzzgQUyXjaxkEqU45vKRom9GyN+gtOYxRB5IpXwKFTitLf875LyGgyHS658Lw62AI sTTCZEDNIgbscv6xE+ebMJYOMo5DQ5gpVREXZoh9W9ufQjT8zL+b7YOeV3lok9m3uCgF 0P6agN9g4CCYsEijbkEpbdqR58kE2tJLGbQt+vxvQ+IzysJdQHPwevfaJKlJahXcgT6t xnEQO+mRO8DtZmVDZtgczlyAEtzxCV+GfdDNkEg0nIJB02TNiWx+vetWgVFC9DLgjFGh /Ld86yzotXQmAKjFJoFrRshPLJy9J2Ad6kRuk9V7Tzg5Oav5ljVhGDIaDR6XCVjuUuDP 4jfA== X-Forwarded-Encrypted: i=1; AJvYcCWFLq8mvaq7nEFU2C9XzWqMwAQ+Wwi4zi+5VmZwxKArpDhCI8tpkHAMT1c+scmzFf/09mcKsY9ArKhphKE=@vger.kernel.org X-Gm-Message-State: AOJu0YxiwtyE4957JZl4d6/hcgPMeUe/uZ4Kp1C+xf73mhoM2Sh90bVd P3NdV9l6CRrw4m8WQXSC3zybsvM/1myiq9mGb+c8YYS0l/VmUM+UKpYLAIjv+E9Cyf3mEVl2LA4 +xTds0OgriypFODcGk23zq8pOfqFS/SRJVzMoKPOWSSFkQXnK2Rk6IZ1H4tmj0O4okeg= X-Gm-Gg: ASbGncv7Th1hguPeghO9DEMFJsJgvQXnRaimxec/A4NsOdtD2ovzdolVPWR+rnDtOD3 LPVXFaoUFg9K7AMOqgPYfi/J6/72stoXUXivXCmh72oCy5SdYDWRfs5UH5uUTxtsk3xfc/3vNHD Iw56nbyB2IsYKrvFLo3aBmUwj4+WULaJz9JIbASH/e3o4RCHfxnYuddeM/BxoxWRaOIAbsB3n4v 7WCqgVU6+vQi++EtJij6LutqsGC8z/+Ru/fcPQwzxiBUK5iLLa6rAlymsqz4V50Cj0EF/knqfln FXjxl+FqTqgTUlNwpil/iMOvbZYLq8qiQsiagtJJKdVtT27zKL9RT5C9phpZ56nvfDUf5SPCbYP 1S5VmepQv+PQxpR0fK9lVhSNcziQvG+vrSjTNSLfh59Lm014xLkSpgZ0dP+Coic6/fNKWkxAKLw eC X-Received: by 2002:a17:902:f705:b0:295:9871:81dd with SMTP id d9443c01a7336-2986a6f3f40mr46121055ad.25.1763141388609; Fri, 14 Nov 2025 09:29:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IF5PNiK7CQR10eCNgq3oo/oD5kyy0U8463HcRT84zlTmppSmWLyBUIeJxcQWwOn0JbTobSH0g== X-Received: by 2002:a17:902:f705:b0:295:9871:81dd with SMTP id d9443c01a7336-2986a6f3f40mr46120635ad.25.1763141388095; Fri, 14 Nov 2025 09:29:48 -0800 (PST) Received: from [192.168.1.3] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c24941csm61501935ad.41.2025.11.14.09.29.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Nov 2025 09:29:47 -0800 (PST) Message-ID: <7757501b-2576-4f5d-a16a-40e06f12cb5f@oss.qualcomm.com> Date: Fri, 14 Nov 2025 09:29:46 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] dt-bindings: wireless: ath: Deprecate 'qcom,calibration-variant' property To: Manivannan Sadhasivam , Krzysztof Kozlowski Cc: Jeff Johnson , Johannes Berg , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, devicetree@vger.kernel.org, ath12k@lists.infradead.org, Miaoqing Pan References: <20251114-ath-variant-tbl-v1-0-a9adfc49e3f3@oss.qualcomm.com> <20251114-ath-variant-tbl-v1-2-a9adfc49e3f3@oss.qualcomm.com> <1703d8d7-5105-4585-b8f0-82bb54809718@kernel.org> From: Jeff Johnson Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE0MDE0MSBTYWx0ZWRfX8x3PY1XpAIL1 4IJ0xAh/Xs68mqZFKaZoGDgDbE4Tm/J/jF82XfI4mAMVtXJ4uCQTAMEV1I4HEvIQrPk16veyZUr JMDLYhstIS4aHkVzCiDiCS8Mz7pq8E+CKWNm1q5fIzlirglf4plkUmiY5H3lOGvWEWZ0VjWXUqq COUuPRcbJUdMnnR24fToZulOmFZ75rquGj5Uc3nBwq7dc4Rq/vuoXcCyBxlGORXkvRNikOxmyE4 ry8ETbOcclUDJfv04k3ve38M+ZpYaUogxPJHz9GgZrL8DwjPm3EVhWo8PewFsnPIEUboeBg9QCR Z4B8cWu8nVwIjMWt/NmjYeZ4MwdQip1n4NzLCwPZPqVcC4DW6lhRMABoVRAA+CPVgKet87g6Wp3 FxBXttuErZtYSE0IBo+iWj0Lb586Bw== X-Proofpoint-ORIG-GUID: GF6cNTAvJemzAoadHR_RBEx_iWxPQseX X-Authority-Analysis: v=2.4 cv=BJO+bVQG c=1 sm=1 tr=0 ts=6917670d cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=LHIKCdfOQfCGPyi8WdcA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: GF6cNTAvJemzAoadHR_RBEx_iWxPQseX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-14_05,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511140141 On 11/14/2025 3:18 AM, Manivannan Sadhasivam wrote: > On Fri, Nov 14, 2025 at 12:04:55PM +0100, Krzysztof Kozlowski wrote: >> On 14/11/2025 12:02, Manivannan Sadhasivam wrote: >>> On Fri, Nov 14, 2025 at 11:47:25AM +0100, Krzysztof Kozlowski wrote: >>>> On 14/11/2025 11:22, Manivannan Sadhasivam wrote: >>>>> On devicetree platforms, ath{10k/11k} drivers rely on the presence of the >>>>> 'qcom,calibration-variant' property to select the correct calibration data >>>>> for device variants with colliding IDs. >>>>> >>>>> But this property based selection has its own downside that it needs to be >>>>> added to the devicetree node of the WLAN device, especially for PCI based >>>>> devices. Currently, the users/vendors are forced to hardcode this property >>>>> in the PCI device node. If a different device need to be attached to the >>>>> slot, then the devicetree node also has to be changed. This approach is not >>>>> scalable and creates a bad user experience. >>>>> >>>>> So deprecate this property from WLAN devicetree nodes and let the drivers >>>>> do the devicetree model based calibration variant lookup using a static >>>>> table. >>>>> >>>>> This also warrants removing the property from examples in the binding. >>>>> >>>>> Signed-off-by: Manivannan Sadhasivam >>>>> --- >>>> >>>> The problem - visible in one of the examples here - is that one board >>>> has multiple WiFi chips and they use different calibration-variant >>>> properties. How do you find the right calibration variant for such case >>>> based on board machine match? >>>> >>> >>> I suspect the legitimacy of the example here. I don't understand how a single >>> machine can have same devices with 3 different calibration data. >> >> Me neither but I am not the domain expert here. >> >>> >>> AFAIU, calibration data is specific to the platform design. And I don't see any >>> upstream supported devicetree having similar properties. >> Deprecating these is fine with me, but I would prefer if we get here >> some clear answers that mentioned case cannot happen. If you are sure of >> that, please mention it in commit msg. >> > > I'm pretty sure that this example is wrong. But I will wait for Jeff or other > ath developers to confirm. As discussed privately this is a valid example. This is a single-band chip. So a tri-band router platform will have 3 boards, one that is supporting 2 GHz, one supporting 5 GHz, and one supporting 6 GHz, and each frequency range will have different calibration data. So we still need to support slot-specific configuration in cases where the slot to board mapping really is fixed in the platform. /jeff