From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 502791A3041 for ; Mon, 2 Sep 2024 16:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725293365; cv=none; b=oRFCgBKf6K41cv5XsoFY6J4KtmT6bhiiKzy5CLYtqKCIAL/FVNoxb+S383XdaIjggpZPErCu5FSxq0o0GRFOKH7vfRvwg+X8WPPf8kONFZVM8vgKt+6LmFI8ye++tPk+QMdBivJAZhcYowXlyBA5I+FlBW9uE5vgWB633vhJZcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725293365; c=relaxed/simple; bh=vZ0hcu0WdCXigcKyq1CEUHRpBRn1lmg8WfyHLp3O+6A=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=SA2MqWWAmjfuZAF1ijD2eIznoN+ZTl+40MZ6A31WG3egFjyO4zpblZ+YmmW6cZAtI3DpBrC4TYcwzaayAevLu+E6mHVJ4FUGzE3CKxTmQ+80y6a9w0aiVLsJjt3aKPZJjq3J4jqhWUZFqAqihUFe2opO5VXzLOdQXw+tnR8lQS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fkNtgEiX; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fkNtgEiX" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-428e0d184b4so36763565e9.2 for ; Mon, 02 Sep 2024 09:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725293362; x=1725898162; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=CBT6lkn8ZK8Bhla+c4LRfo8zJd8uqrdVz88guMjqgyg=; b=fkNtgEiX9wXNDnci52robCBTz0Mx/epMzE8zagSQ0STFgpNhEpQNqvnQbMocjdZ8Do Qq1Zt7iEoNfru+aX9jE3HUoXj7ztkL6kdxMym1yoUHMLAkJcIzc8voMUUVg4WqT+6WxJ k53xPpSxjSF85mkGXovgxDPx36dRctuK7axBcPs6yBAt8ZWK5WEahC5EZprcYN13kSos EyGrJNmyUgSM19wZosIQ6wa2dphTq+6XWhCwYcYhr+6Q6Mj3Kg8jpC24a9EvzjLGnSlG 21NPoF+86QlF9dffnvktgUddbcoJuRINWsqE1f89p1mqwb9xzvR1lJ6pOBOeiPrt97m/ sAXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725293362; x=1725898162; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CBT6lkn8ZK8Bhla+c4LRfo8zJd8uqrdVz88guMjqgyg=; b=NDDqhj9bdM2iPlScF/PbUzcVvMYn9PwtsOxtZAoZMAEnlcYHHWh2Uy+VFZ/vGZFxc9 +hLn5D+Emp+HU0EfvLL64ybNSApOvCswS9rpLvKiRAnFPr9ekv677RTpqs8hmBdS+b9l aN//bcI2NjCdrywJ9cW26aGB03BzfhZAlx2fwnX5w7a4XTLyw47OvGhJsqlPCFz5Ol10 LF6xpja/L+jio9s2cF9YVBt0l/j6PKdadG+6Uq594hBJAGiwREUBlOHYGlXBz9BlFNtY LBX94wrzLJfkFpD3OiKRfupwD7OpqeQRaWlVKk59RDzcXSPPW8ExcjMPjced2XS0m3A1 mh3Q== X-Forwarded-Encrypted: i=1; AJvYcCVrxMltQdGYGYmZlA3SMHgKsDIfne/ihYPeEAasn9C6b3f44Jl/8iZPXkzeMtVKClbdu/lVeMMJXpSVn04=@vger.kernel.org X-Gm-Message-State: AOJu0Yzqt7l/QlrgIVBQoMmmA5+JROemxTWKQgQ0ektbrIdPygoV/6VE FbtBR5VEEGpyuWhSVOeBnWVtVw5FQjsoVsUXy8HOWSOqD93QNzyzzcEQcJr9asg= X-Google-Smtp-Source: AGHT+IG4KtZkxzTrDxxtmyN/G73pYEBB6VJdn7Ut4aMFJaWdA93xOcKmSIQpZLe2W1FntJDprgaIZw== X-Received: by 2002:a05:600c:c13:b0:428:abd:1df1 with SMTP id 5b1f17b1804b1-42c7b5a8d28mr46717395e9.9.1725293361172; Mon, 02 Sep 2024 09:09:21 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:7dba:3cd0:a1f4:e3fa? ([2a01:e0a:982:cbb0:7dba:3cd0:a1f4:e3fa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6e36626sm142355315e9.47.2024.09.02.09.09.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Sep 2024 09:09:20 -0700 (PDT) Message-ID: <7762a199-9091-46d7-a172-5cccc51a26e9@linaro.org> Date: Mon, 2 Sep 2024 18:09:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 2/2] arm64: dts: qcom: x1e80100-romulus: Set up USB Multiport controller To: Konrad Dybcio , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , 20240830-nxp-ptn3222-v2-0-4c6d8535cf6c@linaro.org References: <20240902-topic-sl7_updates-v1-0-3ee667e6652d@quicinc.com> <20240902-topic-sl7_updates-v1-2-3ee667e6652d@quicinc.com> <925061d3-9894-4332-8c2a-e494ad22c66b@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 02/09/2024 18:07, Konrad Dybcio wrote: > On 2.09.2024 6:01 PM, neil.armstrong@linaro.org wrote: >> On 02/09/2024 16:50, Konrad Dybcio wrote: >>> From: Konrad Dybcio >>> >>> The USB MP controller is wired up to the USB-A port on the left side >>> and to the Surface Connector on the right side. Configure it. >>> >>> While at it, remove a stray double \n. >>> >>> Signed-off-by: Konrad Dybcio >>> --- >>>   .../boot/dts/qcom/x1e80100-microsoft-romulus.dtsi  | 59 +++++++++++++++++++++- >>>   1 file changed, 57 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi >>> index 5419d0b02785..ac2acf949b70 100644 >>> --- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi >>> @@ -572,7 +572,17 @@ &i2c5 { >>>         status = "okay"; >>>   -    /* Something @4f */ >>> +    ptn3222: redriver@4f { >>> +        compatible = "nxp,ptn3222"; >>> +        reg = <0x4f>; >>> + >>> +        reset-gpios = <&tlmm 7 GPIO_ACTIVE_LOW>; >>> + >>> +        vdd3v3-supply = <&vreg_l13b>; >>> +        vdd1v8-supply = <&vreg_l4b>; >>> + >>> +        #phy-cells = <0>; >> >> It's unrelated to mutiport USB-A, should go in a separate change, >> and also probably in a bigger change enabling usb-c features using >> the retimer. > > No, this chip converts between eUSB on the PHY and USB on the port Oh my bad, indeed, sorry for the confusion Neil > > Konrad