From: Prasad Pandit <pjp@fedoraproject.org>
To: Joe Perches <joe@perches.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] checkpatch: error if file terminates without a new-line
Date: Wed, 17 Apr 2024 06:36:10 +0000 (UTC) [thread overview]
Message-ID: <776311640.119588.1713335770163@mail.yahoo.com> (raw)
In-Reply-To: <a582c379f1bc2bc0d16b46ece9211bac40b4b7cf.camel@perches.com>
On Tuesday, 16 April, 2024 at 03:25:18 pm IST, Joe Perches wrote:
>There's an existing check for this. Fix that instead.
>
># check for adding lines without a newline.
> if ($line =~ /^\+/ && defined $lines[$linenr]
> && $lines[$linenr] =~ /^\\ No newline >at end of file/) {
> if (WARN("MISSING_EOF_NEWLINE",
> "adding a line without newline at end of file\n" . $herecurr) &&
> $fix) {
> fix_delete_line($fixlinenr+1, "No newline at end of file");
Okay, will check; Thank you.
---
-Prasad
prev parent reply other threads:[~2024-04-17 6:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240330033858.3272184-1-ppandit@redhat.com>
2024-04-16 7:04 ` Prasad Pandit
2024-04-16 8:48 ` Greg KH
2024-04-16 8:59 ` Dan Carpenter
2024-04-16 9:55 ` Joe Perches
2024-04-17 6:36 ` Prasad Pandit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=776311640.119588.1713335770163@mail.yahoo.com \
--to=pjp@fedoraproject.org \
--cc=apw@canonical.com \
--cc=dan.carpenter@linaro.org \
--cc=dwaipayanray1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=pj.pandit@yahoo.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®