From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A6E7C4BA25 for ; Wed, 26 Feb 2020 18:43:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51B2920714 for ; Wed, 26 Feb 2020 18:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582742619; bh=diLztPXpAfYASZqUNHYSsge58dD700TdV6rXAVsUbDs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=nSASArpd2RV1faNz9RVWkdgnj55qAbwD+2NGbdAqCmh2A8dUoCHQQi+xMw7gLJycY IKeqG9ri7AAFFnoYh4EuOpA8b9wOYwO2eEHS7qg0FYMVopjJrDev2xRx6a+iz7S8EV WliZEmxLWk0risRsbeAHyE2RNYIJekL8u1kW1f6U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727310AbgBZSni (ORCPT ); Wed, 26 Feb 2020 13:43:38 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:34950 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727198AbgBZSnh (ORCPT ); Wed, 26 Feb 2020 13:43:37 -0500 Received: by mail-io1-f65.google.com with SMTP id h8so284205iob.2 for ; Wed, 26 Feb 2020 10:43:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=a9lte+fOFVwIvTxY0D7kbm+KY6FljHyVVBNSpRiNzyM=; b=OucBm0ZhnE71Y6NLaHS+8+OxDn0OXDGuas9PRChmy3QLD0bVR75NCbyTbysiQKfv+5 tgnJ96uTgDVWcOMM/h7OtqLUnDPZw70AvkLeDgpR2Xdako1sEqaK0hp+ugfXxgUlO/Bg D4GSs/1E98Z9r5M5JPSCCVNru12XZSg9js6PY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=a9lte+fOFVwIvTxY0D7kbm+KY6FljHyVVBNSpRiNzyM=; b=BdbtIritkliIYj1vVtjAflYIM20Lr7PkJAU9xyigvgSijSZM7cuWEJF3Z1MUbQNBpY a1nGom352L/ON5QP76JmqjA8d+hkSEnDOVWDwgy4B11RGgoLwzh45lu0lTsHtBodwzra uI7qjNUHWkDbpX7QnRVIICerZbK3nZsCWLdvBPEaQMMOWI/dNxPD2ML8KUpgDNGRou7t Xa/mc9lE0GwZFOg7sdhjJcPxaMleStZwkXdXcohmY8TV3+QP5haCVjEa56Qapjr8BKqi VLTWg8zTpdkRSpF4uEvXZdnnnWw1686oyczO3far3lCc9LTj60IMsF2Hwi7OZdtJWUjc xJ8g== X-Gm-Message-State: APjAAAXKJrL1YTXGFUcwV86QzLWqUsxhvuX5SbfOpIYfn0/0GqLbk2td UPk9EMKKZFje6KLoXgMTrL2iuP3MUO4= X-Google-Smtp-Source: APXvYqy+pCE4nTPCtile37Mod0xvFRqxBv28FMYOV6K0DBWl5tfRZlfaid7fmF8zL+YAb6vyUG5KJw== X-Received: by 2002:a6b:cf0a:: with SMTP id o10mr5292089ioa.267.1582742616682; Wed, 26 Feb 2020 10:43:36 -0800 (PST) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id c24sm765230iom.0.2020.02.26.10.43.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Feb 2020 10:43:36 -0800 (PST) Subject: Re: [GIT PULL] Kselftest update for Linux 5.6-rc4 To: Linus Torvalds , Christophe Leroy Cc: Michael Ellerman , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , "skh >> Shuah Khan" References: <94b64a48-a337-63c4-c504-7e9b0c29a7c6@linuxfoundation.org> From: Shuah Khan Message-ID: <7764e4a5-1efc-2560-3766-bfce826af985@linuxfoundation.org> Date: Wed, 26 Feb 2020 11:43:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/26/20 11:14 AM, Linus Torvalds wrote: > On Tue, Feb 25, 2020 at 3:26 PM Shuah Khan wrote: >> >> - Declutter git status fix from Christophe Leroy > > I've pulled this, but just for future reference (and hoping for a > future cleanup patch): instead of putting things in the global > .gitignore file, do it in the relevant local one. > > So you could just have added > > *.sh > !run.sh > > in 'tools/testing/selftests/lkdtm/.gitignore' instead of doing > > # Generated lkdtm tests > /tools/testing/selftests/lkdtm/*.sh > !/tools/testing/selftests/lkdtm/run.sh > > in the top-level one. > > That keeps things much better separated. It also incidentally means > that if a directory gets renamed, the gitignore file just "magically" > continues to work (if you rename the actual files themselves that are > named in gitignore, then that's obviously a different thing). > > If you put it in the leaf directory, it also means that you don't need > the '/' at the beginning, because the local gitignore entries will > only affect that subdirectory (and any subdirectories under it). > > So please put only "global" gitignore patterns in the top-level gitignore file. > > Linus > Thanks. I will keep this mind as I review these kinds of patches. -- Shuah