From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FAEA1AF0A6 for ; Wed, 22 Jan 2025 09:47:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737539243; cv=none; b=WF+IX/WZGYQFj1JJY0kQgQ1DqK5yIMXKPYW+K5wCW5R1uP3QDX/n7CKOPEl8kt3P1V12JoyBqWECZp5rYiukXqiKqLXIYhJeZDL/RlED6p0hQ1XsXCU95AIiv0H3I3Rr82TbfTMN1XKrfA6E28zMPXqk4q0FOl2zMz+fte1iWWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737539243; c=relaxed/simple; bh=XQmgLb3/zKbQ3lMMYZUnkl3wV9VqimZSt2qG1KK3Bdw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YJojKDdfVsksoCIhVwzPrl3T0wlFziQTH0VAmTg4lx1/eMNDDnYF0ps8MvuqBMLz/y4jMQUclWm5jyWq25aw23aHYHrf90HfvEkDzhdcox108aKuoGBm2eNnKX75abv3MjLen5QpQ4SnzNs4zKoYnYzFPUnZjCgaQ6PDaHqO7kI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fGNwBwn1; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fGNwBwn1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737539241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TsLeYsoyEKErr2erYhr1Mgsyf65whG+axehkGnVa2Kc=; b=fGNwBwn15HG1wdo1qFxiouFWXh4kCveBOWX0Xuv5Y+5PojMT/1TCMD7o9kOjEY1owOw97+ LRC4bR7thG35lUn5viJm4AekYt/d3gg5tEYaCK28A3zXpc3+r1V/axQCISAw+jDEWpllZX nVCMNhRDyuDCeT6UVqGpNi7N6ref6Iw= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-q2hU3wd1M1e9SJ4uB2-Z2w-1; Wed, 22 Jan 2025 04:47:19 -0500 X-MC-Unique: q2hU3wd1M1e9SJ4uB2-Z2w-1 X-Mimecast-MFC-AGG-ID: q2hU3wd1M1e9SJ4uB2-Z2w Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-5d3c284eba0so8952877a12.1 for ; Wed, 22 Jan 2025 01:47:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737539238; x=1738144038; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TsLeYsoyEKErr2erYhr1Mgsyf65whG+axehkGnVa2Kc=; b=qVjNOrsESTph0c4rfSmIu8T/pJkDOM7V5SGMzQlfRF5mVN1jwL5tgZ99P8UoYyobMa djJACWaaSv+fwZssgOLaWLtyesIQEwJQVFJYOyahJY1z0KsyHuvCQK1b4Vc+3RKC3CD8 N8y1mpiFk5gVZsFqJNyViJeTzqCPcwIhukKjSlCuVhLLj0ZIevC0Dzz3GJ+DK+kub3i3 LdgfS+wmzwdxrkKiIhZK0rQ0ezodPbJGNc2hVkvLDfvmOKlclXkS0BEQ4n2s9rCLsJwZ ieyeEoHrFlnqG/I5PzyT0L5udqlG/BKi564CoD3cFshhNjf4FpuKTqUgQTr6rLwwJYda 59HQ== X-Forwarded-Encrypted: i=1; AJvYcCVzTYllOTebNT7PNmHeXneKezcJp7wp5OZAEtdzZLN2A5YgzYRYeHuJisje/oEffPYbHNTmDM3fxC6/oiY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl36ARiBf960S4PxZHtz8t5V5TafcRsBMKFFVNy/X6mR3QNLe6 OVPWvoPCwU8k+liQQ9xiXZGlIUt81uPgwyDAqmt25O3G/tmMWkO7V0M/THz8HpC1aJLhNaR13JJ WzrxCskoN3bDbJHcXTtaWJqSoaxS+ZocuNwpktb6R0BrqNyu1LRJQmaTsLmdfqA== X-Gm-Gg: ASbGncv2Llhl+XgCJpaVsUnntCWXHnbFnyh3QLOBZKrbeMJhqpir+716VfLM801Kn+z X5nTXYIXxfuxdWUlxB1gufqYBKYIqTPmYfiB5vo4/UE3cb2RWCn61S/IuPC2a95VYwOZM6B7iRO TSiX9vuPDMkwuUeUkxGQiDns+FFvCRwtY5Lm+s4ppqyeX5PipDGAqVaN+b4MDv989u3Hp5jsbZC LqjSsCb2ALUPFBJk+eFrV+T5Mh6nhaeIyxxnMHjzYPiqcQRbJtIY4pKeHIBXtmpGOEcgGc2FGoK CmuwUXYQhqybQs3B1sgbfGKAdYDA99kpAZqtHEmdGVeAblAQ4ITsVZTWjwQc34omFz0EFV7zeIQ PyouidAziz6I3iXiLtYAm8l498TsHmo/DmKQWpQ/Ojq1v X-Received: by 2002:a17:907:1c22:b0:aae:93aa:9ac7 with SMTP id a640c23a62f3a-ab38b3da31fmr1989562866b.50.1737539237926; Wed, 22 Jan 2025 01:47:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqAbMRXyz3uDWOxRB7wiAdfagTZ0LJ6CePCH7eVI5HxpP+N6pd7pAvC+AuYMkb+Nttwojddg== X-Received: by 2002:a17:907:1c22:b0:aae:93aa:9ac7 with SMTP id a640c23a62f3a-ab38b3da31fmr1989561066b.50.1737539237562; Wed, 22 Jan 2025 01:47:17 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384c5ad7bsm879836366b.36.2025.01.22.01.47.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2025 01:47:16 -0800 (PST) Message-ID: <776553f3-74a6-4357-ab10-b5b25812b4a8@redhat.com> Date: Wed, 22 Jan 2025 10:47:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] vbox: add HAS_IOPORT dependency To: Arnd Bergmann , Arnd Bergmann , Christian Brauner , Christian Kujau Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org References: <20250122065445.1469218-1-arnd@kernel.org> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20250122065445.1469218-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 22-Jan-25 7:54 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The vboxguest driver depends on port I/O for debug output: > > include/asm-generic/io.h:626:15: error: call to '_outl' declared with attribute error: outl() requires CONFIG_HAS_IOPORT > 626 | #define _outl _outl > include/asm-generic/io.h:663:14: note: in expansion of macro '_outl' > 663 | #define outl _outl > | ^~~~~ > drivers/virt/vboxguest/vboxguest_utils.c:102:9: note: in expansion of macro 'outl' > 102 | outl(phys_req, gdev->io_port + VMMDEV_PORT_OFF_REQUEST); > | ^~~~ > > Most arm64 platforms don't actually support port I/O, though it is > currently enabled unconditionally. Refine the vbox dependency to allow > turning it HAS_IOPORT off in the future when building for platforms > without port I/O and allow compile-testing on all architectures. > > Fixes: 5cf8f938bf5c ("vbox: Enable VBOXGUEST and VBOXSF_FS on ARM64") > Signed-off-by: Arnd Bergmann Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/virt/vboxguest/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/virt/vboxguest/Kconfig b/drivers/virt/vboxguest/Kconfig > index 11b153e7454e..eaba28c95e73 100644 > --- a/drivers/virt/vboxguest/Kconfig > +++ b/drivers/virt/vboxguest/Kconfig > @@ -1,7 +1,8 @@ > # SPDX-License-Identifier: GPL-2.0-only > config VBOXGUEST > tristate "Virtual Box Guest integration support" > - depends on (ARM64 || X86) && PCI && INPUT > + depends on (ARM64 || X86 || COMPILE_TEST) && PCI && INPUT > + depends on HAS_IOPORT > help > This is a driver for the Virtual Box Guest PCI device used in > Virtual Box virtual machines. Enabling this driver will add