From: Michal Simek <michal.simek@amd.com>
To: Yangtao Li <frank.li@vivo.com>, Borislav Petkov <bp@alien8.de>,
Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] EDAC/synopsys: Convert to devm_platform_ioremap_resource()
Date: Tue, 4 Jul 2023 14:17:09 +0200 [thread overview]
Message-ID: <7765c981-7ea1-60a8-a297-7f739ca9a458@amd.com> (raw)
In-Reply-To: <20230704101811.49637-3-frank.li@vivo.com>
On 7/4/23 12:18, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> drivers/edac/synopsys_edac.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
> index f7d37c282819..620861fb5231 100644
> --- a/drivers/edac/synopsys_edac.c
> +++ b/drivers/edac/synopsys_edac.c
> @@ -1325,11 +1325,9 @@ static int mc_probe(struct platform_device *pdev)
> struct synps_edac_priv *priv;
> struct mem_ctl_info *mci;
> void __iomem *baseaddr;
> - struct resource *res;
> int rc;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - baseaddr = devm_ioremap_resource(&pdev->dev, res);
> + baseaddr = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(baseaddr))
> return PTR_ERR(baseaddr);
>
Reviewed-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
next prev parent reply other threads:[~2023-07-04 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 10:18 [PATCH 1/5] EDAC, mellanox: " Yangtao Li
2023-07-04 10:18 ` [PATCH 2/5] EDAC/dmc520: " Yangtao Li
2023-07-04 10:18 ` [PATCH 3/5] EDAC/synopsys: " Yangtao Li
2023-07-04 12:17 ` Michal Simek [this message]
2024-01-23 13:57 ` Borislav Petkov
2023-07-04 10:18 ` [PATCH 4/5] EDAC/ti: " Yangtao Li
2023-07-04 10:18 ` [PATCH 5/5] EDAC/xgene: " Yangtao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7765c981-7ea1-60a8-a297-7f739ca9a458@amd.com \
--to=michal.simek@amd.com \
--cc=bp@alien8.de \
--cc=frank.li@vivo.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®