From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDED23B27C8 for ; Mon, 8 Jun 2026 08:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780907711; cv=none; b=iWllMcifAGdiNGH+HNv8ElcXgJQKtd6oCowzSOUI/lSJbmEnwTEo7ZzcxYmx2RUyP3bXN5T2XYi+w3Mb6yrjfQEfv4Yx3HZ691wGFu3cFGykhwo99Ge1CIG4uz0gaLz0yIAlVo5WU/AwLcABQhv3Wg7knnlrfAWH148lXxi+eO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780907711; c=relaxed/simple; bh=VM/bNOZTb0RCzRWmIDoLOJCCyLB90lnxDaW3yIFW1Xo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VQUr56cPC0qQ2AoO4cvIHyFQOVCz50abbDv65KbT6qX5OXOM7229IcuZfihDmj7ZHilLkCohxPMiCbgpvaIg8LydYVIAi23/VPMqkMSuX8ecFsHEizgGx+E6FElIpKkW6UZO+plVG+UuwFWvUtiE+sipZP+XHLj2cS4SCFVnyD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DKXKgou2; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=aAk4RBCI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DKXKgou2"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="aAk4RBCI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780907700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/LdI09yfbzRCb1twey6OkL3QcRw2oFWT9IrdWUT5qiU=; b=DKXKgou2i5/+AhjWscN6hari9eLSz26/2j577Yo/+hTye0MmUV+Ma+fZcKnqQXFDju9ab6 Uis5gkGT7rfKzwF/F1SB71Wn/fdt5j0VV5O8I7p4w/+qYNShs/nDEid+Quvvym7CGVcGln RwA2U2T7TZTW6bZPWYFTPlk+N2KOqvA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-711-TCUFKFj6OTG7jp5jazpGJw-1; Mon, 08 Jun 2026 04:34:59 -0400 X-MC-Unique: TCUFKFj6OTG7jp5jazpGJw-1 X-Mimecast-MFC-AGG-ID: TCUFKFj6OTG7jp5jazpGJw_1780907698 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-45eef10d5ebso1943832f8f.0 for ; Mon, 08 Jun 2026 01:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780907698; x=1781512498; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/LdI09yfbzRCb1twey6OkL3QcRw2oFWT9IrdWUT5qiU=; b=aAk4RBCIfwGe/c8fGRu0T/BSvIKrbXuxUrWyWd3ympr/bVnCAkIKjSo7/bHd8IrRgj lDdXg83wYVlpqsDo98ii0TbZGgc7OUQ9jV3NJEJ03+tY80cwJIMITU2tdog9uLd0r3rK G+AmY5vOCN8yEXQVuosGyE7TQNSCcIPA9m5XZTC85+Gbd02rpOQbBVE/LRWp2gRyto4/ +zEj/4VOcg9Cs/bj9QokLWu2VYclGkRU+/hX+O8hAia+vw0sxg4WFH0RkWRAQA4oAwDn pzxZMzGD7P9LdmkPYCoQiQmlnTqVQAbJS3Zc6mHbFDlePGnz1HFLJDF4NIcNH9RYIsIP ZOtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780907698; x=1781512498; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/LdI09yfbzRCb1twey6OkL3QcRw2oFWT9IrdWUT5qiU=; b=athxAV6sAczVR2BuO5a2QRi7b+kY+Z/ISdqk4z9b1lZpPUjurmQK8QbTNg9O8DDikb 2heKmPshh5mEltloWBBcIK/PBYz8VM+dSNzLKYnQHNsYtns9Bbj0CSND975QAJ266j6+ jmbLA0MnVcKlN3oSqu2PP1v/DBVJAUjoUxfD/s8hNep5lvibsfM5GRs7Wn1T2cqu7FLe U5Ph9Zxvcp43B3xVszNLUCukUF7esSAhyFYIBJRNr24uFroH1votcA2YvE7DKZKijzHA elHDn1SREbFiGg4G1763hXRxNbH4asJufN4hZszQtPw/8pAbwJQcrdfZgNx37J78pnOX 2d7g== X-Gm-Message-State: AOJu0YwxJMlxbQks4VkV1lV9g2uD9fWJ2D6TwYXjNzckSwXrRSWrpAUo myGwbPMVmqz4psl2jShHeiLgxwE+QUjxN+3yfdBPkqtQTw4ZMdRrVqanzlasUMxKTUp+i9yohej TUhemcBLOzf2UyqsQXHA5XRA5wRPM0AHM695sYqe3XuE97joIPQ4AaA87J4Vr6vxdn06L+U6TCm eJfevus570YOa6Rrv0Zm7ODP3ZIvo9qFaWRmDPAMl01oY= X-Gm-Gg: Acq92OG9KWUVLrb73129zXhiQ5KEYSXiXIZ7gCe4Vzbbjhj0kg3t7Q6Zd5Icp+kLiMU ASpV7ty9teP10tES0wUu+d3SJ+2BVQ+95D2NoT10yKxPit1qx2c95NjhbexPwb/qnoKzZaE4EDt w9NCq+PaEE8yk+laYgP92hQAyybMksJ34nS02gV0nDixaNUb2ocwWtMv8gqbXMZaZNuxv/Rw5ia WWh5nt3IhyXRkHDOag5fsUc2hL6wMC562+HQENLct5k39Eo/EhRzOjKvXtpEPcMuINJmWcav+g1 bE3k9xxGpqvyVOZiuwEkevuYpXEFnoOxBSGO9kPjok7nOe0zXxeKwvy8xxSXt0IbJT1sVYbzOn+ 8aU5K/GncySR0HTixp85TLwo= X-Received: by 2002:a5d:660c:0:b0:460:1695:89be with SMTP id ffacd0b85a97d-460302f1a80mr16882993f8f.17.1780907698219; Mon, 08 Jun 2026 01:34:58 -0700 (PDT) X-Received: by 2002:a5d:660c:0:b0:460:1695:89be with SMTP id ffacd0b85a97d-460302f1a80mr16882899f8f.17.1780907697659; Mon, 08 Jun 2026 01:34:57 -0700 (PDT) Received: from redhat.com ([31.152.37.159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2dcae2sm53186372f8f.6.2026.06.08.01.34.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 01:34:57 -0700 (PDT) Date: Mon, 8 Jun 2026 04:34:50 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v10 04/37] mm: page_reporting: allow driver to set batch capacity Message-ID: <776d350bffd86c5776485ffc4f24e668df36367e.1780906288.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.51.2.2891.g4157995a80.dirty X-Mutt-Fcc: =sent Add a capacity field to page_reporting_dev_info so drivers can control the maximum number of pages per report batch. This is useful when the driver needs to reserve virtqueue descriptors for metadata (e.g., a bitmap buffer) alongside the page buffers. The value is capped at PAGE_REPORTING_CAPACITY. If unset (0), defaults to PAGE_REPORTING_CAPACITY. The virtio_balloon driver sets capacity to the reporting virtqueue size, letting page_reporting adapt to whatever the device provides. Note: capacity need not be a power of 2. The DIV_ROUND_UP in page_reporting_cycle() uses integer division, which the compiler handles efficiently. Rounding would halve the batch size for non-power-of-2 virtqueue sizes, wasting capacity. Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 --- drivers/virtio/virtio_balloon.c | 5 +---- include/linux/page_reporting.h | 3 +++ mm/page_reporting.c | 25 ++++++++++++++----------- 3 files changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index f6c2dff33f8a..6a1a610c2cb1 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -1017,10 +1017,6 @@ static int virtballoon_probe(struct virtio_device *vdev) unsigned int capacity; capacity = virtqueue_get_vring_size(vb->reporting_vq); - if (capacity < PAGE_REPORTING_CAPACITY) { - err = -ENOSPC; - goto out_unregister_oom; - } vb->pr_dev_info.order = PAGE_REPORTING_ORDER_UNSPECIFIED; @@ -1041,6 +1037,7 @@ static int virtballoon_probe(struct virtio_device *vdev) vb->pr_dev_info.order = 5; #endif + vb->pr_dev_info.capacity = capacity; err = page_reporting_register(&vb->pr_dev_info); if (err) goto out_unregister_oom; diff --git a/include/linux/page_reporting.h b/include/linux/page_reporting.h index 9d4ca5c218a0..5ab5be02fa15 100644 --- a/include/linux/page_reporting.h +++ b/include/linux/page_reporting.h @@ -22,6 +22,9 @@ struct page_reporting_dev_info { /* Minimal order of page reporting */ unsigned int order; + + /* Max pages per report batch (default PAGE_REPORTING_CAPACITY) */ + unsigned int capacity; }; /* Tear-down and bring-up for page reporting devices */ diff --git a/mm/page_reporting.c b/mm/page_reporting.c index 7418f2e500bb..5b6b17f67131 100644 --- a/mm/page_reporting.c +++ b/mm/page_reporting.c @@ -174,10 +174,10 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, * list processed. This should result in us reporting all pages on * an idle system in about 30 seconds. * - * The division here should be cheap since PAGE_REPORTING_CAPACITY - * should always be a power of 2. + * The division here uses integer division; capacity need + * not be a power of 2. */ - budget = DIV_ROUND_UP(area->nr_free, PAGE_REPORTING_CAPACITY * 16); + budget = DIV_ROUND_UP(area->nr_free, prdev->capacity * 16); /* loop through free list adding unreported pages to sg list */ list_for_each_entry_safe(page, next, list, lru) { @@ -222,10 +222,10 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, spin_unlock_irq(&zone->lock); /* begin processing pages in local list */ - err = prdev->report(prdev, sgl, PAGE_REPORTING_CAPACITY); + err = prdev->report(prdev, sgl, prdev->capacity); /* reset offset since the full list was reported */ - *offset = PAGE_REPORTING_CAPACITY; + *offset = prdev->capacity; /* update budget to reflect call to report function */ budget--; @@ -234,7 +234,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, spin_lock_irq(&zone->lock); /* flush reported pages from the sg list */ - page_reporting_drain(prdev, sgl, PAGE_REPORTING_CAPACITY, !err); + page_reporting_drain(prdev, sgl, prdev->capacity, !err); /* * Reset next to first entry, the old next isn't valid @@ -260,13 +260,13 @@ static int page_reporting_process_zone(struct page_reporting_dev_info *prdev, struct scatterlist *sgl, struct zone *zone) { - unsigned int order, mt, leftover, offset = PAGE_REPORTING_CAPACITY; + unsigned int order, mt, leftover, offset = prdev->capacity; unsigned long watermark; int err = 0; /* Generate minimum watermark to be able to guarantee progress */ watermark = low_wmark_pages(zone) + - (PAGE_REPORTING_CAPACITY << page_reporting_order); + (prdev->capacity << page_reporting_order); /* * Cancel request if insufficient free memory or if we failed @@ -290,7 +290,7 @@ page_reporting_process_zone(struct page_reporting_dev_info *prdev, } /* report the leftover pages before going idle */ - leftover = PAGE_REPORTING_CAPACITY - offset; + leftover = prdev->capacity - offset; if (leftover) { sgl = &sgl[offset]; err = prdev->report(prdev, sgl, leftover); @@ -322,11 +322,11 @@ static void page_reporting_process(struct work_struct *work) atomic_set(&prdev->state, state); /* allocate scatterlist to store pages being reported on */ - sgl = kmalloc_objs(*sgl, PAGE_REPORTING_CAPACITY); + sgl = kmalloc_objs(*sgl, prdev->capacity); if (!sgl) goto err_out; - sg_init_table(sgl, PAGE_REPORTING_CAPACITY); + sg_init_table(sgl, prdev->capacity); for_each_zone(zone) { err = page_reporting_process_zone(prdev, sgl, zone); @@ -377,6 +377,9 @@ int page_reporting_register(struct page_reporting_dev_info *prdev) page_reporting_order = pageblock_order; } + if (!prdev->capacity || prdev->capacity > PAGE_REPORTING_CAPACITY) + prdev->capacity = PAGE_REPORTING_CAPACITY; + /* initialize state and work structures */ atomic_set(&prdev->state, PAGE_REPORTING_IDLE); INIT_DELAYED_WORK(&prdev->work, &page_reporting_process); -- MST