mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Joe Tessler <jrt@google.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Joshua Pius <joshuapius@google.com>
Subject: Re: [PATCH v2] media: cec: i2c: ch7322: Drop of_match_ptr
Date: Wed, 8 Mar 2023 10:21:00 -0800	[thread overview]
Message-ID: <776ddcd1-9f41-4b6e-882a-dc5e7abadc66@roeck-us.net> (raw)
In-Reply-To: <20230215214724.3798917-1-linux@roeck-us.net>

On Wed, Feb 15, 2023 at 01:47:24PM -0800, Guenter Roeck wrote:
> The driver does not instantiate on ACPI based systems if OF is disabled.
> Fix the problem by dropping of_match_ptr.
> 

This patch has still not been applied, so ... ping ...

Is there anything else I need to do to get it applied ?

Thanks,
Guenter

> Cc: Joshua Pius <joshuapius@google.com>
> Tested-by: Joshua Pius <joshuapius@google.com>
> Fixes: 21b9a47e0ec7 ("media: cec: i2c: ch7322: Add ch7322 CEC controller driver")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: Added Joshua's Tested-by: tag
> 
>  drivers/media/cec/i2c/ch7322.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c
> index 34fad7123704..3c6e6496a001 100644
> --- a/drivers/media/cec/i2c/ch7322.c
> +++ b/drivers/media/cec/i2c/ch7322.c
> @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
>  static struct i2c_driver ch7322_i2c_driver = {
>  	.driver = {
>  		.name = "ch7322",
> -		.of_match_table = of_match_ptr(ch7322_of_match),
> +		.of_match_table = ch7322_of_match,
>  	},
>  	.probe_new	= ch7322_probe,
>  	.remove		= ch7322_remove,
> -- 
> 2.39.1
> 

      parent reply	other threads:[~2023-03-08 18:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 21:47 Guenter Roeck
2023-02-16 17:22 ` Joe Tessler
2023-03-08 18:21 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=776ddcd1-9f41-4b6e-882a-dc5e7abadc66@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=joshuapius@google.com \
    --cc=jrt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®