From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933382AbdGKWby (ORCPT ); Tue, 11 Jul 2017 18:31:54 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:21698 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932857AbdGKWbw (ORCPT ); Tue, 11 Jul 2017 18:31:52 -0400 Subject: Re: [linux-next][PATCH] usb: dwc3: core: Call dwc3_core_get_phy() before initializing phys To: Felipe Balbi CC: Greg Kroah-Hartman , , , , Tony Lindgren , Carlos Hernandez References: <20170629052514.12560-1-vigneshr@ti.com> From: Vignesh R Message-ID: <7771d976-657a-064e-2cd4-5a6309929ee4@ti.com> Date: Tue, 11 Jul 2017 17:30:53 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170629052514.12560-1-vigneshr@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/29/2017 12:25 AM, Vignesh R wrote: > commit f54edb539c116 ("usb: dwc3: core: initialize ULPI before trying to > get the PHY") moved call to dwc3_core_get_phy() from dwc3_probe() to > dwc3_core_init() after dwc3_core_soft_reset(). But > dwc3_core_soft_reset() calls phy_init(), therefore dwc3_core_get_phy() > needs to be called before dwc3_core_soft_reset(). > > Fix this by moving call to dwc3_core_get_phy() before > dwc3_core_soft_reset(). > > This fixes the following abort seen on DRA7xx platforms > [ 24.769118] usb usb2: SerialNumber: xhci-hcd.1.auto > [ 24.781144] hub 2-0:1.0: USB hub found > [ 24.787836] hub 2-0:1.0: 1 port detected > [ 24.809939] Unhandled fault: imprecise external abort (0x1406) at 0x00000000 > > Reported-by: Carlos Hernandez > Signed-off-by: Vignesh R > --- Could this be picked up for -rc1, so that we have a booting kernel for dra7 platform? Or is this planned for -rc2? > drivers/usb/dwc3/core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 326b302fc440..03474d3575ab 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -766,15 +766,15 @@ static int dwc3_core_init(struct dwc3 *dwc) > dwc->maximum_speed = USB_SPEED_HIGH; > } > > - ret = dwc3_core_soft_reset(dwc); > + ret = dwc3_core_get_phy(dwc); > if (ret) > goto err0; > > - ret = dwc3_phy_setup(dwc); > + ret = dwc3_core_soft_reset(dwc); > if (ret) > goto err0; > > - ret = dwc3_core_get_phy(dwc); > + ret = dwc3_phy_setup(dwc); > if (ret) > goto err0; > >