From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752132AbaEBLxu (ORCPT ); Fri, 2 May 2014 07:53:50 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:62943 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751733AbaEBLxt (ORCPT ); Fri, 2 May 2014 07:53:49 -0400 From: "Rafael J. Wysocki" To: Baoquan He Cc: linux-kernel@vger.kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, jiang.liu@linux.intel.com, vgoyal@redhat.com Subject: Re: [Patch v2] lapic need be checked if available when initialize acpi processor id Date: Fri, 02 May 2014 14:10:22 +0200 Message-ID: <77730977.RNC3lGkZ0X@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.14.0-rc7+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20140502084707.GA1572@dhcp-17-102.nay.redhat.com> References: <1397519754-10205-1-git-send-email-bhe@redhat.com> <20009828.4TTRJo9T7a@vostro.rjw.lan> <20140502084707.GA1572@dhcp-17-102.nay.redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, May 02, 2014 04:51:46 PM Baoquan He wrote: > On 04/30/14 at 10:13pm, Rafael J. Wysocki wrote: > > On Wednesday, April 30, 2014 02:03:03 PM Baoquan He wrote: > > > Hi Rafael, > > > > Hi, > > > > > Thanks for previous review for v1. Later on I thought acpi_lapic is > > > more suitable for checking whether LAPIC in MADT is available, and it can > > > hanlde both the UP system running SMP kernel with no LAPIC in MADT and kdump > > > kernel after multiple CPUs system crashed on non-1st CPU. > > > > > > I tested the 1st case by addding "disableapic nr_cpus=1" into cmdline > > > of SMP kenrel, and it works. For 2nd case, it works too, below warning > > > message is not printed any more. > > > > > > acpi LNXCPU:0a: BIOS reported wrong ACPI id 0 for the processor > > > > > > Do you like this idea? > > > > Well, I don't hate it, but you need to make the code build in all > > configurations (including ia64). > > > Hi Rafael, > > Sorry about this, I didn't realize acpi_lapic is for x86 only. And ia64 > uses it too. About this bug, it should exist in ia64 too. After checking > code, introducing acpi_lapic into ia64 is a solution, I will try to find > a ia64 machine to test this though it's a little difficult, since people > around didn't test ia64 recently. > > Any suggestion or comment? The plan sounds good, thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.