From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932699AbbLNWXx (ORCPT ); Mon, 14 Dec 2015 17:23:53 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:59866 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753582AbbLNWXv (ORCPT ); Mon, 14 Dec 2015 17:23:51 -0500 From: Arnd Bergmann To: Ben Hutchings Cc: Greg Kroah-Hartman , Eric Andersson , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] misc/bmp085: Enable building as a module Date: Mon, 14 Dec 2015 23:23:45 +0100 Message-ID: <7776312.pmJpCBty6D@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151214142922.GM28542@decadent.org.uk> References: <20151214142922.GM28542@decadent.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:m5dJl44RzD+EM/XhnYX0XdcilNokgPdF+uqHjx/lfEOEAq/0u3h dkmkYaK4UBhV85G5+SSqx/1dhFUXjZrHoDpEgSHIeVHv5UBBTF1NnTnuPOKenW9RJ+VsUle mMGZzeZEJkB+s5DQhxMDxJxeizmWl7Mj0mUV6hlJfwLxaGXp4ELswJgdZmwf9QlK8ZL9U/T GtwXzwjoTwbpolmp03PRw== X-UI-Out-Filterresults: notjunk:1;V01:K0:LfLmFq7jZvg=:j+jSqcbG60sJTGvLlcTk5f dnjbsiYMIPSeu0KO3BVlq/fqDxoxuGAHKLTq2b4RzxFFsB/nmCa2GTvpR4uT7XyYMttWKRNeY qWGWbYozhl+mXTeZz8uucwfaibUfZBDVyjYg60vgmgq1UDuoz+qy5Poj/NfRMp8b59wHuF411 YR4bZfXfNqa+9wV88Vy/mVMI5YuvBRwEUksmxcaX3vfzCy8IrE5ZsC9ZI19EBqcpc3AKJT8K/ cA3acdQdak1fpH8QdQlqI1JEj/L89sMLEdH+kfDuhdJqA480yHWGTJ8Kyapo+0F4IwAsmpLKT fPaqcOJVZaw43UTmEQOGwSITv7BQvf9FGaXud0xjn5JqA3onMJCzFIsij8uSJyx7FuEGRLonx e1knN6S9vkGoWqHoF104ZHPGKgJhDtyRF6iMMnZpgD+3+Xsmc2nsnFTUd4Qkuiy6KCjbzaO4n BfzIecSx3h0zzrHyaWn4ea2h7YPOxMxX4ZmmyWnu01nYqSDTpBAsgIBhTMOmlhkaBtqwbhmeu 8VpU/xz0/ARwMPGEhiTBAcslmXnXPj/QHY5lMSCyJ1IRS5WRanxsHMMa8Uqdl7Q8fkGd/PTrb w6LHqrT9c5/WWJfrYGrc/kxJWk2LQGMLfPEuDIDZb39uBFRLPkzKLAhJ4eiEPYKVOYiNyWGKs 4vLYNfUIHxyh+2cp/99qJVWr4PHv1/+3M2q33gKwTwl0ZUv/+wa4pI0vp1OoKuQA03Bb++3oj J/s7tNQGqpA5Kst3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 14 December 2015 14:29:23 Ben Hutchings wrote: > Commit 985087dbcb02 'misc: add support for bmp18x chips to the bmp085 > driver' changed the BMP085 config symbol to a boolean. I see no > reason why the shared code cannot be built as a module, so change it > back to tristate. > > Fixes: 985087dbcb02 ("misc: add support for bmp18x chips to the bmp085 driver") > Cc: Eric Andersson > Signed-off-by: Ben Hutchings > Looks good to me. There are often subtle bugs in configurations like these where a driver can depend on either SPI or I2C, but I don't see a problem here, because the common code still only gets built as a module if neither front-end is built-in. Acked-by: Arnd Bergmann