From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D36E2C433E3 for ; Tue, 25 Aug 2020 16:48:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B01B820782 for ; Tue, 25 Aug 2020 16:48:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726306AbgHYQr6 (ORCPT ); Tue, 25 Aug 2020 12:47:58 -0400 Received: from smtprelay0188.hostedemail.com ([216.40.44.188]:41284 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725805AbgHYQr5 (ORCPT ); Tue, 25 Aug 2020 12:47:57 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id EE3E8837F24D; Tue, 25 Aug 2020 16:47:55 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: form08_42108202705d X-Filterd-Recvd-Size: 2494 Received: from XPS-9350 (unknown [172.58.35.126]) (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA; Tue, 25 Aug 2020 16:47:53 +0000 (UTC) Message-ID: <777e01f8dc9bd35e8b7bdf1b5181d0d13b86d8b9.camel@perches.com> Subject: Re: [PATCH] IB/qib: remove superfluous fallthrough statements From: Joe Perches To: "Gustavo A. R. Silva" , Alex Dewar Cc: Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , Roland Dreier , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 25 Aug 2020 09:47:50 -0700 In-Reply-To: References: <20200825155142.349651-1-alex.dewar90@gmail.com> <4877c3a5-365e-4500-43c0-4a4361e2cda3@embeddedor.com> <086ee29ef75f657dcf45e92d4ebfdf2b3f4fcab8.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-08-25 at 11:49 -0500, Gustavo A. R. Silva wrote: > > On 8/25/20 11:26, Joe Perches wrote: > > On Tue, 2020-08-25 at 11:19 -0500, Gustavo A. R. Silva wrote: > > > On 8/25/20 10:51, Alex Dewar wrote: > > > > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") > > > > erroneously marked a couple of switch cases as /* FALLTHROUGH */, which > > > > were later converted to fallthrough statements by commit df561f6688fe > > > > ("treewide: Use fallthrough pseudo-keyword"). This triggered a Coverity > > > > warning about unreachable code. > > > > > > > > Remove the fallthrough statements and replace the mass of gotos with > > > > simple return statements to make the code terser and less bug-prone. > > > > > > > > > > This should be split up into two separate patches: one to address the > > > fallthrough markings, and another one for the gotos. > > > > I don't think it's necessary to break this into multiple patches. > > Logical changes in a single patch are just fine, micro patches > > aren't that useful. > > > > There is a reason for this. Read the changelog text and review the patch. What makes you think I didn't already do that? I think your desire for micropatches is unnecessary.