From: Shuah Khan <skhan@linuxfoundation.org>
To: Greg KH <gregkh@linuxfoundation.org>,
Puranjay Mohan <puranjay12@gmail.com>
Cc: hch@infradead.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org,
"skh >> Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [Linux-kernel-mentees] [PATCH v2] fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem
Date: Tue, 18 Jun 2019 10:15:11 -0600 [thread overview]
Message-ID: <777ee79c-9371-956a-07df-be866796047b@linuxfoundation.org> (raw)
In-Reply-To: <20190618160847.GC27611@kroah.com>
On 6/18/19 10:08 AM, Greg KH wrote:
> On Tue, Jun 18, 2019 at 05:19:47PM +0530, Puranjay Mohan wrote:
>> Fix CRAMFS_BLK_FLAG_UNCOMPRESSED to use "U" cast to avoid shifting signed
>> 32-bit value by 31 bits problem. This isn't a problem for kernel builds
>> with gcc.
>>
>> This could be problem since this header is part of public API which
>> could be included for builds using compilers that don't handle this
>> condition safely resulting in undefined behavior.
>>
>> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> You should resend this and cc: Nicolas Pitre <nico@fluxnic.net> as he is
> the cramfs maintainer.
>
Puranjay! You can add all the Reviewed-by tags when you resend the patch
with Nicolas Pitre <nico@fluxnic.net> on the thread.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
next prev parent reply other threads:[~2019-06-18 16:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 11:49 Puranjay Mohan
2019-06-18 12:07 ` Christoph Hellwig
2019-06-18 16:08 ` [Linux-kernel-mentees] " Greg KH
2019-06-18 16:15 ` Shuah Khan [this message]
2019-06-18 16:38 ` Puranjay Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=777ee79c-9371-956a-07df-be866796047b@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puranjay12@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®