From: Johannes Thumshirn <jthumshirn@suse.de>
To: John Garry <john.garry@huawei.com>,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com
Cc: linuxarm@huawei.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org,
Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity
Date: Thu, 6 Dec 2018 17:20:34 +0100 [thread overview]
Message-ID: <778770d5-b377-2aaa-c2a0-9c548de74f17@suse.de> (raw)
In-Reply-To: <2da87e22-1bbc-aff9-c0be-85a3fd8f4393@huawei.com>
On 06/12/2018 16:37, John Garry wrote:
> which is important. Let me know if you disagree and I can change it.
Sure, it's your driver. It was just because the patch is even titled
"Relocate some code to reduce complexity", so I thought of reducing the
complexity for readers even further (like you don't need the line wrap
at 80 chars, and so on).
Byte,
Johannes
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2018-12-06 16:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 13:34 [PATCH v4 0/5] hisi_sas: DIF support John Garry
2018-12-06 13:34 ` [PATCH v4 1/5] scsi: hisi_sas: Fix warnings detected by sparse John Garry
2018-12-06 13:34 ` [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity John Garry
2018-12-06 14:17 ` Johannes Thumshirn
2018-12-06 15:37 ` John Garry
2018-12-06 16:20 ` Johannes Thumshirn [this message]
2018-12-07 10:07 ` John Garry
2018-12-07 10:53 ` Johannes Thumshirn
2018-12-06 13:34 ` [PATCH v4 3/5] scsi: hisi_sas: Make sg_tablesize consistent value John Garry
2018-12-06 13:34 ` [PATCH v4 4/5] scsi: hisi_sas: Add support for DIF feature for v3 hw John Garry
2018-12-13 2:20 ` Martin K. Petersen
2018-12-13 13:35 ` John Garry
2018-12-17 14:51 ` John Garry
2018-12-18 3:31 ` Martin K. Petersen
2018-12-06 13:34 ` [RFC PATCH v4 5/5] scsi: hisi_sas: Add support for DIX feature for v3 hw as experimental John Garry
2018-12-13 2:23 ` [PATCH v4 0/5] hisi_sas: DIF support Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=778770d5-b377-2aaa-c2a0-9c548de74f17@suse.de \
--to=jthumshirn@suse.de \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome