From: Sander Vanheule <sander@svanheule.net>
To: linux-gpio@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, Bert Vermeulen <bert@biot.com>,
Sander Vanheule <sander@svanheule.net>
Subject: [PATCH v1 1/2] gpio: realtek-otto: amend ctrl struct docs
Date: Fri, 22 Jul 2022 10:19:16 +0200 [thread overview]
Message-ID: <778b5c9f05c42c0963a5eca1c1c7e58b588a4bc7.1658477809.git.sander@svanheule.net> (raw)
In-Reply-To: <cover.1658477809.git.sander@svanheule.net>
Commit 512c5be35223 ("gpio: realtek-otto: Support reversed port
layouts") and commit 95fa6dbe58f2 ("gpio: realtek-otto: Support per-cpu
interrupts") updated the realtek_gpio_ctrl struct with new fields, but
the associated kernel-doc comment was not updated accordingly.
Signed-off-by: Sander Vanheule <sander@svanheule.net>
---
drivers/gpio/gpio-realtek-otto.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realtek-otto.c
index 63dcf42f7c20..a352fbfc3c28 100644
--- a/drivers/gpio/gpio-realtek-otto.c
+++ b/drivers/gpio/gpio-realtek-otto.c
@@ -43,9 +43,19 @@
*
* @gc: Associated gpio_chip instance
* @base: Base address of the register block for a GPIO bank
+ * @cpumask_base: Base address of the interrupt routing registers
+ * @cpu_irq_maskable: Mask of CPUs that can be individually masked for IRQs
* @lock: Lock for accessing the IRQ registers and values
* @intr_mask: Mask for interrupts lines
* @intr_type: Interrupt type selection
+ * @port_offset_u8: Get offset of an 8b port value
+ * @port_offset_u16: Get offset of a 16b port value
+ *
+ * The DIR, DATA, and ISR registers consist of four u8 port values, packed into
+ * a single 32b register. Use @port_offset_u8 to get the correct offset inside
+ * that register. The IMR register consists of four u16 port values, packed
+ * into two 32b registers. Use @port_offset_u16 to get the correct offset for
+ * the u16 value, starting from the first register.
*
* Because the interrupt mask register (IMR) combines the function of IRQ type
* selection and masking, two extra values are stored. @intr_mask is used to
--
2.36.1
next prev parent reply other threads:[~2022-07-22 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 8:19 [PATCH v1 0/2] gpio: update Realtek Otto documenentation Sander Vanheule
2022-07-22 8:19 ` Sander Vanheule [this message]
2022-07-23 9:52 ` [PATCH v1 1/2] gpio: realtek-otto: amend ctrl struct docs Sander Vanheule
2022-07-22 8:19 ` [PATCH v1 2/2] MAINTAINERS: add info for Realtek Otto GPIO Sander Vanheule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=778b5c9f05c42c0963a5eca1c1c7e58b588a4bc7.1658477809.git.sander@svanheule.net \
--to=sander@svanheule.net \
--cc=bert@biot.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®