From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755271AbaITMIl (ORCPT ); Sat, 20 Sep 2014 08:08:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56336 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754082AbaITMIj (ORCPT ); Sat, 20 Sep 2014 08:08:39 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <32370.1410886755@warthog.procyon.org.uk> To: James Morris Cc: dhowells@redhat.com, keyrings@linux-nfs.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] KEYS: Changes for keyrings for security/next MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <7791.1411214905.1@warthog.procyon.org.uk> Date: Sat, 20 Sep 2014 13:08:25 +0100 Message-ID: <7792.1411214905@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org James Morris wrote: > I'm getting this warning after pulling your code: > > CC crypto/hash_info.o > crypto/asymmetric_keys/asymmetric_type.c: In function > asymmetric_key_hex_to_key_id: > crypto/asymmetric_keys/asymmetric_type.c:110: warning: ignoring return > value of hex2bin, declared with attribute warn_unused_result I don't see that with my compiler for some reason. I'm not sure what to do about it even so. I don't need to check the result of hex2bin because I've done all the checks required before allocating the buffer for hex2bin to write into. I could remove the attribute from hex2bin(), I suppose. David