mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Luca Leonardo Scorcia <l.scorcia@gmail.com>,
	linux-mediatek@lists.infradead.org
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	CK Hu <ck.hu@mediatek.com>, Jitao shi <jitao.shi@mediatek.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/4] arm64: dts: mediatek: mt8167: Add DRM nodes
Date: Wed, 18 Nov 2026 12:10:47 +0100	[thread overview]
Message-ID: <779efc61-646d-4735-b54d-7bc7436385bd@collabora.com> (raw)
In-Reply-To: <94ed1340-94bd-49ee-ba31-9bb63164c89a@kernel.org>

On 11/17/26 17:00, Krzysztof Kozlowski wrote:
> On 17/11/2026 15:21, AngeloGioacchino Del Regno wrote:
>>
>>>>
>>>> Any advice on how to possibly resolve this without rewriting the entire thing?
>>>>
>>>> Mapping that by mmio address in the driver seems too stupid/dirty/bad/etc.
>>>
>>> Driver needs that, so why exactly stupid?
>>
>> Really feels like going back to the days when devicetree was not a thing and all of
>> the MMIOs (on ARM at least) were added into a mach file.
> 
> Well, adding an alias just to tell that device node with MMIO address
> 0xdeadbeef is ID 0 is very similar, just placed differently. The
> "aliases" are the mapping between MMIO and ID. Driver code also can do
> the mapping between MMIO and ID.
> 
>>
>>   >
>>> You do not represent any
>>> actual hardware information in DT with these aliases.
>>
>> That depends on how you see it (as in, on the point of view), really, because well
>> technically the second ReadDMA IP is ... not the ... primary, as it's the secondary
>> one - as much as the third DPI is not the primary one (even though DRM can make it
>> so that it can be used as a primary output, but that's a software thing, not HW).
>>
>> So... well, with that point of view... those aliases *are* representing information
>> about the hardware.
>>
>> But I know that you're not complaining just about this, and this reply is not a way
>> to argue all that much, just a bit of thinking out loud.
> 
> Being simply "second" is not alone useful information. It's pointless,
> it does not matter neither to hardware nor to drivers.

Hmm... Sorry, but I disagree about this statement - it does matter in some cases.

The driver's POV is of course out of context here, as we're talking about DT//HW.

(I know that you know, this is to avoid misunderstanding from anyone else reading
this thread).

> If it matters,
> then probably that "second" has some other meaning and it maps to an
> actual hardware topology difference, then often it deserves its own
> compatible or property, depending on the difference.
> 

This is a bit more complicated than that: "second" may or may not have another
meaning, as in, it may or may not be topologically different in the whole context
of the controller.

Having different compatibles wouldn't do either, because having 10 compats for one
IP which is 99.9% compatible if not for very very very very (add as many "very" as
you wish here) small details that definitely don't deserve a new compatible... and
besides, a driver parsing more than 90 compatible strings would be... how can I
express that in professional words? :-)))

>>
>>   >
>>> You want to tell
>>> drivers how drivers should behave - that's not a job for DT,
>>
>> I want to tell drivers what is the first or the second or the third hardware
>> instance of the same IP, I don't want to tell drivers how drivers should behave
>> from devicetree.
>> The drivers are behaving differently with different hardware (read as: hardware
>> that is *physically* located in front of something else, or somewhere else anyway)
>> as in with different hardware instances.
> 
> Then alias is not the way to represent these differences.
> 

Are we opening a can of worms here?

There are a bunch of (generic, yes, and I think acceptable-because-generic, right?)
aliases for other devices like UART, I2C, SPI, etc which instance is actually
represented by an alias - and this is *not* for HW, but rather for drivers' device
node number consistency in the userspace (of course not just MTK, but all of them).

That makes things a bit weird then when we assert that devicetree describes the HW
and, compared to what we're analyzing in this specific MediaTek case (which does in
a way describe hardware, as in hw instance number), the LS busses aliases are just
software details in an inappropriate place (DT) at this point?

I wonder if there's anything that can be done for that case, because then now I'm
kind of sensing that there's something else that is fundamentally wrong and that
1. Leads to confusion (not in experienced people usually, but not granted)
2. May actually help resolving situations that are similar to this one

I'm well aware that whatever comes out of this won't be for this round, nor for the
next one, but rather something that may eventually take (a lot of) time to assess
and address, but still.

Mind you - I keep thinking out loud - but I believe sometimes this is what makes
good (hopefully) ideas come to mind.

>>
>>> that's job
>>> for driver data. Of course if there is smarter way than MMIO->ID, I am
>>> all in.
>>
>> You can't imagine how much I was hoping for you to say something about an
>> alternative solution to that.
>>
>> As I said, it feels a bit like pre-DT times, but what I get from you is that this
>> is cleaner than just adding information about the real hardware instance number in
>> devicetree (no that's not just MediaTek, qcom also had similar issues as you said).
> 
> Sure, I understand. This is an workaround and might be less applicable
> here. It might be possible that your hardware needs a dedicated
> property.

I didn't check the others - but from what I remember, Qualcomm also has this kind
of workaround somewhere (in some driver[s]) - so that pushes the count to two
vendors, let alone the number of SoCs affected which is .. well, more than two :-)

I wonder if someone (unfortunately not me or at least not in the next 6 months)
should do ... well, something ... to fix this situation in a good way.

Adding the same workaround to MediaTek would make the argument stronger when that
someone actually gets to resolving this situation somehow.

> Unfortunately, this cannot be a custom per-device alias.
> 

I will come up with some way (right now, I have no idea how) to get this situation
addressed in MediaTek DRM, maybe it's going to be that MMIO address workaround, or
maybe not, let's see what I can do here.

Surely though, either way, that's not good news - not just because it's going to
slow down the upstreaming by a whole lot - but mostly because it's all about
adding one more workaround for something that is "left in the future-decisions-box"
in the kernel.

Having to do this makes me sad, and this is mostly because I have no other choice.

I'm sure you know what I mean here, so I won't add any more words to this already
long reply.

P.S.: Luca, you don't need to add the aliases to your SoC, because there's only one
instance of the display controller IPs that you're adding; for DSI1/2 DPI1/2 and
those final outputs, I guess just leave them out for now and add just the first....

Cheers,
Angelo

      reply	other threads:[~2026-11-18 11:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 11:38 [PATCH v2 0/4] Add support for the mt8167 display pipeline Luca Leonardo Scorcia
2026-09-21 11:38 ` [PATCH v2 1/4] dt-bindings: display: mediatek: dpi: Add compatible for mt8167 Luca Leonardo Scorcia
2026-09-25 13:24   ` Krzysztof Kozlowski
2026-11-17 12:52     ` Krzysztof Kozlowski
2026-11-16 15:01   ` Chun-Kuang Hu
2026-11-17 12:52   ` Krzysztof Kozlowski
2026-11-17 13:26     ` Luca Leonardo Scorcia
2026-11-17 15:09       ` Krzysztof Kozlowski
2026-11-17 19:11         ` Luca Leonardo Scorcia
2026-09-21 11:38 ` [PATCH v2 2/4] drm/mediatek: Add support for mt8167 Digital Parallel Interface Luca Leonardo Scorcia
2026-11-16 15:05   ` Chun-Kuang Hu
2026-09-21 11:38 ` [PATCH v2 3/4] soc: mediatek: mt8167-mmsys: add routes for all display paths Luca Leonardo Scorcia
2026-09-21 11:38 ` [PATCH v2 4/4] arm64: dts: mediatek: mt8167: Add DRM nodes Luca Leonardo Scorcia
2026-11-17 12:35   ` Krzysztof Kozlowski
2026-11-17 12:53     ` AngeloGioacchino Del Regno
2026-11-17 12:55       ` Krzysztof Kozlowski
2026-11-17 13:00         ` AngeloGioacchino Del Regno
2026-11-17 13:12           ` Krzysztof Kozlowski
2026-11-17 14:21             ` AngeloGioacchino Del Regno
2026-11-17 16:00               ` Krzysztof Kozlowski
2026-11-18 11:10                 ` AngeloGioacchino Del Regno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=779efc61-646d-4735-b54d-7bc7436385bd@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=airlied@gmail.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=ck.hu@mediatek.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jitao.shi@mediatek.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=l.scorcia@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®