From: Gerhard Wiesinger <lists@wiesinger.com>
To: Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Cc: linux-kernel@vger.kernel.org
Subject: Re: B53 DSA switch problem on Banana Pi-R1 on Fedora 26
Date: Wed, 23 May 2018 19:35:33 +0200 [thread overview]
Message-ID: <779f2be3-3e74-e650-5240-efaf1003d77c@wiesinger.com> (raw)
In-Reply-To: <76c3f5ec-0ab2-c06d-98e8-277284bb1a8e@gmail.com>
On 23.05.2018 17:28, Florian Fainelli wrote:
>
>> And in the future (time plan)?
> If you don't care about multicast then you can use those patches:
>
> https://github.com/ffainelli/linux/commit/de055bf5f34e9806463ab2793e0852f5dfc380df
>
> and you have to change the part of drivers/net/dsa/b53/b53_common.c that
> returns DSA_TAG_PROTO_NONE for 53125:
>
>
> diff --git a/drivers/net/dsa/b53/b53_common.c
> b/drivers/net/dsa/b53/b53_common.c
> index 9f561fe505cb..3c64f026a8ce 100644
> --- a/drivers/net/dsa/b53/b53_common.c
> +++ b/drivers/net/dsa/b53/b53_common.c
> @@ -1557,7 +1557,7 @@ enum dsa_tag_protocol b53_get_tag_protocol(struct
> dsa_switch *ds, int port)
> * mode to be turned on which means we need to specifically
> manage ARL
> * misses on multicast addresses (TBD).
> */
> - if (is5325(dev) || is5365(dev) || is539x(dev) || is531x5(dev) ||
> + if (is5325(dev) || is5365(dev) || is539x(dev) ||
> !b53_can_enable_brcm_tags(ds, port))
> return DSA_TAG_PROTO_NONE;
>
>
> That would bring Broadcom tags to the 53125 switch and you would be able
> to use the configuration lines from Andrew in that case.
What's the plan here regarding these 2 config option mode (how do you
call them?)?
I mean, will this be a breaking change in the future where config has to
be done in a different way then?
Or will it be configurable via module parameters or /proc or /sys
filesystem options?
Thank you.
Ciao,
Gerhard
next prev parent reply other threads:[~2018-05-23 17:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 19:11 Gerhard Wiesinger
2018-05-22 19:15 ` Florian Fainelli
2018-05-22 20:16 ` Andrew Lunn
2018-05-22 20:42 ` Florian Fainelli
2018-05-22 21:02 ` Andrew Lunn
2018-05-23 4:49 ` Gerhard Wiesinger
2018-05-23 15:28 ` Florian Fainelli
2018-05-23 15:50 ` Florian Fainelli
2018-05-23 17:29 ` Gerhard Wiesinger
2018-05-23 17:47 ` Florian Fainelli
2018-05-23 18:11 ` Gerhard Wiesinger
2018-05-23 18:21 ` Florian Fainelli
2018-05-23 17:35 ` Gerhard Wiesinger [this message]
2018-05-23 17:55 ` Florian Fainelli
2018-05-23 18:27 ` Gerhard Wiesinger
2018-05-23 18:54 ` Florian Fainelli
2018-05-24 5:29 ` Gerhard Wiesinger
2018-05-24 6:22 ` Gerhard Wiesinger
2018-05-27 19:01 ` B53 DSA switch problem on Banana Pi-R1 on Fedora 26 - systemd-networkd problem Gerhard Wiesinger
2018-05-27 19:18 ` Gerhard Wiesinger
2018-05-27 20:35 ` Florian Fainelli
2018-05-28 5:24 ` Gerhard Wiesinger
2018-05-27 20:31 ` Florian Fainelli
2018-05-28 5:32 ` Gerhard Wiesinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=779f2be3-3e74-e650-5240-efaf1003d77c@wiesinger.com \
--to=lists@wiesinger.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®