From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbdJ0JUe convert rfc822-to-8bit (ORCPT ); Fri, 27 Oct 2017 05:20:34 -0400 Received: from mga06.intel.com ([134.134.136.31]:26285 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbdJ0JUd (ORCPT ); Fri, 27 Oct 2017 05:20:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,304,1505804400"; d="scan'208";a="165680360" From: "Dilger, Andreas" To: NeilBrown CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "lustre-devel@lists.lustre.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 5/9] staging: lustre: ldlm: remove unused 'overlaps' variable Thread-Topic: [PATCH 5/9] staging: lustre: ldlm: remove unused 'overlaps' variable Thread-Index: AQHTS5mkYeBJNQvfWUu71lwanNHYe6L3588A Date: Fri, 27 Oct 2017 09:20:31 +0000 Message-ID: <77ADF410-2FBC-4F06-B5C5-275EE18D703D@intel.com> References: <150871988297.3340.4522589460981284121.stgit@noble> <150872002972.3340.9372825368625571993.stgit@noble> In-Reply-To: <150872002972.3340.9372825368625571993.stgit@noble> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.7.56] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct 22, 2017, at 18:53, NeilBrown wrote: > > 'overlaps' is never used, only incremented. > > Signed-off-by: NeilBrown Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > index 2d1fa2b33129..d5a5742a1171 100644 > --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > @@ -133,7 +133,6 @@ static int ldlm_process_flock_lock(struct ldlm_lock *req) > struct ldlm_lock *new2 = NULL; > enum ldlm_mode mode = req->l_req_mode; > int added = (mode == LCK_NL); > - int overlaps = 0; > int splitted = 0; > const struct ldlm_callback_suite null_cbs = { }; > > @@ -226,8 +225,6 @@ static int ldlm_process_flock_lock(struct ldlm_lock *req) > lock->l_policy_data.l_flock.start) > break; > > - ++overlaps; > - > if (new->l_policy_data.l_flock.start <= > lock->l_policy_data.l_flock.start) { > if (new->l_policy_data.l_flock.end < > > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation