mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Bae, Chang Seok" <chang.seok.bae@intel.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Peter Zijlstra <peterz@infradead.org>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Andi Kleen <ak@linux.intel.com>,
	"Shankar, Ravi V" <ravi.v.shankar@intel.com>
Subject: Re: [PATCH] selftests/x86/fsgsbase: Fix some test case bugs
Date: Wed, 3 Jul 2019 00:20:49 +0000	[thread overview]
Message-ID: <77F4123B-C10E-4EC0-AD2B-F7F3223BA3BA@intel.com> (raw)
In-Reply-To: <46e6a60f8992fd54da12203e820c35daadaeffb5.1562103506.git.luto@kernel.org>


> On Jul 2, 2019, at 14:38, Andy Lutomirski <luto@kernel.org> wrote:
> 
> @@ -494,16 +489,24 @@ static void test_ptrace_write_gsbase(void)
> 		 * selector value is changed or not by the GSBASE write in
> 		 * a ptracer.
> 		 */
> -		if (gs != 0x7) {
> +		if (gs != *shared_scratch) {
> 			nerrs++;
> 			printf("[FAIL]\tGS changed to %lx\n", gs);

There is one more point to be fixed like this.
So, this diff also needs to be applied:

diff --git a/tools/testing/selftests/x86/fsgsbase.c b/tools/testing/selftests/x86/fsgsbase.c
index de8c80a..c9da4c5 100644
--- a/tools/testing/selftests/x86/fsgsbase.c
+++ b/tools/testing/selftests/x86/fsgsbase.c
@@ -472,7 +472,7 @@ static void test_ptrace_write_gsbase(void)
 
                gs = ptrace(PTRACE_PEEKUSER, child, gs_offset, NULL);
 
-               if (gs != 0x7) {
+               if (gs != *shared_scratch) {
                        nerrs++;
                        printf("[FAIL]\tGS is not prepared with nonzero\n");
                        goto END;

Thanks for the cleanup & the fix!

      reply	other threads:[~2019-07-03  0:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 21:38 Andy Lutomirski
2019-07-03  0:20 ` Bae, Chang Seok [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77F4123B-C10E-4EC0-AD2B-F7F3223BA3BA@intel.com \
    --to=chang.seok.bae@intel.com \
    --cc=ak@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®