From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939065AbdLSKd2 (ORCPT ); Tue, 19 Dec 2017 05:33:28 -0500 Received: from hr2.samba.org ([144.76.82.148]:25382 "EHLO hr2.samba.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933863AbdLSKdW (ORCPT ); Tue, 19 Dec 2017 05:33:22 -0500 Subject: Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m To: Arnd Bergmann , Steve French Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Pavel Shilovsky , Jean Delvare References: <20171219101327.2165797-1-arnd@arndb.de> From: Stefan Metzmacher Openpgp: id=A3D192CE44EF412517BCED646A739B025C6B98D4 Message-ID: <77af1425-2d5a-8482-fa39-c83d2056eaa4@samba.org> Date: Tue, 19 Dec 2017 11:33:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171219101327.2165797-1-arnd@arndb.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uBxkqfia3vOjSQ0Fbb4tuuRBCj96OsrJD" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uBxkqfia3vOjSQ0Fbb4tuuRBCj96OsrJD Content-Type: multipart/mixed; boundary="N8PxT8IdT7IHhkS8xWlEI4hSm87OPDl4g"; protected-headers="v1" From: Stefan Metzmacher To: Arnd Bergmann , Steve French Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Pavel Shilovsky , Jean Delvare Message-ID: <77af1425-2d5a-8482-fa39-c83d2056eaa4@samba.org> Subject: Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m References: <20171219101327.2165797-1-arnd@arndb.de> In-Reply-To: <20171219101327.2165797-1-arnd@arndb.de> --N8PxT8IdT7IHhkS8xWlEI4hSm87OPDl4g Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Arnd, > diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig > index 500fd69fb58b..3bfc55c08bef 100644 > --- a/fs/cifs/Kconfig > +++ b/fs/cifs/Kconfig > @@ -199,6 +199,7 @@ config CIFS_SMB311 > config CIFS_SMB_DIRECT > bool "SMB Direct support (Experimental)" > depends on CIFS && INFINIBAND > + depends on CIFS=3Dm || INFINIBAND=3Dy > help > Enables SMB Direct experimental support for SMB 3.0, 3.02 and 3.1.1= =2E > SMB Direct allows transferring SMB packets over RDMA. If unsure, Is this really correct? Should CIFS_SMB_DIRECT be allowed with: CIFS=3Dn and INFINIBAND=3Dy ??? or CIFS=3Dm and INFINIBAND=3Dn ??? I guess a more complex logic should be used here or am I missing something? metze --N8PxT8IdT7IHhkS8xWlEI4hSm87OPDl4g-- --uBxkqfia3vOjSQ0Fbb4tuuRBCj96OsrJD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJaOOruAAoJEA219WEoab1WbKoP/2uVjTaKRlY7dwwb2TBTH0uR qVvQ9fhyrHsuC/9ftshZibmxLQ3orKTF1N6s5d0sPg9cj0vZlSNuzg9Z356DCkUy k9+FigMAAe1n/yt5BNfV56ss8xDuroW7AtoEq9E26n6w4w0wGN8WzdSO6gp5KslW Xs71OJS7dU5Obkxi3M6Oc0rvYBEoxz0EeknHAmcr0JHWRZEAVTTR7g5SDFSqPlzk TMYYXH77qoTbk4+2+8i1CKsXw/L/Hifbttk1QPZm0W8FZ0dmXnGSN4udhAgSkPfe g5KVle29JnHTHOYk18ct6k4nZh3p6ZmsZz199Bal55HlELNIWuRYSYoyB6F/7GV/ 6YzEEoGzMRekXqYiQWo1YZAvv7aI+dg8OUOoW/kFH5ilZ4b7kIXcfDGi1b1ysDwr yj3wAwcLmAbBeq2e82bNRGvFPFGqCue/CkTXmZdRERpeSvl32iJVqRWR+8iF4JFp MtItWltJ98fK21S/XPtlg+r+QoYnjuAF8FjRveJXAR/V83gp+rzLzr3CyihTe6H3 oVRyrOtlo4BX2r7sonS9fADA/cgI/v1Twopu8WvgtNivGHFB4oFZZJHOULHvW6iw 9FUSZohFeqe50Jv0h4/cCagT5ziadPa4BeqEodSfprdJWa8OV3vuHsiCpDTM1ZFu 0546vGJiDwx6LbNNfk9F =IA+/ -----END PGP SIGNATURE----- --uBxkqfia3vOjSQ0Fbb4tuuRBCj96OsrJD--