From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753055AbeCOTPW (ORCPT ); Thu, 15 Mar 2018 15:15:22 -0400 Received: from vern.gendns.com ([206.190.152.46]:38674 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752912AbeCOTPT (ORCPT ); Thu, 15 Mar 2018 15:15:19 -0400 Subject: Re: [PATCH] ARM: davinci: DA8XX: fix oops in USB PHY driver due to stack allocated platform platform_data To: linux-arm-kernel@lists.infradead.org Cc: Sekhar Nori , Kevin Hilman , Bartosz Golaszewski , linux-kernel@vger.kernel.org References: <1521136976-32730-1-git-send-email-david@lechnology.com> From: David Lechner Message-ID: <77b0430f-3606-7195-6cde-eb90fc00c3fd@lechnology.com> Date: Thu, 15 Mar 2018 14:14:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1521136976-32730-1-git-send-email-david@lechnology.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/15/2018 01:02 PM, David Lechner wrote: > This fixes a possible kernel oops due to using stack allocated platform > data for the USB PHY driver on DA8XX devices. If the platform device > probe is deferred, then we get a corrupt pointer for the platform data. > > We now use a global static struct for the platform data so that the > platform data pointer does not get written over. > > Tested on OMAP-L138 LCDK board using legacy board file. > > Fixes: 9b504750923cb ("ARM: davinci: da8xx: Add USB PHY platform device") > Signed-off-by: David Lechner > --- superseded by v2 that applies cleanly before common clock series