From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: Vitaliy Sochnev <sochnev.v.74@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] thermal/drivers/airoha: Serialise access to the shared ADC
Date: Tue, 29 Sep 2026 18:06:01 +0200 [thread overview]
Message-ID: <77b27663-c248-448c-848d-308d774dd413@oss.qualcomm.com> (raw)
In-Reply-To: <20260929160356.38468-1-sochnev.v.74@gmail.com>
On 9/29/26 18:03, Vitaliy Sochnev wrote:
> On 9/29/26 09:53, Daniel Lezcano wrote:
>> On 9/15/26 21:11, Vitaliy Sochnev wrote:
>>> Serialise the sequence, drop the cache, check the selection after
>>> writing and after sampling, and return -EAGAIN if it does not hold.
>>>
>>> Signed-off-by: Vitaliy Sochnev <sochnev.v.74@gmail.com>
>>> ---
>>
>> Should this have a Fixes: tag?
>
> No. Before this series each device registers a single zone, and
> thermal_zone_get_temp() serialises reads under the zone lock, so the
> current driver never reads the ADC concurrently. The race appears with
> patch 4/4, which registers a zone per sensor; this patch prepares for it.
>
> I can state that in the commit message in v3 if you prefer.
Yes, thanks
next prev parent reply other threads:[~2026-09-29 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 19:11 [PATCH v2 0/4] thermal/drivers/airoha: Fix AN7583 mux mapping and expose all sensors Vitaliy Sochnev
2026-09-15 19:11 ` [PATCH v2 1/4] thermal/drivers/airoha: Fix AN7583 ADC mux field mapping Vitaliy Sochnev
2026-09-15 19:11 ` [PATCH v2 2/4] thermal/drivers/airoha: Serialise access to the shared ADC Vitaliy Sochnev
2026-09-29 8:53 ` Daniel Lezcano
2026-09-29 16:03 ` Vitaliy Sochnev
2026-09-29 16:06 ` Daniel Lezcano [this message]
2026-09-15 19:11 ` [PATCH v2 3/4] dt-bindings: arm: airoha: Use one thermal sensor cell for AN7583 Vitaliy Sochnev
2026-09-24 15:34 ` Rob Herring (Arm)
2026-09-15 19:11 ` [PATCH v2 4/4] thermal/drivers/airoha: Register a thermal zone per AN7583 sensor Vitaliy Sochnev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77b27663-c248-448c-848d-308d774dd413@oss.qualcomm.com \
--to=daniel.lezcano@oss.qualcomm.com \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sochnev.v.74@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®