From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1689360ECC for ; Tue, 23 Jun 2026 10:16:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782209801; cv=none; b=OyFb1/1fejyK5HhkGm6uoN4mbDgHq+RRgoPujSW9s8lcrAdOW84tgZMliWx/1nqTEAMAR5jNxB6omQg6XntDUt9AtLz42T7jQHGVX7EK9n/PzpX4XnnPz2IoFuqM3PhNTNl1qnkSGI17JZxpikMWtT3fj0CK/AIhrsl/E2vXTUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782209801; c=relaxed/simple; bh=YfkPpJdkXtBaCEdQjIlmALxfYu1fB7qBe/0FwrNjx0A=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=GXsJ0DwQuWy1rVABLTwMlNFpwgkicOfOWpj8uNG+RK/eiTi0YwxBwICXSE9PSOfuqFZYhes7Y2w/P3faB6dhCj8Nj66A60FdQe5qYZkGp394R0Mjq4xiiHrRmjuGLOV4/RgtaJfurOicXpPdKZ9IyFhWNgeK2kZ7oas43/sfEYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BsETbVzJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Hapd5/G9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BsETbVzJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Hapd5/G9" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N8Uujd3243418 for ; Tue, 23 Jun 2026 10:16:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HqFO2jtpsh6YeyYzgjlFbm8KV7gItqZG0Xm+6T/v/8Y=; b=BsETbVzJx04LEHt8 xxQCkONflN3uYOXbeXuKG0nDH46bulJe0rBTF2evoQ4cJH6OYggJBmkzzNuij3x5 ynWn4E0i51Aj5n1hFhMPTiQdrMWJdzPHmcvPNMKDO5ylcjSXFRfpTgl8D1EtO6SF SF9T173jXrK1xI6Wv4IeTVyKPyNqE3C+iCtFDUZbG4YPOragWTTbaHjImZrrA0y+ hyUyc6fSvaqZazjW/Ka2HrPUkwG3wClIlar9CKO7J3NOWqT07aMmsi4MToZU+uZY jsOELzYN3ZnKUdTQHOE464+54tklSINHkekFvN2IZlj3K5DyonYsB4g1mqT1Ee9w 0Rzyew== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyppygfvr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 10:16:38 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-915ccc2d4d2so105271485a.1 for ; Tue, 23 Jun 2026 03:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782209798; x=1782814598; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=HqFO2jtpsh6YeyYzgjlFbm8KV7gItqZG0Xm+6T/v/8Y=; b=Hapd5/G9p6aZWe98864jKwV4HsT284mxKPxoGeXlvdblPPZU6PW/+J7efuwYnorKnL HTKUljxY9xFCQzwIN9M9QUNc4jmL0OlqlANdg5miZkVTrUsV+/pXOGpj2njlvXXrV0y5 daIG2S/ruBn2uCnWScg5BtjM0WfGPKZ1U7z8oElC8na0V57ggP0t1Mx760WPj/XKG8a3 TBKBcJNWMu41ExwZ7M5d6tx54n6nQq1lhDwkQmJUYwrCTH6JQE94Qj/swPL+kDo8KKSe vjQrRic/QsTNpID7dqtQzX8HuGPh4sHcY2kBVZuybKScZuGv1HCQsEy+alkxiOpOKawM zChA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782209798; x=1782814598; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HqFO2jtpsh6YeyYzgjlFbm8KV7gItqZG0Xm+6T/v/8Y=; b=PkUejD3uAn+c6Vr3PK9ZIgvm0HdikIzMyevZBLLtVw0l9QWczWC5l+650LOrZt/+9K 1MRhT8na376cWUlIOwchjtfzU3eNb9hRX+4C6t4zMJxMWpTUIXlsE8XAkMJMhdmXqbmq B1H9bfVwLFiOzqm7qyWtuWXKyUii5r6Vd78wCCek9VM9BpM6IE8Z3vdqOH7viB/uazCr ZvYwGNO9b7UJ5GbpL8kGQFKwQAqEP5t5vW73BLIK4wlmKtsdvABm9yrRZnqjpPBK4Llr kNaDlPpWk3Xk/mV4fURUrnaE/lCy/8SliCqwrZDaY1zrAv0dBXNU66Vx/RvB9vtYO1S6 sEFg== X-Forwarded-Encrypted: i=1; AFNElJ9vJ8UoAwSVmvt0HYv0qP04Hqw6iDkuPewNcrGS6jRKe3pvxeTk2L6QFQsLdrtumNL5xYxWTPrW4RNlK/A=@vger.kernel.org X-Gm-Message-State: AOJu0YyLKksyOWnWXnpKq+RlZYdHQxAP2ZQ6aQfqoxPGfS8cOPltSTMm cySCV8qQc3U56BxZTMGecuMDtsPfuNH3VrU/DxuJ5lY+79NLgP2WAQDm2jWDnGFlNEdo/3Tp8Xk KRXUqfk6amCLw3ehoN9YxTQgrVBQOAM7dN0AJMM8sbb3L238cRt6N3VDrqNYEMp/S8T94S8CCoC U= X-Gm-Gg: AfdE7cn6QNY5VbzQpugLDTqRivWWjjaX3kXSUcX4JB9pRkVn3W8pvSZ5s3C67bzdeoE obATwWWamGK61Gl1yr8I3PjeuGpishGQJ3sweRAgmM1FlCT+8x5PC4jYNLOr7/efseTZCXD2qkc Ur57wx7mMb3a16G2kW5LAoPEgz8EgrgiEWdP0pEz0t8jODfr8JdeSnr5gc1DTmgfc0XpteL8Xn3 Cirbh2CT6cgyAE0G4TJZdUZZT20D9faO/gEf7yUY322b+2fBgUyY2f+bPSIdcDVKs5nGJBD/9Nq yxjuoTEC+udYk3d1lrAwwQRYGbjoMxiwqGSD4xQS48DsWbxfZC9RhAJQ9egP7w3HnQpFDPpncFI A6Y+VYoK1DSR3h9zuyMAz+0wVmfVTLerIKvM= X-Received: by 2002:a05:620a:628f:b0:911:295d:59a1 with SMTP id af79cd13be357-925ca2880ebmr420613785a.8.1782209797947; Tue, 23 Jun 2026 03:16:37 -0700 (PDT) X-Received: by 2002:a05:620a:628f:b0:911:295d:59a1 with SMTP id af79cd13be357-925ca2880ebmr420611585a.8.1782209797551; Tue, 23 Jun 2026 03:16:37 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c5e498cedsm486010966b.4.2026.06.23.03.16.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 03:16:36 -0700 (PDT) Message-ID: <77b8d5ce-0e05-41af-8f04-ea38675bc471@oss.qualcomm.com> Date: Tue, 23 Jun 2026 12:16:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: dwc3: qcom: make dwc3_qcom_glue_ops static To: Ben Dooks , Thinh Nguyen , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260623100000.718126-1-ben.dooks@codethink.co.uk> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260623100000.718126-1-ben.dooks@codethink.co.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA4MyBTYWx0ZWRfXyj4Ec4+eK9Cb itjdm+y6SVz2Beu5qXvmWNhhauDPnhzKMTNsUZtyWdKb57y9c5LJdirWq+eyfra+Z4vEPZXj3rX 9M7LmIC2lYhUYHirKwRPwVXNlE5ULwQZ3/KISX2dewTU5jHJx6bBlVgAmZZ0fSGuTIiGwfBb3xH QzR2CItI3l5zaVg5MDMq4xU5rtWEe1VBgz7qyajD30LP7Rl3y8caSqdDJM3iF+ZwRqpswUxuBEa yAq1RSZtArPx0GV93OsqHACxU0J7xqDohN6cAygbfQ5AnESdl+xk/GI6zTjsJHYR9w6r3TClT09 aYPbKi7JSBALumTsiEowxgRuKsK403jHz9kGQC4OLfcSojcCRRvPNOMVtV37HT1h0FvEje6goWr B7hz2EGgS/5Z+JpNXN2lrym8AOmQy2tZ73Iz2lCqYSJSLO1ggbwT9KOBrjqPTFVuCsUGriNGS+k RCcI/6GOf0/Kn+FGGnA== X-Proofpoint-GUID: JMB8qqEU31_QI4f_O4TA_FL8GCFPCAEF X-Authority-Analysis: v=2.4 cv=dvfrzVg4 c=1 sm=1 tr=0 ts=6a3a5d06 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=1EsaE_6oAAAA:8 a=EUspDBNiAAAA:8 a=wVS3_rNZUYXMhOvZQHMA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=3ZumFrijQQ-2J9H5h8ct:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA4MyBTYWx0ZWRfX3bK8GC4JjDPa +r8sjj37r23hdkygaEyOcPOdvLNo+da595VBIln55/RW0VOgdP3WEyqaJOVPwTDEL9q10B/bllt HL3/cuu1KjYlljtC5gYpkHXv3+prJtA= X-Proofpoint-ORIG-GUID: JMB8qqEU31_QI4f_O4TA_FL8GCFPCAEF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230083 On 6/23/26 12:00 PM, Ben Dooks wrote: > The dwc3_qcom_glue_ops is not used outside of the file it is declared in > , so make it static to avoid the following warning: Odd to begin a line with a comma> > drivers/usb/dwc3/dwc3-qcom.c:605:22: warning: symbol 'dwc3_qcom_glue_ops' was not declared. Should it be static? > > Signed-off-by: Ben Dooks > --- for the change: Reviewed-by: Konrad Dybcio Konrad